From: Andrii Nakryiko <andriin@fb.com>
To: <bpf@vger.kernel.org>, <netdev@vger.kernel.org>, <ast@fb.com>,
<daniel@iogearbox.net>
Cc: <andrii.nakryiko@gmail.com>, <kernel-team@fb.com>,
Andrii Nakryiko <andriin@fb.com>
Subject: [PATCH bpf-next 1/4] libbpf: fix error handling bug in btf_dump__new
Date: Thu, 16 Jan 2020 22:07:58 -0800 [thread overview]
Message-ID: <20200117060801.1311525-2-andriin@fb.com> (raw)
In-Reply-To: <20200117060801.1311525-1-andriin@fb.com>
Fix missing jump to error handling in btf_dump__new, found by Coverity static
code analysis.
Fixes: 9f81654eebe8 ("libbpf: Expose BTF-to-C type declaration emitting API")
Signed-off-by: Andrii Nakryiko <andriin@fb.com>
---
tools/lib/bpf/btf_dump.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/lib/bpf/btf_dump.c b/tools/lib/bpf/btf_dump.c
index 885acebd4396..bd09ed1710f1 100644
--- a/tools/lib/bpf/btf_dump.c
+++ b/tools/lib/bpf/btf_dump.c
@@ -142,6 +142,7 @@ struct btf_dump *btf_dump__new(const struct btf *btf,
if (IS_ERR(d->type_names)) {
err = PTR_ERR(d->type_names);
d->type_names = NULL;
+ goto err;
}
d->ident_names = hashmap__new(str_hash_fn, str_equal_fn, NULL);
if (IS_ERR(d->ident_names)) {
--
2.17.1
next prev parent reply other threads:[~2020-01-17 6:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-17 6:07 [PATCH bpf-next 0/4] Fix few unrelated small bugs and issues Andrii Nakryiko
2020-01-17 6:07 ` Andrii Nakryiko [this message]
2020-01-17 6:07 ` [PATCH bpf-next 2/4] libbpf: simplify BTF initialization logic Andrii Nakryiko
2020-01-17 6:08 ` [PATCH bpf-next 3/4] libbpf: fix potential multiplication overflow in mmap() size calculation Andrii Nakryiko
2020-01-17 6:08 ` [PATCH bpf-next 4/4] bpftool: avoid const discard compilation warning Andrii Nakryiko
2020-01-17 15:55 ` Quentin Monnet
2020-01-17 19:03 ` Andrii Nakryiko
2020-01-17 16:35 ` [PATCH bpf-next 0/4] Fix few unrelated small bugs and issues Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200117060801.1311525-2-andriin@fb.com \
--to=andriin@fb.com \
--cc=andrii.nakryiko@gmail.com \
--cc=ast@fb.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).