From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6878BC34031 for ; Tue, 18 Feb 2020 21:29:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 31AB821D56 for ; Tue, 18 Feb 2020 21:29:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582061365; bh=AeaVF7cdx9bjVEI17/6VTUhvG6l0HOjiZgrtcvd3irs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=s1LNoQUq+Q5Fg/SAoUcNmKBVeyk9Fzcl04FRk1BsJLZxfNeC7/s4gamHcKCoLblFl 5+HItrbXhOhZlJxGBsqzMPxrHHtUb/B25B1Qke3Uq0Sb1lHG1Ib/VSjAQI9m06olUa IfYzXgQUOP2N81gFLNJzQI/nBupVCv/idQaN9SMg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727470AbgBRV3Z (ORCPT ); Tue, 18 Feb 2020 16:29:25 -0500 Received: from mail.kernel.org ([198.145.29.99]:45138 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726339AbgBRV3Y (ORCPT ); Tue, 18 Feb 2020 16:29:24 -0500 Received: from kicinski-fedora-PC1C0HJN (unknown [163.114.132.128]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D00962173E; Tue, 18 Feb 2020 21:29:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582061364; bh=AeaVF7cdx9bjVEI17/6VTUhvG6l0HOjiZgrtcvd3irs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=WZ4TP1cmZJaBma+E9WEjaNvqCPFvch/YA8GyJ9yxL7tlEcKmLScZzMk0U1FdMRBUA XRcOufLhxdCPKmcRQ580jpBdYsThsGgL+E5SK65nOwixKLgeSAo++BwVEubkLlDs+x 72PKBWgOh9LpAHxBbPqz3KJeGUYuzX4Z5heRFaIs= Date: Tue, 18 Feb 2020 13:29:21 -0800 From: Jakub Kicinski To: Lorenzo Bianconi Cc: netdev@vger.kernel.org, ilias.apalodimas@linaro.org, davem@davemloft.net, lorenzo.bianconi@redhat.com, andrew@lunn.ch, brouer@redhat.com, dsahern@kernel.org, bpf@vger.kernel.org Subject: Re: [RFC net-next] net: mvneta: align xdp stats naming scheme to mlx5 driver Message-ID: <20200218132921.46df7f8b@kicinski-fedora-PC1C0HJN> In-Reply-To: <526238d9bcc60500ed61da1a4af8b65af1af9583.1581984697.git.lorenzo@kernel.org> References: <526238d9bcc60500ed61da1a4af8b65af1af9583.1581984697.git.lorenzo@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Tue, 18 Feb 2020 01:14:29 +0100 Lorenzo Bianconi wrote: > Introduce "rx" prefix in the name scheme for xdp counters > on rx path. > Differentiate between XDP_TX and ndo_xdp_xmit counters > > Signed-off-by: Lorenzo Bianconi Sorry for coming in late. I thought the ability to attach a BPF program to a fexit of another BPF program will put an end to these unnecessary statistics. IOW I maintain my position that there should be no ethtool stats for XDP. As discussed before real life BPF progs will maintain their own stats at the granularity of their choosing, so we're just wasting datapath cycles. The previous argument that the BPF prog stats are out of admin control is no longer true with the fexit option (IIUC how that works).