From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF017C3402F for ; Wed, 19 Feb 2020 03:31:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7C1162465A for ; Wed, 19 Feb 2020 03:31:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582083074; bh=X4/RKCS1sVnNw4Z8r1AfKIDyTAUh1uAp+I/zVjk2I6U=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=z24i/UXI9QnToarXaQG0P6Y1NIxdMpDG2RkADWZUMile6xFJUtK+LFGtCcSpX7u/n MKY+RbEtmXPQrmUSBK9aVJH6BnNbm96RwVZwW7sJmd9OL7TIYzl42kRfLUupgFTmEV NGh+p1MvTO1b3url2m30jNxtPim8Ds7pcrcAu8Mk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726651AbgBSDbO (ORCPT ); Tue, 18 Feb 2020 22:31:14 -0500 Received: from mail.kernel.org ([198.145.29.99]:42020 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726439AbgBSDbO (ORCPT ); Tue, 18 Feb 2020 22:31:14 -0500 Received: from kicinski-fedora-PC1C0HJN (unknown [163.114.132.128]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 12BF024658; Wed, 19 Feb 2020 03:31:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582083073; bh=X4/RKCS1sVnNw4Z8r1AfKIDyTAUh1uAp+I/zVjk2I6U=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=n1RO+JGRMuytP7GHr5sjv/RX7Y7BV/+rqkm6x5Cxipm8V5Pl51EW/VAONik7bAWrI evLnBKbLel1xQhU6aAiRza+myTLz8CA37YbqvMh9q+kJpL2WiI5r+Kca7hgP4W/5nk AMKhAYm6Pr5g18+oM31EW5FQ1VtnXuG4V/QP5Emc= Date: Tue, 18 Feb 2020 19:31:11 -0800 From: Jakub Kicinski To: David Miller Cc: toke@redhat.com, lorenzo@kernel.org, netdev@vger.kernel.org, ilias.apalodimas@linaro.org, lorenzo.bianconi@redhat.com, andrew@lunn.ch, brouer@redhat.com, dsahern@kernel.org, bpf@vger.kernel.org Subject: Re: [RFC net-next] net: mvneta: align xdp stats naming scheme to mlx5 driver Message-ID: <20200218193111.3b6d6e47@kicinski-fedora-PC1C0HJN> In-Reply-To: <20200218.154713.1411536344737312845.davem@davemloft.net> References: <526238d9bcc60500ed61da1a4af8b65af1af9583.1581984697.git.lorenzo@kernel.org> <20200218132921.46df7f8b@kicinski-fedora-PC1C0HJN> <87eeury1ph.fsf@toke.dk> <20200218.154713.1411536344737312845.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Tue, 18 Feb 2020 15:47:13 -0800 (PST) David Miller wrote: > Really, mistakes happen and a poorly implemented or inserted fexit > module should not be a reason to not have access to accurate and > working statistics for fundamental events. > > I am therefore totally against requiring fexit for this functionality. > If you want more sophisticated events or custome ones, sure, but not > for this baseline stuff. > > I do, however, think we need a way to turn off these counter bumps if > the user wishes to do so for maximum performance. Yes, this point plus the precedence you mentioned elsewhere are quite hard to contend with. In an ideal world I was wondering if we could have the kernel install the fexit hook, a'la what we do with drop monitor using tracepoints from within the kernel. Then have a proper netlink stats group for them, instead of the ethtool free-form endlessly bikesheddable strings. But I guess it could be hard to easily recover the source interface pointer without digging through NAPI instances or such :S