From: KP Singh <kpsingh@chromium.org>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: KP Singh <kpsingh@chromium.org>,
linux-security-module@vger.kernel.org,
open list <linux-kernel@vger.kernel.org>,
bpf <bpf@vger.kernel.org>, Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Paul Turner <pjt@google.com>, Jann Horn <jannh@google.com>,
Florent Revest <revest@chromium.org>,
Brendan Jackman <jackmanb@chromium.org>
Subject: Re: [PATCH bpf-next v2 2/7] bpf: JIT helpers for fmod_ret progs
Date: Wed, 4 Mar 2020 16:24:50 +0100 [thread overview]
Message-ID: <20200304152450.GA53576@google.com> (raw)
In-Reply-To: <CAEf4Bzah9CpWJ1vLuy+V1K26Ka1ovKvvAnbRuYBJ1GF-xcQbJQ@mail.gmail.com>
On 03-Mar 20:52, Andrii Nakryiko wrote:
> On Tue, Mar 3, 2020 at 5:56 PM KP Singh <kpsingh@chromium.org> wrote:
> >
> > From: KP Singh <kpsingh@google.com>
> >
> > * Split the invoke_bpf program to prepare for special handling of
> > fmod_ret programs introduced in a subsequent patch.
> > * Move the definition of emit_cond_near_jump and emit_nops as they are
> > needed for fmod_ret.
> > * Refactor branch target alignment into its own function
> > align16_branch_target.
I updated this as well, as we changed it to emit_align.
- KP
> >
> > Signed-off-by: KP Singh <kpsingh@google.com>
> > ---
>
> I trust invoke_bpf_prog logic didn't change, code was just moved around, right?
>
> Acked-by: Andrii Nakryiko <andriin@fb.com>
>
>
> > arch/x86/net/bpf_jit_comp.c | 148 +++++++++++++++++++++---------------
> > 1 file changed, 85 insertions(+), 63 deletions(-)
> >
>
> [...]
next prev parent reply other threads:[~2020-03-04 15:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-04 1:55 [PATCH bpf-next v2 0/7] Introduce BPF_MODIFY_RET tracing progs KP Singh
2020-03-04 1:55 ` [PATCH bpf-next v2 1/7] bpf: Refactor trampoline update code KP Singh
2020-03-04 4:49 ` Andrii Nakryiko
2020-03-04 15:11 ` KP Singh
2020-03-04 1:55 ` [PATCH bpf-next v2 2/7] bpf: JIT helpers for fmod_ret progs KP Singh
2020-03-04 4:52 ` Andrii Nakryiko
2020-03-04 15:11 ` KP Singh
2020-03-04 15:24 ` KP Singh [this message]
2020-03-04 1:55 ` [PATCH bpf-next v2 3/7] bpf: Introduce BPF_MODIFY_RETURN KP Singh
2020-03-04 5:08 ` Andrii Nakryiko
2020-03-04 15:13 ` KP Singh
2020-03-04 1:55 ` [PATCH bpf-next v2 4/7] bpf: Attachment verification for BPF_MODIFY_RETURN KP Singh
2020-03-04 5:12 ` Andrii Nakryiko
2020-03-04 15:13 ` KP Singh
2020-03-04 1:55 ` [PATCH bpf-next v2 5/7] tools/libbpf: Add support " KP Singh
2020-03-04 1:55 ` [PATCH bpf-next v2 6/7] bpf: Add test ops for BPF_PROG_TYPE_TRACING KP Singh
2020-03-04 5:14 ` Andrii Nakryiko
2020-03-04 1:55 ` [PATCH bpf-next v2 7/7] bpf: Add selftests for BPF_MODIFY_RETURN KP Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200304152450.GA53576@google.com \
--to=kpsingh@chromium.org \
--cc=andrii.nakryiko@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jackmanb@chromium.org \
--cc=jannh@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=pjt@google.com \
--cc=revest@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).