From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67741C10DCE for ; Wed, 11 Mar 2020 01:10:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 15C5421927 for ; Wed, 11 Mar 2020 01:10:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ky5RLIT1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728042AbgCKBKA (ORCPT ); Tue, 10 Mar 2020 21:10:00 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:54869 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727944AbgCKBJc (ORCPT ); Tue, 10 Mar 2020 21:09:32 -0400 Received: by mail-wm1-f66.google.com with SMTP id n8so282065wmc.4; Tue, 10 Mar 2020 18:09:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RuNOtjoIJ0PnueFmG34tyRMkYyJp/CS0kq/rmnLgTB8=; b=Ky5RLIT1Z12v+Tdj/SdmCF8yw8/esVe5wN2flSN6DvbtJiYTMcBZoKa8hjbCs/bABz dVkGsVx54HA62EKm6qRRC6fj5KrntxmxmLoSmTDHVN972WG02Pen5xBHVFzQnuSfMU2V x7Ya3EYfSOe4yxQfIBFPKfL4TtTzK3JxbGNHDf6he0YAHSD8YflAJ7j1+cjS42ti1QRb aUFiKBScPT4iy9+l0qY0Kah97UmvwP2sMgs4R6pfzhZ8aERSdxLz2trLB6ly3ozvc3Ys RlX3d6Moqp6pUOvX0Dh9Ctbk0R84djgtsCwsk3uEB4yqGsJ2ngqQYVqf+YGxAxw7jXR8 Q1Jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RuNOtjoIJ0PnueFmG34tyRMkYyJp/CS0kq/rmnLgTB8=; b=swWPofLKhMIXhvf4tAiemiRGNn+1gtteFsLdD+xLtE13653MYqVC4wf+ZbLjPV37gu ztVvSiWDfS4az4CqFtLJVUo/ohnSdKPbJSg1xP8VRnnhEzqstLiPNSIsFSDGqX0eDPPl Vd0uBIc/4KzBnI7E0A3GGCIYKdd6qVMW+lV3GZSXdRhxeoTDEYZ7QJ+pTFD17Td9ITl/ IrA+6XhZS1DWWyGTfl2R8YwbYHh2yKgkOHbbFS+fUYzGW2iQCquZf5z5m/OkdEdDm2rc /BCBOuUsXTly2mffbBqqwyg7mmw/R7wAk8QTKqiG+KsnKM0yKB7GuzARKKa2+6gob733 gQJw== X-Gm-Message-State: ANhLgQ0Qt8wIg/ec8tSusWzx1IiWdM1MnEf6cIFP85wrEKZyZqdELW6c 3oUBWQ7YoHodV46Tja8uHQ== X-Google-Smtp-Source: ADFU+vstobGIfUQ6tm+MOVwHT3BG0QrGLRFILKpE5LfNWrPT2WL1JG1k54PECBlvcaTJ+wBoJRZF5Q== X-Received: by 2002:a1c:1fc7:: with SMTP id f190mr441997wmf.2.1583888969521; Tue, 10 Mar 2020 18:09:29 -0700 (PDT) Received: from ninjahost.lan (host-2-102-15-144.as13285.net. [2.102.15.144]) by smtp.googlemail.com with ESMTPSA id i6sm36658097wra.42.2020.03.10.18.09.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2020 18:09:29 -0700 (PDT) From: Jules Irenge To: boqun.feng@gmail.com Cc: linux-kernel@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Jakub Kicinski , netfilter-devel@vger.kernel.org (open list:NETFILTER), coreteam@netfilter.org (open list:NETFILTER) Subject: [PATCH 4/8] netfilter: Add missing annotation for ctnetlink_parse_nat_setup() Date: Wed, 11 Mar 2020 01:09:04 +0000 Message-Id: <20200311010908.42366-5-jbi.octave@gmail.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200311010908.42366-1-jbi.octave@gmail.com> References: <0/8> <20200311010908.42366-1-jbi.octave@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org Sparse reports a warning at ctnetlink_parse_nat_setup() warning: context imbalance in ctnetlink_parse_nat_setup() - unexpected unlock The root cause is the missing annotation at ctnetlink_parse_nat_setup() Add the missing __must_hold(RCU) annotation Signed-off-by: Jules Irenge --- net/netfilter/nf_conntrack_netlink.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/netfilter/nf_conntrack_netlink.c b/net/netfilter/nf_conntrack_netlink.c index 6a1c8f1f6171..eb190206cd12 100644 --- a/net/netfilter/nf_conntrack_netlink.c +++ b/net/netfilter/nf_conntrack_netlink.c @@ -1533,6 +1533,7 @@ static int ctnetlink_parse_nat_setup(struct nf_conn *ct, enum nf_nat_manip_type manip, const struct nlattr *attr) + __must_hold(RCU) { struct nf_nat_hook *nat_hook; int err; -- 2.24.1