From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D2D7C2BB1D for ; Wed, 11 Mar 2020 22:14:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3DAFF20746 for ; Wed, 11 Mar 2020 22:14:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=fomichev-me.20150623.gappssmtp.com header.i=@fomichev-me.20150623.gappssmtp.com header.b="l6iSu1+Q" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729590AbgCKWO2 (ORCPT ); Wed, 11 Mar 2020 18:14:28 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:40682 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730049AbgCKWO2 (ORCPT ); Wed, 11 Mar 2020 18:14:28 -0400 Received: by mail-pg1-f194.google.com with SMTP id t24so1950580pgj.7 for ; Wed, 11 Mar 2020 15:14:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fomichev-me.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=TRMbc2MT59fcHMzxfJmkV+RwRUiISDxKXrIl7C0tzJ8=; b=l6iSu1+QIjuheIWrgAg7mrwXqXl4LzW6ZTeMnsYUqW03Pd6q9qM1pVhqqIALR+rOPT 7zVVFhKtL5CVS8e8dXYeyjEhvdQ3KFFaHY7mCAcnyi+KtqTVaFj8UAPfl0ftPKwf6C3P k0mqhnv01geSKL4uUnr3aOXOU6FKSrq6GznHHbMfav9qTnoGBT94VsY8iKyDL0g2NZEv h/VhhM+cTRmhrp+RZxhHKx+uODfewUFx7G8ueKdDL1NXLTf1zVRytgn4DILI9FzIWKRy vg42kxErzDyh1fzCAMTG2NW5FI1qc8LlfySoXMxArOFcw7NQd1PSuKNlJSGp4HtkdBom plSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=TRMbc2MT59fcHMzxfJmkV+RwRUiISDxKXrIl7C0tzJ8=; b=WjaQeKV3OjKVvfY2T4r7m9lbJzwk0Z6ZtfMIFh3qSB5wPr/0i8nPnLrkc41soevgga 3yzgzfMCMlzibCy5p7rwJIzKf5bXbR8rlaKLUbIy4WNL0n3pGY6LZadwkWa/hrnLepRF xwZWOnh/HKHxSUxCVvJNu5SCVbdKF6qsiMgbn6rRcHx9wEKbHJapGooYW4jE2b6ouKiK aJM68rAyFxldCn9XCApaIKe8J3aytIyZZKmYgCxx0mHXxWq1F49Nr8iilc/YsoN3aYwb EAHBqJy4dI2WOT8wpwJcfcXHYeK9P1OYOqaTK4mHQAA2H0nCfB8ZccZenn4hE9jmEzt+ lUAA== X-Gm-Message-State: ANhLgQ2lDCTfJUnF1hcvvSqc8tVMyR+V3rTCuCVQYqt3XaYR4LUUSsYk +y2GRh1eQh5E3ttqErxIo2ZPcA== X-Google-Smtp-Source: ADFU+vvxWT/FHdVxFcVplZDdwO7f6/ZRxvRLLxHD0gNMNuvrQ2bmwbRKmm0zyI3X9jqYYREwWoXAYg== X-Received: by 2002:a63:be09:: with SMTP id l9mr4659363pgf.439.1583964865600; Wed, 11 Mar 2020 15:14:25 -0700 (PDT) Received: from localhost ([2601:646:8f00:18d9:d0fa:7a4b:764f:de48]) by smtp.gmail.com with ESMTPSA id v16sm6504587pjr.11.2020.03.11.15.14.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Mar 2020 15:14:25 -0700 (PDT) Date: Wed, 11 Mar 2020 15:14:24 -0700 From: Stanislav Fomichev To: Andrii Nakryiko Cc: Andrii Nakryiko , bpf , Networking , Alexei Starovoitov , Daniel Borkmann , Stanislav Fomichev , Kernel Team Subject: Re: [PATCH bpf-next] selftests/bpf: make tcp_rtt test more robust to failures Message-ID: <20200311221424.GB2125642@mini-arch.hsd1.ca.comcast.net> References: <20200311191513.3954203-1-andriin@fb.com> <20200311204106.GA2125642@mini-arch.hsd1.ca.comcast.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.2 (2019-09-21) Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On 03/11, Andrii Nakryiko wrote: > On Wed, Mar 11, 2020 at 1:41 PM Stanislav Fomichev wrote: > > > > On 03/11, Andrii Nakryiko wrote: > > [..] > > > + pthread_join(tid, &server_res); > > > + CHECK_FAIL(IS_ERR(server_res)); > > > > I wonder if we add (move) close(server_fd) before pthread_join(), can we > > fix this issue without using non-blocking socket? The accept() should > > return as soon as server_fd is closed so it's essentially your > > 'server_done'. > > That was my first attempt. Amazingly, closing listening socket FD > doesn't unblock accept()... Ugh :-( In this case, feel free to slap: Reviewed-by: Stanislav Fomichev My only other (minor) suggestion was to add a small delay in the first loop: while (!server_done) { accept() if (!err) { udelay(50) <-- continue } } But I suppose that shouldn't be that big of a deal..