From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Andrii Nakryiko <andriin@fb.com>
Cc: bpf@vger.kernel.org, netdev@vger.kernel.org, ast@fb.com,
daniel@iogearbox.net, andrii.nakryiko@gmail.com,
kernel-team@fb.com
Subject: Re: [PATCH v2 bpf-next] bpf: abstract away entire bpf_link clean up procedure
Date: Thu, 12 Mar 2020 18:50:12 -0700 [thread overview]
Message-ID: <20200313015012.nejdagphpe44k27i@ast-mbp> (raw)
In-Reply-To: <20200313002128.2028680-1-andriin@fb.com>
On Thu, Mar 12, 2020 at 05:21:28PM -0700, Andrii Nakryiko wrote:
> Instead of requiring users to do three steps for cleaning up bpf_link, its
> anon_inode file, and unused fd, abstract that away into bpf_link_cleanup()
> helper. bpf_link_defunct() is removed, as it shouldn't be needed as an
> individual operation anymore.
>
> v1->v2:
> - keep bpf_link_cleanup() static for now (Daniel).
>
> Signed-off-by: Andrii Nakryiko <andriin@fb.com>
Applied.
But noticed that the test is now sporadically failing:
./test_progs -n 24
test_link_pinning:PASS:skel_open 0 nsec
test_link_pinning_subtest:PASS:link_attach 0 nsec
test_link_pinning_subtest:PASS:res_check1 0 nsec
test_link_pinning_subtest:PASS:link_pin 0 nsec
test_link_pinning_subtest:PASS:pin_path1 0 nsec
test_link_pinning_subtest:PASS:stat_link 0 nsec
test_link_pinning_subtest:PASS:res_check2 0 nsec
test_link_pinning_subtest:PASS:res_check3 0 nsec
test_link_pinning_subtest:PASS:link_open 0 nsec
test_link_pinning_subtest:PASS:pin_path2 0 nsec
test_link_pinning_subtest:PASS:link_unpin 0 nsec
test_link_pinning_subtest:PASS:res_check4 0 nsec
test_link_pinning_subtest:FAIL:link_attached got to iteration #10000
#24/1 pin_raw_tp:FAIL
test_link_pinning_subtest:PASS:link_attach 0 nsec
test_link_pinning_subtest:PASS:res_check1 0 nsec
test_link_pinning_subtest:PASS:link_pin 0 nsec
test_link_pinning_subtest:PASS:pin_path1 0 nsec
test_link_pinning_subtest:PASS:stat_link 0 nsec
test_link_pinning_subtest:PASS:res_check2 0 nsec
test_link_pinning_subtest:PASS:res_check3 0 nsec
test_link_pinning_subtest:PASS:link_open 0 nsec
test_link_pinning_subtest:PASS:pin_path2 0 nsec
test_link_pinning_subtest:PASS:link_unpin 0 nsec
test_link_pinning_subtest:PASS:res_check4 0 nsec
test_link_pinning_subtest:FAIL:link_attached got to iteration #10000
#24/2 pin_tp_btf:FAIL
#24 link_pinning:FAIL
Summary: 0/0 PASSED, 0 SKIPPED, 3 FAILED
it's failing more often than passing, actually.
The #64 tcp_rtt also started to fail sporadically.
But I wonder whether it's leftover from 24. shrug.
next prev parent reply other threads:[~2020-03-13 1:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 0:21 [PATCH v2 bpf-next] bpf: abstract away entire bpf_link clean up procedure Andrii Nakryiko
2020-03-13 0:46 ` [Potential Spoof] " Martin KaFai Lau
2020-03-13 1:50 ` Alexei Starovoitov [this message]
2020-03-13 5:04 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200313015012.nejdagphpe44k27i@ast-mbp \
--to=alexei.starovoitov@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andriin@fb.com \
--cc=ast@fb.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).