From: Martin KaFai Lau <kafai@fb.com>
To: Andrii Nakryiko <andriin@fb.com>
Cc: <bpf@vger.kernel.org>, <netdev@vger.kernel.org>, <ast@fb.com>,
<daniel@iogearbox.net>, <andrii.nakryiko@gmail.com>,
<kernel-team@fb.com>
Subject: Re: [PATCH bpf-next 0/4] CO-RE candidate matching fix and tracing test
Date: Fri, 13 Mar 2020 10:47:19 -0700 [thread overview]
Message-ID: <20200313174719.3rgo75kkewunndnl@kafai-mbp> (raw)
In-Reply-To: <20200313172336.1879637-1-andriin@fb.com>
On Fri, Mar 13, 2020 at 10:23:32AM -0700, Andrii Nakryiko wrote:
> This patch set fixes bug in CO-RE relocation candidate finding logic, which
> currently allows matching against forward declarations, functions, and other
> named types, even though it makes no sense to even attempt. As part of
> verifying the fix, add test using vmlinux.h with preserve_access_index
> attribute and utilizing struct pt_regs heavily to trace nanosleep syscall
> using 5 different types of tracing BPF programs.
>
> This test also demonstrated problems using struct pt_regs in syscall
> tracepoints and required a new set of macro, which were added in patch #3 into
> bpf_tracing.h.
>
> Patch #1 fixes annoying issue with selftest failure messages being out of
> sync.
>
> v1->v2:
> - drop unused handle__probed() function (Martin).
Acked-by: Martin KaFai Lau <kafai@fb.com>
next prev parent reply other threads:[~2020-03-13 17:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 17:23 [PATCH bpf-next 0/4] CO-RE candidate matching fix and tracing test Andrii Nakryiko
2020-03-13 17:23 ` [PATCH bpf-next 1/4] selftests/bpf: ensure consistent test failure output Andrii Nakryiko
2020-03-13 17:23 ` [PATCH bpf-next 2/4] libbpf: ignore incompatible types with matching name during CO-RE relocation Andrii Nakryiko
2020-03-13 17:23 ` [PATCH bpf-next 3/4] libbpf: provide CO-RE variants of PT_REGS macros Andrii Nakryiko
2020-03-13 17:23 ` [PATCH bpf-next 4/4] selftests/bpf: add vmlinux.h selftest exercising tracing of syscalls Andrii Nakryiko
2020-03-13 17:47 ` Martin KaFai Lau [this message]
2020-03-13 22:36 ` [PATCH bpf-next 0/4] CO-RE candidate matching fix and tracing test Daniel Borkmann
-- strict thread matches above, loose matches on Subject: below --
2020-03-13 7:54 Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200313174719.3rgo75kkewunndnl@kafai-mbp \
--to=kafai@fb.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andriin@fb.com \
--cc=ast@fb.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).