From: Martin KaFai Lau <kafai@fb.com>
To: Andrii Nakryiko <andriin@fb.com>
Cc: <bpf@vger.kernel.org>, <netdev@vger.kernel.org>, <ast@fb.com>,
<daniel@iogearbox.net>, <andrii.nakryiko@gmail.com>,
<kernel-team@fb.com>
Subject: Re: [Potential Spoof] [PATCH bpf-next] selftest/bpf: fix compilation warning in sockmap_parse_prog.c
Date: Fri, 13 Mar 2020 16:53:09 -0700 [thread overview]
Message-ID: <20200313235309.34matqh7iaahawkf@kafai-mbp> (raw)
In-Reply-To: <20200313230715.3287973-1-andriin@fb.com>
On Fri, Mar 13, 2020 at 04:07:15PM -0700, Andrii Nakryiko wrote:
> Cast void * to long before casting to 32-bit __u32 to avoid compilation
> warning.
>
> Signed-off-by: Andrii Nakryiko <andriin@fb.com>
> ---
> tools/testing/selftests/bpf/progs/sockmap_parse_prog.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/bpf/progs/sockmap_parse_prog.c b/tools/testing/selftests/bpf/progs/sockmap_parse_prog.c
> index a5c6d5903b22..a9c2bdbd841e 100644
> --- a/tools/testing/selftests/bpf/progs/sockmap_parse_prog.c
> +++ b/tools/testing/selftests/bpf/progs/sockmap_parse_prog.c
> @@ -12,7 +12,7 @@ int bpf_prog1(struct __sk_buff *skb)
> __u32 lport = skb->local_port;
> __u32 rport = skb->remote_port;
> __u8 *d = data;
> - __u32 len = (__u32) data_end - (__u32) data;
I think this line can be removed. "len" is not used.
> + __u32 len = (__u32)(long)data_end - (__u32)(long)data;
> int err;
>
> if (data + 10 > data_end) {
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-03-13 23:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 23:07 [PATCH bpf-next] selftest/bpf: fix compilation warning in sockmap_parse_prog.c Andrii Nakryiko
2020-03-13 23:53 ` Martin KaFai Lau [this message]
2020-03-13 23:58 ` [Potential Spoof] " Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200313235309.34matqh7iaahawkf@kafai-mbp \
--to=kafai@fb.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andriin@fb.com \
--cc=ast@fb.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).