From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5D50C54FCE for ; Tue, 24 Mar 2020 23:31:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AF1C320724 for ; Tue, 24 Mar 2020 23:31:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="mg3UefJ7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726643AbgCXXb1 (ORCPT ); Tue, 24 Mar 2020 19:31:27 -0400 Received: from mail-qk1-f201.google.com ([209.85.222.201]:52598 "EHLO mail-qk1-f201.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726565AbgCXXb0 (ORCPT ); Tue, 24 Mar 2020 19:31:26 -0400 Received: by mail-qk1-f201.google.com with SMTP id w124so84376qkd.19 for ; Tue, 24 Mar 2020 16:31:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:message-id:mime-version:subject:from:to:cc; bh=PT/MWuZ7SA7hBzLYl9mF76R2EBAF0dWL8M0nfy7RbDQ=; b=mg3UefJ7KwGRwb4hGnrVu8LXiy0YBQAVa7mY95S3SyftRz3m7Fipk24W8qgT/viPFZ NhzWDfXainEC0FmsDKrYLf/xxEtqHVDO7ZljV9to3Cnhc+TFaehQcQwUXbIBsyyRFYEQ QiXkRPpoIcxG4E3Q/sMCn9j3EV/nf+uwDOHQdQ3OAmiZYrWNPMiEVruH6gQV8DLm4bYA WpbRH2PL83o6lFJ/MF+EtOYbQqCFf5ov/Xfm9p7rmNIsT3d3z9NyRD2BgkmhmQVjd07i hjIXVVWZ2S8Cgg4mni9NjjgmG7EfVnvjP3lIN3ZT4xtzo8K+1x9s4/goADBGlZhA4pis qogA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=PT/MWuZ7SA7hBzLYl9mF76R2EBAF0dWL8M0nfy7RbDQ=; b=ErktYNOggH/4Ai2HJkmq8B49uUrSDVs8yKwk7xF96y126QaZL9P/NhWmROIdOaqZtp UKg3biRVJFWeDe3w8ltl6zIp/CLGwwO8qj9yKcVyawgxs563kB5Wh6Z2NFdswuD/DMmB RxGTpJQC0o9KagEVWRGLsLjxv8GLDExlTLePfXdqT0DPQxF9ktVGLhaisA+2IB094Xii xzE9qBw3sZEXDfSZW9RZKRa9uDWJVIFk7eT5Rvw9pgqZm69P6BuI2Ni1M2e/N3OrZQuS EPDPIHtukvlkhIudkJVWgHnQWeJRm90Ky4DPiFhr8naqZia3ym440zU4AdOHZPbtU4EJ W05Q== X-Gm-Message-State: ANhLgQ0YB7FTnGH/WsM7Lq/0gr6JYOiCBjkwFIkAqPzAIcZbC6qIGKpe /7aFP74OGksdE6motQweINmKKF0= X-Google-Smtp-Source: ADFU+vtkiV43eIQRaDiBUs88K/GD/IL0hk+zT61nUTYyMrs+9XCt43Vb1o34lp1v8hd7X9RLPtGTbvQ= X-Received: by 2002:a0c:9aea:: with SMTP id k42mr628210qvf.91.1585092683800; Tue, 24 Mar 2020 16:31:23 -0700 (PDT) Date: Tue, 24 Mar 2020 16:31:20 -0700 Message-Id: <20200324233120.66314-1-sdf@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.25.1.696.g5e7596f4ac-goog Subject: [PATCH bpf-next] libbpf: don't allocate 16M for log buffer by default From: Stanislav Fomichev To: netdev@vger.kernel.org, bpf@vger.kernel.org Cc: davem@davemloft.net, ast@kernel.org, daniel@iogearbox.net, Stanislav Fomichev Content-Type: text/plain; charset="UTF-8" Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org For each prog/btf load we allocate and free 16 megs of verifier buffer. On production systems it doesn't really make sense because the programs/btf have gone through extensive testing and (mostly) guaranteed to successfully load. Let's switch to a much smaller buffer by default (128 bytes, sys_bpf doesn't accept smaller log buffer) and resize it if the kernel returns ENOSPC. On the first ENOSPC error we resize the buffer to BPF_LOG_BUF_SIZE and then, on each subsequent ENOSPC, we keep doubling the buffer. Signed-off-by: Stanislav Fomichev --- tools/lib/bpf/btf.c | 10 +++++++++- tools/lib/bpf/libbpf.c | 10 ++++++++-- tools/lib/bpf/libbpf_internal.h | 2 ++ 3 files changed, 19 insertions(+), 3 deletions(-) diff --git a/tools/lib/bpf/btf.c b/tools/lib/bpf/btf.c index 3d1c25fc97ae..53c7efc3b347 100644 --- a/tools/lib/bpf/btf.c +++ b/tools/lib/bpf/btf.c @@ -657,13 +657,14 @@ int btf__finalize_data(struct bpf_object *obj, struct btf *btf) int btf__load(struct btf *btf) { - __u32 log_buf_size = BPF_LOG_BUF_SIZE; + __u32 log_buf_size = BPF_MIN_LOG_BUF_SIZE; char *log_buf = NULL; int err = 0; if (btf->fd >= 0) return -EEXIST; +retry_load: log_buf = malloc(log_buf_size); if (!log_buf) return -ENOMEM; @@ -673,6 +674,13 @@ int btf__load(struct btf *btf) btf->fd = bpf_load_btf(btf->data, btf->data_size, log_buf, log_buf_size, false); if (btf->fd < 0) { + if (errno == ENOSPC) { + log_buf_size = max((__u32)BPF_LOG_BUF_SIZE, + log_buf_size << 1); + free(log_buf); + goto retry_load; + } + err = -errno; pr_warn("Error loading BTF: %s(%d)\n", strerror(errno), errno); if (*log_buf) diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c index 085e41f9b68e..793c81b35ccc 100644 --- a/tools/lib/bpf/libbpf.c +++ b/tools/lib/bpf/libbpf.c @@ -4855,7 +4855,7 @@ load_program(struct bpf_program *prog, struct bpf_insn *insns, int insns_cnt, { struct bpf_load_program_attr load_attr; char *cp, errmsg[STRERR_BUFSIZE]; - int log_buf_size = BPF_LOG_BUF_SIZE; + size_t log_buf_size = BPF_MIN_LOG_BUF_SIZE; char *log_buf; int btf_fd, ret; @@ -4911,7 +4911,13 @@ load_program(struct bpf_program *prog, struct bpf_insn *insns, int insns_cnt, } if (errno == ENOSPC) { - log_buf_size <<= 1; + if (errno == ENOSPC) { + log_buf_size = max((size_t)BPF_LOG_BUF_SIZE, + log_buf_size << 1); + free(log_buf); + goto retry_load; + } + free(log_buf); goto retry_load; } diff --git a/tools/lib/bpf/libbpf_internal.h b/tools/lib/bpf/libbpf_internal.h index 8c3afbd97747..2720f3366798 100644 --- a/tools/lib/bpf/libbpf_internal.h +++ b/tools/lib/bpf/libbpf_internal.h @@ -23,6 +23,8 @@ #define BTF_PARAM_ENC(name, type) (name), (type) #define BTF_VAR_SECINFO_ENC(type, offset, size) (type), (offset), (size) +#define BPF_MIN_LOG_BUF_SIZE 128 + #ifndef min # define min(x, y) ((x) < (y) ? (x) : (y)) #endif -- 2.25.1.696.g5e7596f4ac-goog