* Re: linux-next: Tree for Mar 30 (bpf)
[not found] ` <86f7031a-57c6-5d50-2788-ae0e06a7c138@infradead.org>
@ 2020-03-30 17:25 ` Daniel Borkmann
2020-03-30 17:54 ` KP Singh
0 siblings, 1 reply; 5+ messages in thread
From: Daniel Borkmann @ 2020-03-30 17:25 UTC (permalink / raw)
To: Randy Dunlap, Stephen Rothwell, Linux Next Mailing List
Cc: Linux Kernel Mailing List, bpf, netdev, kpsingh
[Cc KP, ptal]
On 3/30/20 7:15 PM, Randy Dunlap wrote:
> On 3/30/20 2:43 AM, Stephen Rothwell wrote:
>> Hi all,
>>
>> The merge window has opened, so please do not add any material for the
>> next release into your linux-next included trees/branches until after
>> the merge window closes.
>>
>> Changes since 20200327:
>
> (note: linux-next is based on linux 5.6-rc7)
>
>
> on i386:
>
> ld: kernel/bpf/bpf_lsm.o:(.rodata+0x0): undefined reference to `bpf_tracing_func_proto'
>
>
> Full randconfig file is attached.
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: Tree for Mar 30 (bpf)
2020-03-30 17:25 ` linux-next: Tree for Mar 30 (bpf) Daniel Borkmann
@ 2020-03-30 17:54 ` KP Singh
2020-03-30 18:05 ` KP Singh
0 siblings, 1 reply; 5+ messages in thread
From: KP Singh @ 2020-03-30 17:54 UTC (permalink / raw)
To: Daniel Borkmann
Cc: Randy Dunlap, Stephen Rothwell, Linux Next Mailing List,
Linux Kernel Mailing List, bpf, netdev
Thanks for adding me Daniel, taking a look.
- KP
On Mon, Mar 30, 2020 at 7:25 PM Daniel Borkmann <daniel@iogearbox.net> wrote:
>
> [Cc KP, ptal]
>
> On 3/30/20 7:15 PM, Randy Dunlap wrote:
> > On 3/30/20 2:43 AM, Stephen Rothwell wrote:
> >> Hi all,
> >>
> >> The merge window has opened, so please do not add any material for the
> >> next release into your linux-next included trees/branches until after
> >> the merge window closes.
> >>
> >> Changes since 20200327:
> >
> > (note: linux-next is based on linux 5.6-rc7)
> >
> >
> > on i386:
> >
> > ld: kernel/bpf/bpf_lsm.o:(.rodata+0x0): undefined reference to `bpf_tracing_func_proto'
> >
> >
> > Full randconfig file is attached.
> >
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: Tree for Mar 30 (bpf)
2020-03-30 17:54 ` KP Singh
@ 2020-03-30 18:05 ` KP Singh
2020-03-30 18:15 ` Randy Dunlap
2020-03-30 18:49 ` KP Singh
0 siblings, 2 replies; 5+ messages in thread
From: KP Singh @ 2020-03-30 18:05 UTC (permalink / raw)
To: KP Singh
Cc: Daniel Borkmann, Randy Dunlap, Stephen Rothwell,
Linux Next Mailing List, Linux Kernel Mailing List, bpf, netdev
On 30-Mar 19:54, KP Singh wrote:
So, it looks like bpf_tracing_func_proto is only defined when
CONFIG_BPF_EVENTS is set:
obj-$(CONFIG_BPF_EVENTS) += bpf_trace.o
We have a few options:
* Add a __weak symbol for bpf_tracing_func_proto which we have done in
the past for similar issues. This however, does not make much sense,
as CONFIG_BPF_LSM cannot really do much without its helpers.
* Make CONFIG_BPF_LSM depend on CONFIG_BPF_EVENTS, this should solve
it, but not for this particular Kconfig that was generated. Randy,
I am assuming if we add the dependency, this particular Kconfig
won't be generated.
I am assuming this patch now needs to be sent for "bpf" and not
"bpf-next" as the merge window has opened?
- KP
> Thanks for adding me Daniel, taking a look.
>
> - KP
>
> On Mon, Mar 30, 2020 at 7:25 PM Daniel Borkmann <daniel@iogearbox.net> wrote:
> >
> > [Cc KP, ptal]
> >
> > On 3/30/20 7:15 PM, Randy Dunlap wrote:
> > > On 3/30/20 2:43 AM, Stephen Rothwell wrote:
> > >> Hi all,
> > >>
> > >> The merge window has opened, so please do not add any material for the
> > >> next release into your linux-next included trees/branches until after
> > >> the merge window closes.
> > >>
> > >> Changes since 20200327:
> > >
> > > (note: linux-next is based on linux 5.6-rc7)
> > >
> > >
> > > on i386:
> > >
> > > ld: kernel/bpf/bpf_lsm.o:(.rodata+0x0): undefined reference to `bpf_tracing_func_proto'
> > >
> > >
> > > Full randconfig file is attached.
> > >
> >
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: Tree for Mar 30 (bpf)
2020-03-30 18:05 ` KP Singh
@ 2020-03-30 18:15 ` Randy Dunlap
2020-03-30 18:49 ` KP Singh
1 sibling, 0 replies; 5+ messages in thread
From: Randy Dunlap @ 2020-03-30 18:15 UTC (permalink / raw)
To: KP Singh
Cc: Daniel Borkmann, Stephen Rothwell, Linux Next Mailing List,
Linux Kernel Mailing List, bpf, netdev
On 3/30/20 11:05 AM, KP Singh wrote:
> On 30-Mar 19:54, KP Singh wrote:
>
> So, it looks like bpf_tracing_func_proto is only defined when
> CONFIG_BPF_EVENTS is set:
>
> obj-$(CONFIG_BPF_EVENTS) += bpf_trace.o
>
> We have a few options:
>
> * Add a __weak symbol for bpf_tracing_func_proto which we have done in
> the past for similar issues. This however, does not make much sense,
> as CONFIG_BPF_LSM cannot really do much without its helpers.
> * Make CONFIG_BPF_LSM depend on CONFIG_BPF_EVENTS, this should solve
> it, but not for this particular Kconfig that was generated. Randy,
> I am assuming if we add the dependency, this particular Kconfig
> won't be generated.
Hi KP,
That sounds reasonable.
Thanks.
>
> I am assuming this patch now needs to be sent for "bpf" and not
> "bpf-next" as the merge window has opened?
>
> - KP
>
>> Thanks for adding me Daniel, taking a look.
>>
>> - KP
>>
>> On Mon, Mar 30, 2020 at 7:25 PM Daniel Borkmann <daniel@iogearbox.net> wrote:
>>>
>>> [Cc KP, ptal]
>>>
>>> On 3/30/20 7:15 PM, Randy Dunlap wrote:
>>>> On 3/30/20 2:43 AM, Stephen Rothwell wrote:
>>>>> Hi all,
>>>>>
>>>>> The merge window has opened, so please do not add any material for the
>>>>> next release into your linux-next included trees/branches until after
>>>>> the merge window closes.
>>>>>
>>>>> Changes since 20200327:
>>>>
>>>> (note: linux-next is based on linux 5.6-rc7)
>>>>
>>>>
>>>> on i386:
>>>>
>>>> ld: kernel/bpf/bpf_lsm.o:(.rodata+0x0): undefined reference to `bpf_tracing_func_proto'
>>>>
>>>>
>>>> Full randconfig file is attached.
--
~Randy
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: Tree for Mar 30 (bpf)
2020-03-30 18:05 ` KP Singh
2020-03-30 18:15 ` Randy Dunlap
@ 2020-03-30 18:49 ` KP Singh
1 sibling, 0 replies; 5+ messages in thread
From: KP Singh @ 2020-03-30 18:49 UTC (permalink / raw)
To: KP Singh
Cc: Daniel Borkmann, Randy Dunlap, Stephen Rothwell,
Linux Next Mailing List, Linux Kernel Mailing List, bpf, netdev
On 30-Mar 20:05, KP Singh wrote:
> On 30-Mar 19:54, KP Singh wrote:
>
> So, it looks like bpf_tracing_func_proto is only defined when
> CONFIG_BPF_EVENTS is set:
>
> obj-$(CONFIG_BPF_EVENTS) += bpf_trace.o
>
> We have a few options:
>
> * Add a __weak symbol for bpf_tracing_func_proto which we have done in
> the past for similar issues. This however, does not make much sense,
> as CONFIG_BPF_LSM cannot really do much without its helpers.
> * Make CONFIG_BPF_LSM depend on CONFIG_BPF_EVENTS, this should solve
> it, but not for this particular Kconfig that was generated. Randy,
> I am assuming if we add the dependency, this particular Kconfig
> won't be generated.
>
> I am assuming this patch now needs to be sent for "bpf" and not
> "bpf-next" as the merge window has opened?
I am wrong, I will send the patch targeted for "bpf-next" and they
will be applied after merge window closes (and the -next tree opens).
Apologies for the confusion.
- KP
>
> - KP
>
> > Thanks for adding me Daniel, taking a look.
> >
> > - KP
> >
> > On Mon, Mar 30, 2020 at 7:25 PM Daniel Borkmann <daniel@iogearbox.net> wrote:
> > >
> > > [Cc KP, ptal]
> > >
> > > On 3/30/20 7:15 PM, Randy Dunlap wrote:
> > > > On 3/30/20 2:43 AM, Stephen Rothwell wrote:
> > > >> Hi all,
> > > >>
> > > >> The merge window has opened, so please do not add any material for the
> > > >> next release into your linux-next included trees/branches until after
> > > >> the merge window closes.
> > > >>
> > > >> Changes since 20200327:
> > > >
> > > > (note: linux-next is based on linux 5.6-rc7)
> > > >
> > > >
> > > > on i386:
> > > >
> > > > ld: kernel/bpf/bpf_lsm.o:(.rodata+0x0): undefined reference to `bpf_tracing_func_proto'
> > > >
> > > >
> > > > Full randconfig file is attached.
> > > >
> > >
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-03-30 18:49 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200330204307.669bbb4d@canb.auug.org.au>
[not found] ` <86f7031a-57c6-5d50-2788-ae0e06a7c138@infradead.org>
2020-03-30 17:25 ` linux-next: Tree for Mar 30 (bpf) Daniel Borkmann
2020-03-30 17:54 ` KP Singh
2020-03-30 18:05 ` KP Singh
2020-03-30 18:15 ` Randy Dunlap
2020-03-30 18:49 ` KP Singh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).