From: David Miller <davem@davemloft.net>
To: will@kernel.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
bpf@vger.kernel.org, kernel-team@android.com, ast@kernel.org,
daniel@iogearbox.net, edumazet@google.com, jasowang@redhat.com
Subject: Re: [PATCH] tun: Don't put_page() for all negative return values from XDP program
Date: Mon, 06 Apr 2020 10:01:23 -0700 (PDT) [thread overview]
Message-ID: <20200406.100123.2069151116269746360.davem@davemloft.net> (raw)
In-Reply-To: <20200403151321.20166-1-will@kernel.org>
From: Will Deacon <will@kernel.org>
Date: Fri, 3 Apr 2020 16:13:21 +0100
> When an XDP program is installed, tun_build_skb() grabs a reference to
> the current page fragment page if the program returns XDP_REDIRECT or
> XDP_TX. However, since tun_xdp_act() passes through negative return
> values from the XDP program, it is possible to trigger the error path by
> mistake and accidentally drop a reference to the fragments page without
> taking one, leading to a spurious free. This is believed to be the cause
> of some KASAN use-after-free reports from syzbot [1], although without a
> reproducer it is not possible to confirm whether this patch fixes the
> problem.
>
> Ensure that we only drop a reference to the fragments page if the XDP
> transmit or redirect operations actually fail.
>
> [1] https://syzkaller.appspot.com/bug?id=e76a6af1be4acd727ff6bbca669833f98cbf5d95
>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Alexei Starovoitov <ast@kernel.org>
> Cc: Daniel Borkmann <daniel@iogearbox.net>
> CC: Eric Dumazet <edumazet@google.com>
> Acked-by: Jason Wang <jasowang@redhat.com>
> Fixes: 8ae1aff0b331 ("tuntap: split out XDP logic")
> Signed-off-by: Will Deacon <will@kernel.org>
Applied and queued up for -stable, thank you.
prev parent reply other threads:[~2020-04-06 17:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 15:13 [PATCH] tun: Don't put_page() for all negative return values from XDP program Will Deacon
2020-04-06 17:01 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200406.100123.2069151116269746360.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=edumazet@google.com \
--cc=jasowang@redhat.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).