From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6063DC433E0 for ; Wed, 20 May 2020 22:11:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2F54120823 for ; Wed, 20 May 2020 22:11:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="G0Si5nfh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728414AbgETWK7 (ORCPT ); Wed, 20 May 2020 18:10:59 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:60031 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728210AbgETWK7 (ORCPT ); Wed, 20 May 2020 18:10:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590012658; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=z1vIhurviEzP2nHp5BDqAvozGvnWo27CfFHlDxPi3JY=; b=G0Si5nfht9lYPgtZ1jJGuB9rJFLNl6FgBxhyMAc1AAFncp2pmPPKFuSv885xBBusWJk9rd pidI2JwM/cSJ6vMNA/LBKv2OaPMQFDY7noL2W2BOs14VcYz3FAbscLv+RHXgeNEpCWvyc9 jb35xXilwiCGh7D8KGMGjiSiScPaRqU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-132-aF9O-RrUPJOgoqyMTI5hDQ-1; Wed, 20 May 2020 18:10:54 -0400 X-MC-Unique: aF9O-RrUPJOgoqyMTI5hDQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8E7BB800053; Wed, 20 May 2020 22:10:51 +0000 (UTC) Received: from krava (unknown [10.40.193.10]) by smtp.corp.redhat.com (Postfix) with SMTP id E253160C05; Wed, 20 May 2020 22:10:45 +0000 (UTC) Date: Thu, 21 May 2020 00:10:44 +0200 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: Ian Rogers , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Namhyung Kim , Song Liu , Andrii Nakryiko , Kajol Jain , Andi Kleen , John Garry , Jin Yao , Kan Liang , Cong Wang , Kim Phillips , Paul Clarke , Srikar Dronamraju , LKML , Networking , bpf , linux-perf-users , Vince Weaver , Stephane Eranian Subject: Re: [PATCH 3/7] perf metricgroup: Delay events string creation Message-ID: <20200520221044.GQ157452@krava> References: <20200520072814.128267-1-irogers@google.com> <20200520072814.128267-4-irogers@google.com> <20200520131412.GK157452@krava> <20200520203409.GA26877@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200520203409.GA26877@kernel.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Wed, May 20, 2020 at 05:34:09PM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, May 20, 2020 at 11:22:22AM -0700, Ian Rogers escreveu: > > On Wed, May 20, 2020 at 6:14 AM Jiri Olsa wrote: > > > > break; > > > > } > > > > } > > > > + if (!ret) { > > > > > > could you please do instead: > > > > > > if (ret) > > > return ret; > > > > > > so the code below cuts down one indent level and you > > > don't need to split up the lines > > > > Done, broken out as a separate patch in v2: > > https://lore.kernel.org/lkml/20200520182011.32236-3-irogers@google.com/ > > Jiri, was this the only issue with this patchkit? I've merged already > the first one, that you acked. I'm still wondering if we can keep groups after the merge, it's in my other reply jirka