From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BAE0C433DF for ; Mon, 25 May 2020 22:19:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 24D7120776 for ; Mon, 25 May 2020 22:19:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590445158; bh=x65ra5HzllGpMWpGBDQlV6WYtu45OT9qLLEzkF7Sj4I=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=yll4LQIUmVNrmP1KqEmus1d5cc7BJ2BFwDXE7tgYQLsPphRVZeMfD5ZF4lt/mkfTl LdJ/DGbC23lazlpkutPmuQHScP1eEl1Jp2ezVQ13wSVS3OWhX6jRyfTGzPvA3rWUDr 66gAXaz8zhntW2UZJWopg1csDBQ5DNkc5XSOIbFU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388099AbgEYWTO (ORCPT ); Mon, 25 May 2020 18:19:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:58942 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725834AbgEYWTN (ORCPT ); Mon, 25 May 2020 18:19:13 -0400 Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 03D43206B6; Mon, 25 May 2020 22:19:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590445153; bh=x65ra5HzllGpMWpGBDQlV6WYtu45OT9qLLEzkF7Sj4I=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=NcJFtnwNx4e0s9ZwJL4cLO0xBzD7n5HdSdPtZCXXajTuoquh5l284befI43hQi6i/ t2tEJWOuysgTmZPxEfphxQz2b70faDivb9e2/2k2EgJrV9o+NW9QcuDi6vhWmGV/ws 6sb6xAz5aRmW/QGtmF4kQf3EkLYbja1bkLUuzuZE= Date: Mon, 25 May 2020 15:19:12 -0700 From: Andrew Morton To: Christoph Hellwig Cc: x86@kernel.org, Alexei Starovoitov , Daniel Borkmann , Masami Hiramatsu , Linus Torvalds , linux-parisc@vger.kernel.org, linux-um@lists.infradead.org, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: clean up and streamline probe_kernel_* and friends v4 Message-Id: <20200525151912.34b20b978617e2893e484fa3@linux-foundation.org> In-Reply-To: <20200521152301.2587579-1-hch@lst.de> References: <20200521152301.2587579-1-hch@lst.de> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Thu, 21 May 2020 17:22:38 +0200 Christoph Hellwig wrote: > this series start cleaning up the safe kernel and user memory probing > helpers in mm/maccess.c, and then allows architectures to implement > the kernel probing without overriding the address space limit and > temporarily allowing access to user memory. It then switches x86 > over to this new mechanism by reusing the unsafe_* uaccess logic. > > This version also switches to the saner copy_{from,to}_kernel_nofault > naming suggested by Linus. > > I kept the x86 helpers as-is without calling unsage_{get,put}_user as > that avoids a number of hard to trace casts, and it will still work > with the asm-goto based version easily. hm. Applying linux-next to this series generates a lot of rejects against powerpc: -rw-rw-r-- 1 akpm akpm 493 May 25 15:06 arch/powerpc/kernel/kgdb.c.rej -rw-rw-r-- 1 akpm akpm 6461 May 25 15:06 arch/powerpc/kernel/trace/ftrace.c.rej -rw-rw-r-- 1 akpm akpm 447 May 25 15:06 arch/powerpc/mm/fault.c.rej -rw-rw-r-- 1 akpm akpm 623 May 25 15:06 arch/powerpc/perf/core-book3s.c.rej -rw-rw-r-- 1 akpm akpm 1408 May 25 15:06 arch/riscv/kernel/patch.c.rej the arch/powerpc/kernel/trace/ftrace.c ones aren't very trivial. It's -rc7. Perhaps we should park all this until 5.8-rc1?