From: KP Singh <kpsingh@chromium.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: KP Singh <kpsingh@chromium.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
bpf@vger.kernel.org, linux-security-module@vger.kernel.org,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
James Morris <jmorris@namei.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Martin KaFai Lau <kafai@fb.com>,
Florent Revest <revest@chromium.org>
Subject: Re: [PATCH bpf-next 2/4] bpf: Implement bpf_local_storage for inodes
Date: Wed, 27 May 2020 14:38:40 +0200 [thread overview]
Message-ID: <20200527123840.GA12958@google.com> (raw)
In-Reply-To: <20200527050823.GA31860@infradead.org>
On 26-May 22:08, Christoph Hellwig wrote:
> On Tue, May 26, 2020 at 06:33:34PM +0200, KP Singh wrote:
> > From: KP Singh <kpsingh@google.com>
> >
> > Similar to bpf_local_storage for sockets, add local storage for inodes.
> > The life-cycle of storage is managed with the life-cycle of the inode.
> > i.e. the storage is destroyed along with the owning inode.
> >
> > Since, the intention is to use this in LSM programs, the destruction is
> > done after security_inode_free in __destroy_inode.
>
> NAK onbloating the inode structure. Please find an out of line way
> to store your information.
The other alternative is to use lbs_inode (security blobs) and we can
do this without adding fields to struct inode.
Here is a rough diff (only illustrative, won't apply cleanly) of the
changes needed to this patch:
https://gist.github.com/sinkap/1d213d17fb82a5e8ffdc3f320ec37d79
Once tracing has gets a whitelist based access to inode storage, I
guess it, too, can use bpf_local_storage for inodes if CONFIG_BPF_LSM
is enabled. Does this sound reasonable to the BPF folks?
- KP
next prev parent reply other threads:[~2020-05-27 12:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 16:33 [PATCH bpf-next 0/4] Generalizing bpf_local_storage KP Singh
2020-05-26 16:33 ` [PATCH bpf-next 1/4] bpf: Generalize bpf_sk_storage KP Singh
2020-05-27 22:06 ` kbuild test robot
2020-05-26 16:33 ` [PATCH bpf-next 2/4] bpf: Implement bpf_local_storage for inodes KP Singh
2020-05-27 0:49 ` Alexei Starovoitov
2020-05-27 2:11 ` KP Singh
2020-05-27 5:08 ` Christoph Hellwig
2020-05-27 12:38 ` KP Singh [this message]
2020-05-27 16:41 ` Casey Schaufler
2020-05-27 17:09 ` KP Singh
2020-06-02 21:35 ` kbuild test robot
2020-05-26 16:33 ` [PATCH bpf-next 3/4] bpf: Allow local storage to be used from LSM programs KP Singh
2020-05-26 16:33 ` [PATCH bpf-next 4/4] bpf: Add selftests for local_storage KP Singh
2020-06-01 20:29 ` Andrii Nakryiko
2020-06-16 15:54 ` KP Singh
2020-06-16 19:25 ` Andrii Nakryiko
2020-06-16 20:40 ` Yonghong Song
2020-06-17 19:19 ` Yonghong Song
2020-06-17 19:26 ` KP Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200527123840.GA12958@google.com \
--to=kpsingh@chromium.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=hch@infradead.org \
--cc=jmorris@namei.org \
--cc=kafai@fb.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=revest@chromium.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).