From: Alexei Starovoitov <alexei.starovoitov@gmail.com> To: davem@davemloft.net Cc: daniel@iogearbox.net, netdev@vger.kernel.org, bpf@vger.kernel.org, kernel-team@fb.com Subject: [PATCH v2 bpf-next 0/4] bpf: Introduce minimal support for sleepable progs Date: Thu, 28 May 2020 21:38:35 -0700 [thread overview] Message-ID: <20200529043839.15824-1-alexei.starovoitov@gmail.com> (raw) From: Alexei Starovoitov <ast@kernel.org> v1->v2: - split fmod_ret fix into separate patch - added blacklist v1: This patch set introduces the minimal viable support for sleepable bpf programs. In this patch only fentry/fexit/fmod_ret and lsm progs can be sleepable. Only array and pre-allocated hash and lru maps allowed. Here is 'perf report' difference of sleepable vs non-sleepable: 3.86% bench [k] __srcu_read_unlock 3.22% bench [k] __srcu_read_lock 0.92% bench [k] bpf_prog_740d4210cdcd99a3_bench_trigger_fentry_sleep 0.50% bench [k] bpf_trampoline_10297 0.26% bench [k] __bpf_prog_exit_sleepable 0.21% bench [k] __bpf_prog_enter_sleepable vs 0.88% bench [k] bpf_prog_740d4210cdcd99a3_bench_trigger_fentry 0.84% bench [k] bpf_trampoline_10297 0.13% bench [k] __bpf_prog_enter 0.12% bench [k] __bpf_prog_exit Clearly sleepable vs non-sleepable program invocation overhead is high, but it could be acceptable in certain cases until rcu_trace is available. bpf_copy_from_user(), bpf_msleep() will be coming in the future patches. Support for perf_event_array and bpf_perf_event_output() will follow as well. Alexei Starovoitov (4): bpf: Fix use-after-free in fmod_ret check bpf: Introduce sleepable BPF programs libbpf: support sleepable progs selftests/bpf: basic sleepable tests arch/x86/net/bpf_jit_comp.c | 36 +++++--- include/linux/bpf.h | 4 + include/uapi/linux/bpf.h | 8 ++ kernel/bpf/arraymap.c | 5 ++ kernel/bpf/hashtab.c | 19 +++-- kernel/bpf/syscall.c | 12 ++- kernel/bpf/trampoline.c | 33 +++++++- kernel/bpf/verifier.c | 84 ++++++++++++++++--- tools/include/uapi/linux/bpf.h | 8 ++ tools/lib/bpf/libbpf.c | 25 +++++- tools/testing/selftests/bpf/bench.c | 2 + .../selftests/bpf/benchs/bench_trigger.c | 17 ++++ tools/testing/selftests/bpf/progs/lsm.c | 9 +- .../selftests/bpf/progs/trigger_bench.c | 7 ++ 14 files changed, 232 insertions(+), 37 deletions(-) -- 2.23.0
next reply other threads:[~2020-05-29 4:38 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-29 4:38 Alexei Starovoitov [this message] 2020-05-29 4:38 ` [PATCH v2 bpf-next 1/4] bpf: Fix use-after-free in fmod_ret check Alexei Starovoitov 2020-05-29 4:38 ` [PATCH v2 bpf-next 2/4] bpf: Introduce sleepable BPF programs Alexei Starovoitov 2020-05-29 8:25 ` Andrii Nakryiko 2020-05-29 20:12 ` Alexei Starovoitov 2020-05-29 20:38 ` Andrii Nakryiko 2020-05-29 20:52 ` Alexei Starovoitov 2020-05-31 2:19 ` kbuild test robot 2020-05-31 4:33 ` kbuild test robot 2020-05-29 4:38 ` [PATCH v2 bpf-next 3/4] libbpf: support sleepable progs Alexei Starovoitov 2020-05-29 4:38 ` [PATCH v2 bpf-next 4/4] selftests/bpf: basic sleepable tests Alexei Starovoitov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200529043839.15824-1-alexei.starovoitov@gmail.com \ --to=alexei.starovoitov@gmail.com \ --cc=bpf@vger.kernel.org \ --cc=daniel@iogearbox.net \ --cc=davem@davemloft.net \ --cc=kernel-team@fb.com \ --cc=netdev@vger.kernel.org \ --subject='Re: [PATCH v2 bpf-next 0/4] bpf: Introduce minimal support for sleepable progs' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).