From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7D17C433DF for ; Fri, 29 May 2020 16:28:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8918B2075A for ; Fri, 29 May 2020 16:28:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="hDddTkwS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727013AbgE2Q2V (ORCPT ); Fri, 29 May 2020 12:28:21 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:35480 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725681AbgE2Q2V (ORCPT ); Fri, 29 May 2020 12:28:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590769700; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QOocdEe8JcHWozlDHA2H1VhP1cNSV3Qek6Z4dV8TZIg=; b=hDddTkwSlMs8BItdvKnFvB9QjzMLQtlbT0yRo79CWiUMENb0SGAN5WyKFodJ1k/yvp02/h ieu2DwFV1iawzwxYnCWxYwOAX0jLuSCc1joW1CiMH14sMOLOHkp0gl48DycDpFRMH1MvPA MBNT1qplSOIDn3JyvO4ZZzj0thiaWu8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-248-TrjcmuouNH6DG4JTYjvPbQ-1; Fri, 29 May 2020 12:28:11 -0400 X-MC-Unique: TrjcmuouNH6DG4JTYjvPbQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 308081855A1D; Fri, 29 May 2020 16:28:10 +0000 (UTC) Received: from carbon (unknown [10.40.208.9]) by smtp.corp.redhat.com (Postfix) with ESMTP id 393A27A8CC; Fri, 29 May 2020 16:28:04 +0000 (UTC) Date: Fri, 29 May 2020 18:28:03 +0200 From: Jesper Dangaard Brouer To: David Ahern Cc: bpf@vger.kernel.org, netdev@vger.kernel.org, Daniel Borkmann , Alexei Starovoitov , Andrii Nakryiko , brouer@redhat.com Subject: Re: [PATCH bpf-next RFC 1/3] bpf: move struct bpf_devmap_val out of UAPI Message-ID: <20200529182803.526832ed@carbon> In-Reply-To: References: <159076794319.1387573.8722376887638960093.stgit@firesoul> <159076798058.1387573.3077178618799401182.stgit@firesoul> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Fri, 29 May 2020 10:06:25 -0600 David Ahern wrote: > On 5/29/20 9:59 AM, Jesper Dangaard Brouer wrote: > > @@ -60,6 +60,15 @@ struct xdp_dev_bulk_queue { > > unsigned int count; > > }; > > > > +/* DEVMAP values */ > > +struct bpf_devmap_val { > > + __u32 ifindex; /* device index */ > > + union { > > + int fd; /* prog fd on map write */ > > + __u32 id; /* prog id on map read */ > > + } bpf_prog; > > +}; > > + > > I can pick up this name change for v4. Great - I will appreciate, as this will make my patchset compatible with yours :-) -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer