From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B172C433DF for ; Tue, 9 Jun 2020 15:37:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E56B9207C3 for ; Tue, 9 Jun 2020 15:37:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="UwBjD7ND" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730823AbgFIPhK (ORCPT ); Tue, 9 Jun 2020 11:37:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49060 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728944AbgFIPhJ (ORCPT ); Tue, 9 Jun 2020 11:37:09 -0400 Received: from mail-pl1-x642.google.com (mail-pl1-x642.google.com [IPv6:2607:f8b0:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68E44C05BD1E for ; Tue, 9 Jun 2020 08:37:09 -0700 (PDT) Received: by mail-pl1-x642.google.com with SMTP id d8so5004334plo.12 for ; Tue, 09 Jun 2020 08:37:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=vTmL3j2ChselJ7CiUsiWvZhWnoud3hxCqhIar2/2kJk=; b=UwBjD7NDk8XLgqFoD4wx2VoBEtV/8TYGp3T3KZF72ixc/J4gQoXq3NrOWQ+nMN8SN4 jFCfIczThOBK5LZDznABykMdxkj9H+ouW9TdQ9PngGV4Dz5C9ANuwIa3b5ce0y4K8V1H zxtPhIfzxeW2bjcoM2L/k6lbFiOlmpMfvBa/w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=vTmL3j2ChselJ7CiUsiWvZhWnoud3hxCqhIar2/2kJk=; b=FSvx+5hWLxea/X4YWMRsT2alYyIaEb/47WY/MwM0IkhWnNT2u3WzQ3a5IhfpOF5Fsi UyvzyKJfqj/NGPM6pyoeeXaWRGZrxMEmKoyLLQIovIpfl3+jpi0LMdj+Ocdcp3foXHnf Zm9Fxw4MuamxbDGYF2lNOnw6qOsrXaeW4CYmz08iFhqBZrACE6OVctKpKPXJYN/3LpLz ZRpAwGz0mDzFl3/bGDMYVOAglqmV07AxL0krp6ocZyDL9ySjYOEJMvKOPMvoHHiufnKQ iKO4lY/5EpQ7zIZIMIMus3It95ZeCZFURqHgW+j3AwqQPEcHOCeiZqzwCIM4EQ/DqcYF mVCQ== X-Gm-Message-State: AOAM530CMhFnmQMAulwwe+G81qUwifjBKbkmXtHLzyiJGooUupQzfVwu sDwfqq37Bb4+6i95uPH1QrA12w== X-Google-Smtp-Source: ABdhPJx4257lrdpLgEGz7FBr8GiLlur+c8zc+aBpEWyAeT9KGiB4Go1CWsj96UujyWTTsB++AMsmwA== X-Received: by 2002:a17:902:c3cb:: with SMTP id j11mr4027107plj.171.1591717028787; Tue, 09 Jun 2020 08:37:08 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id gt22sm3491498pjb.2.2020.06.09.08.37.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2020 08:37:07 -0700 (PDT) Date: Tue, 9 Jun 2020 08:37:06 -0700 From: Kees Cook To: Alexei Starovoitov Cc: Linus Torvalds , "Eric W. Biederman" , Tetsuo Handa , Andrew Morton , Alexei Starovoitov , David Miller , Al Viro , bpf , linux-fsdevel , Daniel Borkmann , Jakub Kicinski , Masahiro Yamada , Gary Lin , Bruno Meneguele Subject: Re: [RFC][PATCH] net/bpfilter: Remove this broken and apparently unmantained Message-ID: <202006090835.EF46A9E@keescook> References: <13fb3ab7-9ab1-b25f-52f2-40a6ca5655e1@i-love.sakura.ne.jp> <202006051903.C44988B@keescook> <875zc4c86z.fsf_-_@x220.int.ebiederm.org> <20200606201956.rvfanoqkevjcptfl@ast-mbp> <20200607014935.vhd3scr4qmawq7no@ast-mbp> <20200608162027.iyaqtnhrjtp3vos5@ast-mbp.dhcp.thefacebook.com> <202006081130.CE3AE614F@keescook> <20200609012636.5peovadjayzonqyv@ast-mbp.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200609012636.5peovadjayzonqyv@ast-mbp.dhcp.thefacebook.com> Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Mon, Jun 08, 2020 at 06:26:36PM -0700, Alexei Starovoitov wrote: > On Mon, Jun 08, 2020 at 11:35:12AM -0700, Kees Cook wrote: > > On Mon, Jun 08, 2020 at 09:20:27AM -0700, Alexei Starovoitov wrote: > > > Take android for example. It can certify vmlinux, but not boot fs image. > > > > Huh? Yes it does, and for a while now. It uses Android uses dm-verity[1] > > and fs-verity[2]. > > I didn't mean 'certified' like untrusted or insecure. > I meant the vendor kernel has to satisfy and pass SDK checks to be > certified as an android phone whereas vendor can put more or less whatever > they like on the fs. Their own bloatware, etc. > So for android to make sure something is part of the whole sw package > it has to come from the kernel and its modules. > Well, at least that's what I've been told. > Similarly kernel upgrade doesn't necessary include boot image upgrade. > In that sense 'elf in vmlinux' addresses packaging issue. Well, it's much more complex than that, but I see what you mean: it's an ELF tied to a specific kernel, like modules are. But Android's control over modules cover such an ELF as well, if it were separate from the kernel. Regardless, we're off in the weeds. :) -- Kees Cook