From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D364DC433E0 for ; Tue, 9 Jun 2020 12:08:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9F2A0206A4 for ; Tue, 9 Jun 2020 12:08:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aADFy46q" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728108AbgFIMIg (ORCPT ); Tue, 9 Jun 2020 08:08:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726395AbgFIMIf (ORCPT ); Tue, 9 Jun 2020 08:08:35 -0400 Received: from mail-qk1-x744.google.com (mail-qk1-x744.google.com [IPv6:2607:f8b0:4864:20::744]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82668C05BD1E; Tue, 9 Jun 2020 05:08:34 -0700 (PDT) Received: by mail-qk1-x744.google.com with SMTP id v79so20425377qkb.10; Tue, 09 Jun 2020 05:08:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id; bh=vRHbPOXtPbJdANLvmSwZ4cS7X1/NwFEoLTvptBebMJM=; b=aADFy46qw/Vq/MMCuSbBmbsKc0B9TH20nslbYSnWZNTVPRWLM4Eiu3okUJjB+jyDKP 2vQzs7enHj/b8o2w3J+JzTGAJPdJ8WeEZYsfgNlzUL4h//jWglPvInFIKrfyf/9pjggP 92SNWvRKlOQdNK2XiWmxqvUEuoR6VF0xR/YvgadYyuGbB6OEsPE9ZH5CaGJRYTE+S71n ZO0to0h5nvo7nHqgv0Xb5EDS5xACoa2V4zsRXNc0N/eJNjRtFAhXHuKMtpRpqwhy64re FoCCCSREHz0D7053m/SJ6t7asElKY97FrMaxLt85/87yvS/ZQjgp8FwATgT/CNbg2mvO hiAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=vRHbPOXtPbJdANLvmSwZ4cS7X1/NwFEoLTvptBebMJM=; b=aWV/18v53aZLyloCYaGfM8MuljcgxqsbkXAR+s/X9rjiy8CKTrXVAMTxsa6/qvUf4L rZh0FvzzZ4Rq4OOzISzylvQHSdUgbx/ZC1jR3YCDlvKNKWdTACUhJclbz57nFvwyihgr K0KZai5QMXRVKpy8WgoffYZs5FsxhSVwbWTtcxaW6uoBlAb2X8KpcinfatIXtYvi5S50 TFFgbFS+V669Tb1HxXHAyh/JyFXtnHzuohOSfbqOmFofawv245yFzsXBTwpbZxeb0Ke6 5QWdvqsf++zWAcEOtxLT7K9FtLbBpo07kfqTRYPEME5Dnr6Woq0IRf9Ofn/yiaOsSGQY 1r3A== X-Gm-Message-State: AOAM5301/TVXSeTr8X2GOkjuhfbzGT6Pdh9bDx084VJWqQL+YiS3FhwQ bQQQCm7yfFZrbaVlOl1b4tI= X-Google-Smtp-Source: ABdhPJxSzISY4ib4u1DtG9gJaxQkMpZ71pq7o6ENgO3YLF6GKZ8qbVpkR7mK0rYln/VJQxzA8xkGTw== X-Received: by 2002:a37:9c91:: with SMTP id f139mr27953469qke.371.1591704513335; Tue, 09 Jun 2020 05:08:33 -0700 (PDT) Received: from linux.home ([2604:2000:1344:41d:29ac:7979:1e2e:c67b]) by smtp.googlemail.com with ESMTPSA id d56sm10732690qtb.54.2020.06.09.05.08.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2020 05:08:32 -0700 (PDT) From: Gaurav Singh To: gaurav1086@gmail.com, Alexei Starovoitov , Daniel Borkmann , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , John Fastabend , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko , KP Singh , netdev@vger.kernel.org (open list:XDP (eXpress Data Path)), bpf@vger.kernel.org (open list:XDP (eXpress Data Path)), linux-kernel@vger.kernel.org (open list) Subject: [PATCH] bpf: alloc_record_per_cpu Add null check after malloc Date: Tue, 9 Jun 2020 08:08:03 -0400 Message-Id: <20200609120804.10569-1-gaurav1086@gmail.com> X-Mailer: git-send-email 2.17.1 Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org The memset call is made right after malloc call. To fix this, add the null check right after malloc and then do memset. Signed-off-by: Gaurav Singh --- samples/bpf/xdp_rxq_info_user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/samples/bpf/xdp_rxq_info_user.c b/samples/bpf/xdp_rxq_info_user.c index 4fe47502ebed..490b07b7df78 100644 --- a/samples/bpf/xdp_rxq_info_user.c +++ b/samples/bpf/xdp_rxq_info_user.c @@ -202,11 +202,11 @@ static struct datarec *alloc_record_per_cpu(void) size = sizeof(struct datarec) * nr_cpus; array = malloc(size); - memset(array, 0, size); if (!array) { fprintf(stderr, "Mem alloc error (nr_cpus:%u)\n", nr_cpus); exit(EXIT_FAIL_MEM); } + memset(array, 0, size); return array; } -- 2.17.1