bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: lirongqing@baidu.com
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH] xdp: fix xsk_generic_xmit errno
Date: Thu, 11 Jun 2020 12:44:11 -0700 (PDT)	[thread overview]
Message-ID: <20200611.124411.1798325783779516035.davem@davemloft.net> (raw)
In-Reply-To: <1591852266-24017-1-git-send-email-lirongqing@baidu.com>

From: Li RongQing <lirongqing@baidu.com>
Date: Thu, 11 Jun 2020 13:11:06 +0800

> @@ -353,7 +353,6 @@ static int xsk_generic_xmit(struct sock *sk)
>  		len = desc.len;
>  		skb = sock_alloc_send_skb(sk, len, 1, &err);
>  		if (unlikely(!skb)) {
> -			err = -EAGAIN;
>  			goto out;
>  		}

Since the result is a single-statement basic block you must remove the
curly braces.

      parent reply	other threads:[~2020-06-11 19:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-11  5:11 [PATCH] xdp: fix xsk_generic_xmit errno Li RongQing
2020-06-11  8:18 ` Björn Töpel
2020-06-11 14:24   ` Daniel Borkmann
2020-06-11 19:44 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200611.124411.1798325783779516035.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=bpf@vger.kernel.org \
    --cc=lirongqing@baidu.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).