From: Jiri Olsa <jolsa@redhat.com>
To: Ilya Leoshkevich <iii@linux.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
netdev@vger.kernel.org, bpf@vger.kernel.org,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>, Andrii Nakryiko <andriin@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@chromium.org>,
Frantisek Hrbata <fhrbata@redhat.com>,
Yauheni Kaliuta <yauheni.kaliuta@redhat.com>
Subject: [RFC] .BTF section data alignment issue on s390
Date: Thu, 11 Jun 2020 22:50:40 +0200 [thread overview]
Message-ID: <20200611205040.GA1853644@krava> (raw)
hi,
we're hitting a problem on s390 with BTF data alignment.
When running simple test, we're getting this message from
verifier and console:
bpf_common.c:91: BROK: Failed verification: in-kernel BTF is malformed
[ 41.545572] BPF:Total section length too long
AFAICS it happens when .BTF section data size is not an even number ;-)
DISCLAIMER I'm quite ignorant of s390x arch details, so most likely I'm
totally wrong and perhaps missing something important and there's simple
explanation.. but here's what got me here:
... so BTF data is placed in .BTF section via linker script:
.BTF : AT(ADDR(.BTF) - LOAD_OFFSET) { \
__start_BTF = .; \
*(.BTF) \
__stop_BTF = .; \
}
and the .BTF data size in btf_parse_vmlinux is computed as:
btf->data_size = __stop_BTF - __start_BTF;
this computation is compiled as:
00000000002aeb20 <btf_parse_vmlinux>:
...
2aeb8a: larl %r1,cda3ac <__start_BTF+0x2084a8> # loads r1 with end
2aeb90: larl %r2,ad1f04 <__start_BTF> # loads r2 with start
2aeb96: sgr %r1,%r2 # substract r1 - r2
having following values for start/stop_BTF symbols:
# nm ./vmlinux | grep __start_BTF
0000000000ad1f04 R __start_BTF
# nm ./vmlinux | grep __stop_BTF
0000000000cda3ad R __stop_BTF
-> the BTF data size is 0x2084a9
but as you can see the instruction that loads the 'end' symbol:
larl %r1,cda3ac <__start_BTF+0x2084a8>
is loading '__start_BTF + 0x2084a8', which is '__stop_BTF - 1'
From spec it seems that larl instruction's argument must be even
number ([1] page 7-214):
2. For LOAD RELATIVE LONG, the second oper-and must be aligned
on an integral boundary cor-responding to the operand’s size.
I also found an older bug complaining about this issue [2]:
...
larl instruction can only load even values - instructions on s390 are 2-byte
aligned and the instruction encodes offset to the target in 2-byte units.
...
The GNU BFD linker for s390 doesn't bother to check if relocations fit or are
properly aligned.
...
I tried to fix that aligning the end to even number, but then
btf_check_sec_info logic needs to be adjusted as well, and
probably other places as well.. so I decided to share this
first.. because it all seems wrong ;-)
thoughts? thanks,
jirka
[1] http://publibfi.boulder.ibm.com/epubs/pdf/dz9zr008.pdf
[2] https://sourceware.org/bugzilla/show_bug.cgi?id=18960
next reply other threads:[~2020-06-11 20:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 20:50 Jiri Olsa [this message]
2020-06-11 22:46 ` [RFC] .BTF section data alignment issue on s390 Ilya Leoshkevich
2020-06-12 7:56 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200611205040.GA1853644@krava \
--to=jolsa@redhat.com \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=fhrbata@redhat.com \
--cc=gor@linux.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=iii@linux.ibm.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@chromium.org \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=yauheni.kaliuta@redhat.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).