bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yonghong Song <yhs@fb.com>
To: <bpf@vger.kernel.org>
Cc: Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>, <kernel-team@fb.com>,
	Martin KaFai Lau <kafai@fb.com>
Subject: [PATCH bpf-next 03/13] bpf: support 'X' in bpf_seq_printf() helper
Date: Wed, 17 Jun 2020 14:15:39 -0700	[thread overview]
Message-ID: <20200617211539.1855882-1-yhs@fb.com> (raw)
In-Reply-To: <20200617211536.1854348-1-yhs@fb.com>

'X' tells kernel to print hex with upper case letters.
/proc/net/tcp{4,6} seq_file show() used this, and
supports it in bpf_seq_printf() helper too.

Signed-off-by: Yonghong Song <yhs@fb.com>
---
 kernel/trace/bpf_trace.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/kernel/trace/bpf_trace.c b/kernel/trace/bpf_trace.c
index e729c9e587a0..dbee30e2ad91 100644
--- a/kernel/trace/bpf_trace.c
+++ b/kernel/trace/bpf_trace.c
@@ -681,7 +681,8 @@ BPF_CALL_5(bpf_seq_printf, struct seq_file *, m, char *, fmt, u32, fmt_size,
 		}
 
 		if (fmt[i] != 'i' && fmt[i] != 'd' &&
-		    fmt[i] != 'u' && fmt[i] != 'x') {
+		    fmt[i] != 'u' && fmt[i] != 'x' &&
+		    fmt[i] != 'X') {
 			err = -EINVAL;
 			goto out;
 		}
-- 
2.24.1


  parent reply	other threads:[~2020-06-17 21:16 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-17 21:15 [PATCH bpf-next 00/13] implement bpf iterator for tcp and udp sockets Yonghong Song
2020-06-17 21:15 ` [PATCH bpf-next 01/13] bpf: add bpf_seq_afinfo in tcp_iter_state Yonghong Song
2020-06-18 18:09   ` Martin KaFai Lau
2020-06-17 21:15 ` [PATCH bpf-next 02/13] net: bpf: implement bpf iterator for tcp Yonghong Song
2020-06-18 18:52   ` Martin KaFai Lau
2020-06-17 21:15 ` Yonghong Song [this message]
2020-06-18 18:55   ` [PATCH bpf-next 03/13] bpf: support 'X' in bpf_seq_printf() helper Martin KaFai Lau
2020-06-17 21:15 ` [PATCH bpf-next 04/13] bpf: allow tracing programs to use bpf_jiffies64() helper Yonghong Song
2020-06-18 19:00   ` Martin KaFai Lau
2020-06-17 21:15 ` [PATCH bpf-next 05/13] bpf: add bpf_skc_to_tcp6_sock() helper Yonghong Song
2020-06-18 20:54   ` Martin KaFai Lau
2020-06-18 23:31     ` Yonghong Song
2020-06-17 21:15 ` [PATCH bpf-next 06/13] bpf: add bpf_skc_to_{tcp,tcp_timewait,tcp_request}_sock() helpers Yonghong Song
2020-06-17 21:15 ` [PATCH bpf-next 07/13] bpf: add bpf_seq_afinfo in udp_iter_state Yonghong Song
2020-06-17 21:15 ` [PATCH bpf-next 08/13] net: bpf: implement bpf iterator for udp Yonghong Song
2020-06-17 21:15 ` [PATCH bpf-next 09/13] bpf: add bpf_skc_to_udp6_sock() helper Yonghong Song
2020-06-17 21:15 ` [PATCH bpf-next 10/13] bpf/selftests: move newer bpf_iter_* type redefining to a new header file Yonghong Song
2020-06-17 22:47   ` Andrii Nakryiko
2020-06-17 21:15 ` [PATCH bpf-next 11/13] tools/bpf: selftests: implement sample tcp/tcp6 bpf_iter programs Yonghong Song
2020-06-17 22:51   ` Andrii Nakryiko
     [not found]     ` <ab5a131f-93c7-802b-49be-dd72085d8e56@fb.com>
2020-06-18  6:24       ` Andrii Nakryiko
2020-06-17 21:15 ` [PATCH bpf-next 12/13] tools/bpf: add udp4/udp6 bpf iterator Yonghong Song
2020-06-17 21:15 ` [PATCH bpf-next 13/13] bpf/selftests: add tcp/udp iterator programs to selftests Yonghong Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200617211539.1855882-1-yhs@fb.com \
    --to=yhs@fb.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=kafai@fb.com \
    --cc=kernel-team@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).