From: Andrii Nakryiko <andriin@fb.com>
To: <bpf@vger.kernel.org>, <netdev@vger.kernel.org>, <ast@fb.com>,
<daniel@iogearbox.net>
Cc: <andrii.nakryiko@gmail.com>, <kernel-team@fb.com>,
Andrii Nakryiko <andriin@fb.com>,
Anton Protopopov <a.s.protopopov@gmail.com>
Subject: [PATCH bpf-next 0/3] Strip away modifiers from BPF skeleton global variables
Date: Tue, 30 Jun 2020 23:45:22 -0700 [thread overview]
Message-ID: <20200701064527.3158178-1-andriin@fb.com> (raw)
Fix bpftool logic of stripping away const/volatile modifiers for all global
variables during BPF skeleton generation. See patch #1 for details on when
existing logic breaks and why it's important. Support special .strip_mods=true
mode in btf_dump. Add selftests validating that everything works as expected.
Recent example of when this has caused problems can be found in [0].
[0] https://github.com/iovisor/bcc/pull/2994#issuecomment-650588533
Cc: Anton Protopopov <a.s.protopopov@gmail.com>
Andrii Nakryiko (3):
libbpf: support stripping modifiers for btf_dump
selftests/bpf: add selftest validating btf_dump's mod-stripping output
tools/bpftool: strip away modifiers from global variables
tools/bpf/bpftool/gen.c | 13 ++---
tools/lib/bpf/btf.h | 6 +++
tools/lib/bpf/btf_dump.c | 18 +++++--
.../selftests/bpf/prog_tests/btf_dump.c | 5 +-
.../selftests/bpf/prog_tests/skeleton.c | 6 +--
.../bpf/progs/btf_dump_test_case_strip_mods.c | 50 +++++++++++++++++++
.../selftests/bpf/progs/test_skeleton.c | 6 ++-
7 files changed, 84 insertions(+), 20 deletions(-)
create mode 100644 tools/testing/selftests/bpf/progs/btf_dump_test_case_strip_mods.c
--
2.24.1
next reply other threads:[~2020-07-01 6:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 6:45 Andrii Nakryiko [this message]
2020-07-01 6:45 ` [PATCH bpf-next 1/3] libbpf: support stripping modifiers for btf_dump Andrii Nakryiko
2020-07-01 6:45 ` [PATCH bpf-next 2/3] selftests/bpf: add selftest testin btf_dump's mod-stripping output Andrii Nakryiko
2020-07-01 6:47 ` Andrii Nakryiko
2020-07-01 6:45 ` [PATCH bpf-next 2/3] selftests/bpf: add selftest validating " Andrii Nakryiko
2020-07-01 6:45 ` [PATCH bpf-next 3/3] tools/bpftool: strip away modifiers from global variables Andrii Nakryiko
2020-07-01 15:01 ` [PATCH bpf-next 0/3] Strip away modifiers from BPF skeleton " Alexei Starovoitov
2020-07-01 16:08 ` Andrii Nakryiko
2020-07-01 16:36 ` Alexei Starovoitov
2020-07-01 18:15 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200701064527.3158178-1-andriin@fb.com \
--to=andriin@fb.com \
--cc=a.s.protopopov@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=ast@fb.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).