From: Ian Rogers <irogers@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>, Andrii Nakryiko <andriin@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@chromium.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Andi Kleen <ak@linux.intel.com>,
Athira Rajeev <atrajeev@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
bpf@vger.kernel.org
Cc: Stephane Eranian <eranian@google.com>, Ian Rogers <irogers@google.com>
Subject: [PATCH v2 3/5] perf test: Ensure sample_period is set libpfm4 events
Date: Tue, 28 Jul 2020 01:57:32 -0700 [thread overview]
Message-ID: <20200728085734.609930-4-irogers@google.com> (raw)
In-Reply-To: <20200728085734.609930-1-irogers@google.com>
Test that a command line option doesn't override the period set on a
libpfm4 event.
Without libpfm4 test passes as unsupported.
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/tests/attr/README | 1 +
tools/perf/tests/attr/test-record-pfm-period | 9 +++++++++
2 files changed, 10 insertions(+)
create mode 100644 tools/perf/tests/attr/test-record-pfm-period
diff --git a/tools/perf/tests/attr/README b/tools/perf/tests/attr/README
index 430024f618f1..6cd408108595 100644
--- a/tools/perf/tests/attr/README
+++ b/tools/perf/tests/attr/README
@@ -53,6 +53,7 @@ Following tests are defined (with perf commands):
perf record -i kill (test-record-no-inherit)
perf record -n kill (test-record-no-samples)
perf record -c 100 -P kill (test-record-period)
+ perf record -c 1 --pfm-events=cycles:period=2 (test-record-pfm-period)
perf record -R kill (test-record-raw)
perf stat -e cycles kill (test-stat-basic)
perf stat kill (test-stat-default)
diff --git a/tools/perf/tests/attr/test-record-pfm-period b/tools/perf/tests/attr/test-record-pfm-period
new file mode 100644
index 000000000000..368f5b814094
--- /dev/null
+++ b/tools/perf/tests/attr/test-record-pfm-period
@@ -0,0 +1,9 @@
+[config]
+command = record
+args = --no-bpf-event -c 10000 --pfm-events=cycles:period=77777 kill >/dev/null 2>&1
+ret = 1
+
+[event:base-record]
+sample_period=77777
+sample_type=7
+freq=0
--
2.28.0.163.g6104cc2f0b6-goog
next prev parent reply other threads:[~2020-07-28 8:58 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 8:57 [PATCH v2 0/5] Fixes for setting event freq/periods Ian Rogers
2020-07-28 8:57 ` [PATCH v2 1/5] perf record: Set PERF_RECORD_PERIOD if attr->freq is set Ian Rogers
2020-07-28 15:43 ` Jiri Olsa
2020-07-28 16:03 ` Arnaldo Carvalho de Melo
2020-07-29 15:11 ` Athira Rajeev
2020-07-29 18:52 ` Arnaldo Carvalho de Melo
2020-07-29 21:43 ` Ian Rogers
2020-09-04 5:39 ` Ian Rogers
2020-07-28 8:57 ` [PATCH v2 2/5] perf record: Prevent override of attr->sample_period for libpfm4 events Ian Rogers
2020-07-28 15:59 ` Jiri Olsa
2020-07-28 16:09 ` Jiri Olsa
2020-07-29 23:24 ` Ian Rogers
2020-09-04 5:41 ` Ian Rogers
2020-09-04 16:03 ` Jiri Olsa
2020-09-04 16:22 ` Ian Rogers
2020-09-04 18:48 ` Arnaldo Carvalho de Melo
2020-09-04 18:50 ` Arnaldo Carvalho de Melo
2020-09-04 18:51 ` Arnaldo Carvalho de Melo
2020-09-11 22:34 ` Ian Rogers
2020-09-12 3:02 ` Ian Rogers
2020-07-29 18:54 ` Arnaldo Carvalho de Melo
2020-07-28 8:57 ` Ian Rogers [this message]
2020-07-28 12:45 ` [PATCH v2 3/5] perf test: Ensure sample_period is set " Arnaldo Carvalho de Melo
2020-07-28 8:57 ` [PATCH v2 4/5] perf record: Don't clear event's period if set by a term Ian Rogers
2020-07-29 18:58 ` Arnaldo Carvalho de Melo
2020-08-04 10:08 ` Adrian Hunter
2020-08-04 13:33 ` Ian Rogers
2020-08-04 14:48 ` Adrian Hunter
2020-08-04 15:50 ` Ian Rogers
2020-09-04 5:43 ` Ian Rogers
2020-09-07 6:36 ` Adrian Hunter
2020-07-28 8:57 ` [PATCH v2 5/5] perf test: Leader sampling shouldn't clear sample period Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200728085734.609930-4-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eranian@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@redhat.com \
--cc=kafai@fb.com \
--cc=kpsingh@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).