From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, davem@davemloft.net,
ast@kernel.org, daniel@iogearbox.net,
lorenzo.bianconi@redhat.com, echaudro@redhat.com,
sameehj@amazon.com, kuba@kernel.org, brouer@redhat.com
Subject: Re: [RFC net-next 00/22] Introduce mb bit in xdp_buff/xdp_frame
Date: Tue, 28 Jul 2020 16:48:52 +0200 [thread overview]
Message-ID: <20200728164852.76305a12@carbon> (raw)
In-Reply-To: <cover.1595503780.git.lorenzo@kernel.org>
On Thu, 23 Jul 2020 13:42:12 +0200
Lorenzo Bianconi <lorenzo@kernel.org> wrote:
> Introduce multi-buffer bit (mb) in xdp_frame/xdp_buffer to specify
> if shared_info area has been properly initialized for non-linear
> xdp buffers.
> Initialize mb to 0 for all xdp drivers
It is nice to see that we have some many XDP drivers, but 20 separate
patches for drivers is a bit much. Perhaps we can do all the drivers
in one patch? What do others think?
> Lorenzo Bianconi (22):
> xdp: introduce mb in xdp_buff/xdp_frame
> xdp: initialize xdp_buff mb bit to 0 in netif_receive_generic_xdp
> net: virtio_net: initialize mb bit of xdp_buff to 0
> net: xen-netfront: initialize mb bit of xdp_buff to 0
> net: veth: initialize mb bit of xdp_buff to 0
> net: hv_netvsc: initialize mb bit of xdp_buff to 0
> net: bnxt: initialize mb bit in xdp_buff to 0
> net: dpaa2: initialize mb bit in xdp_buff to 0
> net: ti: initialize mb bit in xdp_buff to 0
> net: nfp: initialize mb bit in xdp_buff to 0
> net: mvpp2: initialize mb bit in xdp_buff to 0
> net: sfc: initialize mb bit in xdp_buff to 0
> net: qede: initialize mb bit in xdp_buff to 0
> net: amazon: ena: initialize mb bit in xdp_buff to 0
> net: cavium: thunder: initialize mb bit in xdp_buff to 0
> net: socionext: initialize mb bit in xdp_buff to 0
> net: tun: initialize mb bit in xdp_buff to 0
> net: ixgbe: initialize mb bit in xdp_buff to 0
> net: ice: initialize mb bit in xdp_buff to 0
> net: i40e: initialize mb bit in xdp_buff to 0
> net: mlx5: initialize mb bit in xdp_buff to 0
> net: mlx4: initialize mb bit in xdp_buff to 0
>
> drivers/net/ethernet/amazon/ena/ena_netdev.c | 1 +
> drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c | 1 +
> drivers/net/ethernet/cavium/thunder/nicvf_main.c | 1 +
> drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 1 +
> drivers/net/ethernet/intel/i40e/i40e_txrx.c | 1 +
> drivers/net/ethernet/intel/ice/ice_txrx.c | 1 +
> drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 1 +
> drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 1 +
> drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 1 +
I see that mvneta is missing, but maybe it is doing another kind of
init of struct xdp_buff?
> drivers/net/ethernet/mellanox/mlx4/en_rx.c | 1 +
> drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 1 +
> drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 1 +
> drivers/net/ethernet/qlogic/qede/qede_fp.c | 1 +
> drivers/net/ethernet/sfc/rx.c | 1 +
> drivers/net/ethernet/socionext/netsec.c | 1 +
> drivers/net/ethernet/ti/cpsw.c | 1 +
> drivers/net/ethernet/ti/cpsw_new.c | 1 +
> drivers/net/hyperv/netvsc_bpf.c | 1 +
> drivers/net/tun.c | 2 ++
> drivers/net/veth.c | 1 +
> drivers/net/virtio_net.c | 2 ++
> drivers/net/xen-netfront.c | 1 +
> include/net/xdp.h | 8 ++++++--
> net/core/dev.c | 1 +
> 24 files changed, 31 insertions(+), 2 deletions(-)
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2020-07-28 14:49 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-23 11:42 [RFC net-next 00/22] Introduce mb bit in xdp_buff/xdp_frame Lorenzo Bianconi
2020-07-23 11:42 ` [RFC net-next 01/22] xdp: introduce mb " Lorenzo Bianconi
2020-07-23 13:51 ` Jubran, Samih
2020-07-23 11:42 ` [RFC net-next 02/22] xdp: initialize xdp_buff mb bit to 0 in netif_receive_generic_xdp Lorenzo Bianconi
2020-07-23 11:42 ` [RFC net-next 03/22] net: virtio_net: initialize mb bit of xdp_buff to 0 Lorenzo Bianconi
2020-07-23 11:42 ` [RFC net-next 04/22] net: xen-netfront: " Lorenzo Bianconi
2020-07-23 11:42 ` [RFC net-next 05/22] net: veth: " Lorenzo Bianconi
2020-07-23 11:42 ` [RFC net-next 06/22] net: hv_netvsc: " Lorenzo Bianconi
2020-07-23 11:42 ` [RFC net-next 07/22] net: bnxt: initialize mb bit in " Lorenzo Bianconi
2020-07-23 11:42 ` [RFC net-next 08/22] net: dpaa2: " Lorenzo Bianconi
2020-07-23 11:42 ` [RFC net-next 09/22] net: ti: " Lorenzo Bianconi
2020-07-23 11:42 ` [RFC net-next 10/22] net: nfp: " Lorenzo Bianconi
2020-07-23 11:42 ` [RFC net-next 11/22] net: mvpp2: " Lorenzo Bianconi
2020-07-23 11:42 ` [RFC net-next 12/22] net: sfc: " Lorenzo Bianconi
2020-07-23 11:42 ` [RFC net-next 13/22] net: qede: " Lorenzo Bianconi
2020-07-23 11:42 ` [RFC net-next 14/22] net: amazon: ena: " Lorenzo Bianconi
2020-07-23 11:42 ` [RFC net-next 15/22] net: cavium: thunder: " Lorenzo Bianconi
2020-07-23 11:42 ` [RFC net-next 16/22] net: socionext: " Lorenzo Bianconi
2020-07-23 11:42 ` [RFC net-next 17/22] net: tun: " Lorenzo Bianconi
2020-07-23 11:42 ` [RFC net-next 18/22] net: ixgbe: " Lorenzo Bianconi
2020-07-23 11:42 ` [RFC net-next 19/22] net: ice: " Lorenzo Bianconi
2020-07-23 11:42 ` [RFC net-next 20/22] net: i40e: " Lorenzo Bianconi
2020-07-23 11:42 ` [RFC net-next 21/22] net: mlx5: " Lorenzo Bianconi
2020-07-23 11:42 ` [RFC net-next 22/22] net: mlx4: " Lorenzo Bianconi
2020-07-28 14:48 ` Jesper Dangaard Brouer [this message]
2020-07-28 15:10 ` [RFC net-next 00/22] Introduce mb bit in xdp_buff/xdp_frame Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200728164852.76305a12@carbon \
--to=brouer@redhat.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=echaudro@redhat.com \
--cc=kuba@kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=lorenzo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sameehj@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).