From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88F33C433DF for ; Wed, 29 Jul 2020 23:05:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 65B8D2067D for ; Wed, 29 Jul 2020 23:05:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=fb.com header.i=@fb.com header.b="lA3URE0W" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727982AbgG2XF1 (ORCPT ); Wed, 29 Jul 2020 19:05:27 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:57564 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727115AbgG2XF1 (ORCPT ); Wed, 29 Jul 2020 19:05:27 -0400 Received: from pps.filterd (m0044012.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 06TN2FLk027451 for ; Wed, 29 Jul 2020 16:05:27 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=from : to : cc : subject : date : message-id : mime-version : content-type : content-transfer-encoding; s=facebook; bh=/hhCF6MZJuvinSbI9wmwXOWE2F//8gxgoNrpXt19vKk=; b=lA3URE0WUwTCDDScxSMzfq/oQXlHRMqoSwJmFXq8XRYDC5tRdvfTgrMPeJuKeJT+362i TVjlrWBk5rJxWNpHPPyPGtGJBsW6ad77m3XpYq2dYKIhIdH9K+BL4fR8HgUX7t+aanSc wK0n0Ft2DYpogaiXWQ22uXy+KSePeUOt1sY= Received: from mail.thefacebook.com ([163.114.132.120]) by mx0a-00082601.pphosted.com with ESMTP id 32jk9d8css-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 29 Jul 2020 16:05:26 -0700 Received: from intmgw002.03.ash8.facebook.com (2620:10d:c085:208::f) by mail.thefacebook.com (2620:10d:c085:21d::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Wed, 29 Jul 2020 16:05:26 -0700 Received: by devbig012.ftw2.facebook.com (Postfix, from userid 137359) id 731822EC4E37; Wed, 29 Jul 2020 16:05:23 -0700 (PDT) Smtp-Origin-Hostprefix: devbig From: Andrii Nakryiko Smtp-Origin-Hostname: devbig012.ftw2.facebook.com To: , , , CC: , , Andrii Nakryiko , =?UTF-8?q?Toke=20H=C3=B8iland-J=C3=B8rgensen?= Smtp-Origin-Cluster: ftw2c04 Subject: [PATCH bpf-next 0/5] BPF link force-detach support Date: Wed, 29 Jul 2020 16:05:15 -0700 Message-ID: <20200729230520.693207-1-andriin@fb.com> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687 definitions=2020-07-29_17:2020-07-29,2020-07-29 signatures=0 X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 lowpriorityscore=0 clxscore=1015 impostorscore=0 malwarescore=0 mlxscore=0 mlxlogscore=693 suspectscore=8 adultscore=0 priorityscore=1501 phishscore=0 spamscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2007290156 X-FB-Internal: deliver Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org This patch set adds new BPF link operation, LINK_DETACH, allowing process= es with BPF link FD to force-detach it from respective BPF hook, similarly h= ow BPF link is auto-detached when such BPF hook (e.g., cgroup, net_device, n= etns, etc) is removed. This facility allows admin to forcefully undo BPF link attachment, while process that created BPF link in the first place is lef= t intact. Once force-detached, BPF link stays valid in the kernel as long as there = is at least one FD open against it. It goes into defunct state, just like auto-detached BPF link. bpftool also got `link detach` command to allow triggering this in non-programmatic fashion. Cc: Toke H=C3=B8iland-J=C3=B8rgensen Andrii Nakryiko (5): bpf: add support for forced LINK_DETACH command libbpf: add bpf_link detach APIs selftests/bpf: add link detach tests for cgroup, netns, and xdp bpf_links tools/bpftool: add `link detach` subcommand tools/bpftool: add documentation and bash-completion for `link detach` include/linux/bpf.h | 1 + include/uapi/linux/bpf.h | 5 ++ kernel/bpf/cgroup.c | 15 +++++- kernel/bpf/net_namespace.c | 8 +++ kernel/bpf/syscall.c | 26 ++++++++++ net/core/dev.c | 11 +++- .../bpftool/Documentation/bpftool-link.rst | 8 +++ tools/bpf/bpftool/bash-completion/bpftool | 4 +- tools/bpf/bpftool/link.c | 35 ++++++++++++- tools/include/uapi/linux/bpf.h | 5 ++ tools/lib/bpf/bpf.c | 10 ++++ tools/lib/bpf/bpf.h | 2 + tools/lib/bpf/libbpf.c | 5 ++ tools/lib/bpf/libbpf.h | 1 + tools/lib/bpf/libbpf.map | 2 + .../selftests/bpf/prog_tests/cgroup_link.c | 20 +++++++- .../selftests/bpf/prog_tests/sk_lookup.c | 51 +++++++++---------- .../selftests/bpf/prog_tests/xdp_link.c | 14 +++++ tools/testing/selftests/bpf/testing_helpers.c | 14 +++++ tools/testing/selftests/bpf/testing_helpers.h | 3 ++ 20 files changed, 206 insertions(+), 34 deletions(-) --=20 2.24.1