From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D01D8C433E1 for ; Thu, 30 Jul 2020 12:53:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B0B132082E for ; Thu, 30 Jul 2020 12:53:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.b="FpPy62A8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726846AbgG3Mxb (ORCPT ); Thu, 30 Jul 2020 08:53:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726615AbgG3Mxa (ORCPT ); Thu, 30 Jul 2020 08:53:30 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC576C0619D4 for ; Thu, 30 Jul 2020 05:53:28 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id 3so6113130wmi.1 for ; Thu, 30 Jul 2020 05:53:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=5p3h1EoHNDt6I25i6Sk0k0PHptS8q4TynLsY8lOs+0A=; b=FpPy62A8sOsaFDTDgaKyMVxd6/T7nlCPWrdc4tuZK9iG6+tWqh4glix9euuRYHkMIg qcFNUGWa8x2SoFUI3AdF7oTWkySMtgjenp50rJKlEMtT5xy3z1RUZc7wwUJfZOEmDDsc Tzvtwm2749shNSZq1N7+jFBO4b3WCHILPZ/Tg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=5p3h1EoHNDt6I25i6Sk0k0PHptS8q4TynLsY8lOs+0A=; b=JKWaCdCycpvPRCwjOiWdCSA/tGD0EcctplRke1zisv3slJrHazLTTk99l4yCUOQ1rq 3JzePYwQUP2PMLbsr/neLWB9ihdaRnTxb9Lz9FgQlzn1rym1y4AIql3bdJEhrIJb/LLw RT4Drd82WkxAcq3ZKOQ7+QeJWke2xXsFyEYdyBya/YOWg5QvTH5lemEr+kQieBujgHXz fngz92lEan0Bi1RU3T0HHwKT7lZ5+6yQlTEk38XBgK9V8KfqARLuS0yPB/DeGzKqFgus 8n3fJ90pqqpE4f5/8HC19IfPW6ZnYego5cZPSVYBawhXSrWMbC9DOhQumFi2EmEfsHke scnw== X-Gm-Message-State: AOAM531YxkIogd4gsgYRyY7XElGxrKIfgzrLhCgWh/1MlESZNgPYy87k FRbUBIkRMTto/olkJU8tAWOiX+NHkuE= X-Google-Smtp-Source: ABdhPJwueHGR2ItU0WTJAE6scyrZDbwAcckP5+ts6Ldk5Cvo9DMgLhZwasvv/IVWHal0am0RMACV9g== X-Received: by 2002:a1c:24c4:: with SMTP id k187mr6646148wmk.148.1596113607251; Thu, 30 Jul 2020 05:53:27 -0700 (PDT) Received: from cloudflare.com ([2a02:a310:c262:aa00:b35e:8938:2c2a:ba8b]) by smtp.gmail.com with ESMTPSA id b8sm9892648wrv.4.2020.07.30.05.53.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jul 2020 05:53:26 -0700 (PDT) From: Jakub Sitnicki To: bpf@vger.kernel.org Cc: netdev@vger.kernel.org, kernel-team@cloudflare.com, Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko Subject: [PATCH bpf-next] selftests/bpf: Omit nodad flag when adding addresses to loopback Date: Thu, 30 Jul 2020 14:53:25 +0200 Message-Id: <20200730125325.1869363-1-jakub@cloudflare.com> X-Mailer: git-send-email 2.25.4 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org Setting IFA_F_NODAD flag for IPv6 addresses to add to loopback is unnecessary. Duplicate Address Detection does not happen on loopback device. Also, passing 'nodad' flag to 'ip address' breaks libbpf CI, which runs in an environment with BusyBox implementation of 'ip' command, that doesn't understand this flag. Fixes: 0ab5539f8584 ("selftests/bpf: Tests for BPF_SK_LOOKUP attach point") Reported-by: Andrii Nakryiko Signed-off-by: Jakub Sitnicki --- tools/testing/selftests/bpf/prog_tests/sk_lookup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/bpf/prog_tests/sk_lookup.c b/tools/testing/selftests/bpf/prog_tests/sk_lookup.c index 9bbd2b2b7630..379da6f10ee9 100644 --- a/tools/testing/selftests/bpf/prog_tests/sk_lookup.c +++ b/tools/testing/selftests/bpf/prog_tests/sk_lookup.c @@ -1290,8 +1290,8 @@ static void run_tests(struct test_sk_lookup *skel) static int switch_netns(void) { static const char * const setup_script[] = { - "ip -6 addr add dev lo " EXT_IP6 "/128 nodad", - "ip -6 addr add dev lo " INT_IP6 "/128 nodad", + "ip -6 addr add dev lo " EXT_IP6 "/128", + "ip -6 addr add dev lo " INT_IP6 "/128", "ip link set dev lo up", NULL, }; -- 2.25.4