From: Song Liu <songliubraving@fb.com>
To: <linux-kernel@vger.kernel.org>, <bpf@vger.kernel.org>,
<netdev@vger.kernel.org>
Cc: <ast@kernel.org>, <daniel@iogearbox.net>, <kernel-team@fb.com>,
<john.fastabend@gmail.com>, <kpsingh@chromium.org>,
<brouer@redhat.com>, <dlxu@fb.com>,
Song Liu <songliubraving@fb.com>
Subject: [PATCH bpf-next 5/5] selftests/bpf: add benchmark for uprobe vs. user_prog
Date: Sat, 1 Aug 2020 01:47:21 -0700 [thread overview]
Message-ID: <20200801084721.1812607-6-songliubraving@fb.com> (raw)
In-Reply-To: <20200801084721.1812607-1-songliubraving@fb.com>
Add a benchmark to compare performance of
1) uprobe;
2) user program w/o args;
3) user program w/ args;
4) user program w/ args on random cpu.
Sample output:
./test_progs -t uprobe_vs_user_prog -v
test_uprobe_vs_user_prog:PASS:uprobe_vs_user_prog__open_and_load 0 nsec
test_uprobe_vs_user_prog:PASS:get_base_addr 0 nsec
test_uprobe_vs_user_prog:PASS:attach_uprobe 0 nsec
run_perf_test:PASS:uprobe 0 nsec
Each uprobe uses 1419 nanoseconds
run_perf_test:PASS:user_prog_no_args 0 nsec
Each user_prog_no_args uses 313 nanoseconds
run_perf_test:PASS:user_prog_with_args 0 nsec
Each user_prog_with_args uses 335 nanoseconds
run_perf_test:PASS:user_prog_with_args_on_cpu 0 nsec
Each user_prog_with_args_on_cpu uses 2821 nanoseconds
Summary: 1/0 PASSED, 0 SKIPPED, 0 FAILED
Signed-off-by: Song Liu <songliubraving@fb.com>
---
.../bpf/prog_tests/uprobe_vs_user_prog.c | 101 ++++++++++++++++++
.../selftests/bpf/progs/uprobe_vs_user_prog.c | 21 ++++
2 files changed, 122 insertions(+)
create mode 100644 tools/testing/selftests/bpf/prog_tests/uprobe_vs_user_prog.c
create mode 100644 tools/testing/selftests/bpf/progs/uprobe_vs_user_prog.c
diff --git a/tools/testing/selftests/bpf/prog_tests/uprobe_vs_user_prog.c b/tools/testing/selftests/bpf/prog_tests/uprobe_vs_user_prog.c
new file mode 100644
index 0000000000000..dadd7b56e69ec
--- /dev/null
+++ b/tools/testing/selftests/bpf/prog_tests/uprobe_vs_user_prog.c
@@ -0,0 +1,101 @@
+// SPDX-License-Identifier: GPL-2.0
+#include <test_progs.h>
+#include "uprobe_vs_user_prog.skel.h"
+
+#define REPEAT_CNT 10000ULL
+
+static int duration;
+
+static noinline void uprobe_target(void)
+{
+ asm ("");
+}
+
+struct bpf_prog_test_run_attr attr;
+
+static void call_user_prog(void)
+{
+ bpf_prog_test_run_xattr(&attr);
+}
+
+static int numcpu;
+
+static void call_user_prog_on_cpu(void)
+{
+ static int cpu = 0;
+
+ attr.cpu_plus = cpu + 1;
+ bpf_prog_test_run_xattr(&attr);
+ cpu = (cpu + 1) % numcpu;
+}
+
+typedef void (__run_func)(void);
+
+static void run_perf_test(struct uprobe_vs_user_prog *skel,
+ __run_func func, const char *name)
+{
+ __u64 start_time, total_time;
+ int i;
+
+ skel->bss->sum = 0;
+
+ start_time = time_get_ns();
+ for (i = 0; i < REPEAT_CNT; i++)
+ func();
+ total_time = time_get_ns() - start_time;
+
+ CHECK(skel->bss->sum != REPEAT_CNT, name,
+ "missed %llu times\n", REPEAT_CNT - skel->bss->sum);
+ printf("Each %s uses %llu nanoseconds\n", name, total_time / REPEAT_CNT);
+}
+
+void test_uprobe_vs_user_prog(void)
+{
+ struct bpf_user_prog_args args = {};
+ struct uprobe_vs_user_prog *skel;
+ struct bpf_link *uprobe_link;
+ size_t uprobe_offset;
+ ssize_t base_addr;
+
+ skel = uprobe_vs_user_prog__open_and_load();
+
+ if (CHECK(!skel, "uprobe_vs_user_prog__open_and_load",
+ "skeleton open_and_laod failed\n"))
+ return;
+
+ base_addr = get_base_addr();
+ if (CHECK(base_addr < 0, "get_base_addr",
+ "failed to find base addr: %zd", base_addr))
+ return;
+ uprobe_offset = (size_t)&uprobe_target - base_addr;
+ uprobe_link = bpf_program__attach_uprobe(skel->progs.handle_uprobe,
+ false /* retprobe */,
+ 0 /* self pid */,
+ "/proc/self/exe",
+ uprobe_offset);
+
+ if (CHECK(IS_ERR(uprobe_link), "attach_uprobe",
+ "err %ld\n", PTR_ERR(uprobe_link)))
+ goto cleanup;
+ skel->links.handle_uprobe = uprobe_link;
+
+ run_perf_test(skel, uprobe_target, "uprobe");
+
+ attr.prog_fd = bpf_program__fd(skel->progs.user_prog);
+ run_perf_test(skel, call_user_prog, "user_prog_no_args");
+
+ attr.data_size_in = sizeof(args);
+ attr.data_in = &args;
+ run_perf_test(skel, call_user_prog, "user_prog_with_args");
+
+ numcpu = libbpf_num_possible_cpus();
+
+ if (numcpu <= 0)
+ goto cleanup;
+
+ run_perf_test(skel, call_user_prog_on_cpu,
+ "user_prog_with_args_on_cpu");
+
+cleanup:
+ uprobe_vs_user_prog__destroy(skel);
+}
diff --git a/tools/testing/selftests/bpf/progs/uprobe_vs_user_prog.c b/tools/testing/selftests/bpf/progs/uprobe_vs_user_prog.c
new file mode 100644
index 0000000000000..8b327b7cee30d
--- /dev/null
+++ b/tools/testing/selftests/bpf/progs/uprobe_vs_user_prog.c
@@ -0,0 +1,21 @@
+// SPDX-License-Identifier: GPL-2.0
+// Copyright (c) 2017 Facebook
+#include "vmlinux.h"
+#include <bpf/bpf_helpers.h>
+#include <bpf/bpf_tracing.h>
+
+volatile __u64 sum = 0;
+
+SEC("uprobe/func")
+int handle_uprobe(struct pt_regs *ctx)
+{
+ sum++;
+ return 0;
+}
+
+SEC("user")
+int user_prog(struct pt_regs *ctx)
+{
+ sum++;
+ return 0;
+}
--
2.24.1
next prev parent reply other threads:[~2020-08-01 8:49 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-01 8:47 [PATCH bpf-next 0/5] introduce BPF_PROG_TYPE_USER Song Liu
2020-08-01 8:47 ` [PATCH bpf-next 1/5] bpf: " Song Liu
2020-08-01 13:58 ` kernel test robot
2020-08-01 15:21 ` kernel test robot
2020-08-06 18:18 ` kernel test robot
2020-08-06 18:18 ` [RFC PATCH] bpf: user_verifier_ops can be static kernel test robot
2020-08-01 8:47 ` [PATCH bpf-next 2/5] libbpf: support BPF_PROG_TYPE_USER programs Song Liu
2020-08-03 1:40 ` Andrii Nakryiko
2020-08-03 4:21 ` Song Liu
2020-08-03 5:05 ` Andrii Nakryiko
2020-08-04 1:18 ` Song Liu
2020-08-05 1:38 ` Andrii Nakryiko
2020-08-05 3:59 ` Song Liu
2020-08-05 5:32 ` Andrii Nakryiko
2020-08-05 6:26 ` Song Liu
2020-08-05 6:54 ` Andrii Nakryiko
2020-08-05 7:23 ` Song Liu
2020-08-05 17:44 ` Andrii Nakryiko
2020-08-01 8:47 ` [PATCH bpf-next 3/5] selftests/bpf: add selftest for BPF_PROG_TYPE_USER Song Liu
2020-08-03 1:43 ` Andrii Nakryiko
2020-08-03 4:33 ` Song Liu
2020-08-03 5:07 ` Andrii Nakryiko
2020-08-01 8:47 ` [PATCH bpf-next 4/5] selftests/bpf: move two functions to test_progs.c Song Liu
2020-08-03 1:46 ` Andrii Nakryiko
2020-08-03 4:34 ` Song Liu
2020-08-01 8:47 ` Song Liu [this message]
2020-08-03 1:51 ` [PATCH bpf-next 5/5] selftests/bpf: add benchmark for uprobe vs. user_prog Andrii Nakryiko
2020-08-03 4:47 ` Song Liu
2020-08-03 5:10 ` Andrii Nakryiko
2020-08-04 20:54 ` Song Liu
2020-08-05 1:52 ` Andrii Nakryiko
2020-08-05 4:47 ` Song Liu
2020-08-05 5:47 ` Andrii Nakryiko
2020-08-05 7:01 ` Song Liu
2020-08-05 17:39 ` Andrii Nakryiko
2020-08-05 18:41 ` Song Liu
2020-08-05 17:16 ` Alexei Starovoitov
2020-08-05 17:27 ` Andrii Nakryiko
2020-08-05 17:45 ` Alexei Starovoitov
2020-08-05 17:56 ` Andrii Nakryiko
2020-08-05 18:56 ` Song Liu
2020-08-05 22:50 ` Alexei Starovoitov
2020-08-05 23:50 ` Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200801084721.1812607-6-songliubraving@fb.com \
--to=songliubraving@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=dlxu@fb.com \
--cc=john.fastabend@gmail.com \
--cc=kernel-team@fb.com \
--cc=kpsingh@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).