bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Martin KaFai Lau <kafai@fb.com>
To: Andrii Nakryiko <andriin@fb.com>
Cc: <bpf@vger.kernel.org>, <netdev@vger.kernel.org>, <ast@fb.com>,
	<daniel@iogearbox.net>, <andrii.nakryiko@gmail.com>,
	<kernel-team@fb.com>
Subject: Re: [PATCH bpf-next 2/3] libbpf: compile libbpf under -O2 level by default and catch extra warnings
Date: Tue, 29 Sep 2020 17:03:16 -0700	[thread overview]
Message-ID: <20200930000316.ifjq5vn3wtsth5s3@kafai-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <20200929220604.833631-2-andriin@fb.com>

On Tue, Sep 29, 2020 at 03:06:03PM -0700, Andrii Nakryiko wrote:
> For some reason compiler doesn't complain about uninitialized variable, fixed
> in previous patch, if libbpf is compiled without -O2 optimization level. So do
> compile it with -O2 and never let similar issue slip by again. -Wall is added
> unconditionally, so no need to specify it again.
Acked-by: Martin KaFai Lau <kafai@fb.com>

  reply	other threads:[~2020-09-30  0:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-29 22:06 [PATCH bpf-next 1/3] libbpf: fix uninitialized variable in btf_parse_type_sec Andrii Nakryiko
2020-09-29 22:06 ` [PATCH bpf-next 2/3] libbpf: compile libbpf under -O2 level by default and catch extra warnings Andrii Nakryiko
2020-09-30  0:03   ` Martin KaFai Lau [this message]
2020-09-29 22:06 ` [PATCH bpf-next 3/3] libbpf: compile in PIC mode only for shared library case Andrii Nakryiko
2020-09-30  0:04   ` Martin KaFai Lau
2020-09-30  0:01 ` [PATCH bpf-next 1/3] libbpf: fix uninitialized variable in btf_parse_type_sec Martin KaFai Lau
2020-09-30  0:10 ` patchwork-bot+bpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200930000316.ifjq5vn3wtsth5s3@kafai-mbp.dhcp.thefacebook.com \
    --to=kafai@fb.com \
    --cc=andrii.nakryiko@gmail.com \
    --cc=andriin@fb.com \
    --cc=ast@fb.com \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=kernel-team@fb.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).