From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1C41C433DF for ; Thu, 15 Oct 2020 19:26:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9A780206B5 for ; Thu, 15 Oct 2020 19:26:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602789988; bh=kSAb21hpwT1aCd33FktRvAwhXCN3mQbWCGEF448daDc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=WCGewfiDFcNyd1fMa0G0X4vL2PAyU5Ef6xV9duczmlzhnbe3ioOyu750R7qzxzCxQ vapTJVzE6LwC7HwU89EAOj6Dwy0yWnonDhxR0SI/Td7VUD4cWmJq+R1Y2gfg4g7SMo 9OQ1rODDV5DrIV7XJoKQrWNn7luZFj3GPS6g/HK4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391495AbgJOT02 (ORCPT ); Thu, 15 Oct 2020 15:26:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:57904 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391493AbgJOT01 (ORCPT ); Thu, 15 Oct 2020 15:26:27 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 55A6E206B2; Thu, 15 Oct 2020 19:26:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602789987; bh=kSAb21hpwT1aCd33FktRvAwhXCN3mQbWCGEF448daDc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=wYvXM3LElR+nLi1kXzzt1Tv+vEGEi1aXzwdWs0VVuZZzD3RNjbYz2UMGJYzUXyv3r gw4QEVcwBRxGSZVUTDcmIP46vi6LluzwtL42/+pAGgIxZYqM5x5J6d4ve3EPkX2lYP znJ7jfAWL4rllyd+QOGYMa+/9iTgJRpC5rn9wIis= Date: Thu, 15 Oct 2020 12:26:24 -0700 From: Jakub Kicinski To: Alexei Starovoitov Cc: YueHaibing , "David S. Miller" , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko , John Fastabend , KP Singh , Masahiro Yamada , Network Development , bpf , LKML Subject: Re: [PATCH] bpfilter: Fix build error with CONFIG_BPFILTER_UMH Message-ID: <20201015122624.0ca7b58c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: References: <20201014091749.25488-1-yuehaibing@huawei.com> <20201015093748.587a72b5@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20201015115643.3a4d4820@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Thu, 15 Oct 2020 12:03:14 -0700 Alexei Starovoitov wrote: > On Thu, Oct 15, 2020 at 11:56 AM Jakub Kicinski wrote: > > How so? It's using in-tree headers instead of system ones. > > Many samples seem to be doing the same thing. > > There is no such thing as "usr/include" in the kernel build and source trees. Hm. I thought bpfilter somehow depends on make headers. But it doesn't seem to. Reverting now. > > > Also please don't take bpf patches. > > > > You had it marked it as netdev in your patchwork :/ > > It was delegated automatically by the patchwork system. > I didn't have time to reassign, but you should have known better > when you saw 'bpfilter' in the subject. The previous committers for bpfilter are almost all Dave, so I checked your patchwork to make sure and it was netdev... I'll do better next time :)