From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6E0AC388F7 for ; Wed, 4 Nov 2020 20:34:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8DB9A20782 for ; Wed, 4 Nov 2020 20:34:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604522041; bh=eqryOwvWfKvR3/KbsIRgMeNj6AdkLgoFQKRZP0OIy74=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=eoEY+koBfvqV+UKGYdfcRNRWfoiVxNSLzat/GC5mr+41QHBUhSMRNCv+GpT20tEIO G2hqwd79RVp0rIwvE0s5BQ+cbVMW0F6u4BKGCDgVQX8cylFG1LjSb0Td6M9ecU//Ij 2Mhd8jKH2UmblRKuUb0AITE4iCCDVHUffZeX2yZA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732033AbgKDUdu (ORCPT ); Wed, 4 Nov 2020 15:33:50 -0500 Received: from mail.kernel.org ([198.145.29.99]:55980 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732027AbgKDUdu (ORCPT ); Wed, 4 Nov 2020 15:33:50 -0500 Received: from kernel.org (83-245-197-237.elisa-laajakaista.fi [83.245.197.237]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DAF77221E2; Wed, 4 Nov 2020 20:33:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604522029; bh=eqryOwvWfKvR3/KbsIRgMeNj6AdkLgoFQKRZP0OIy74=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=zmfGPfjJV/mSi+//pJ1ML1C9xWr/RpmyKnCLbcuDp8IaVorPKhzS+n5yDmu7QkzLE lclUfwisl0ZPw4O3MyuRVCodfO2RCLohUd7x0M3fKtaKWWt4dHR7CcKvnv8io4XKSU KuLxhunZxx4bxZ0kpYfZFuz+sMmP+hCveDCMH1l0= Date: Wed, 4 Nov 2020 22:33:39 +0200 From: Jarkko Sakkinen To: Nick Desaulniers Cc: Andrew Morton , stable@vger.kernel.org, Chen Yu , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko , John Fastabend , KP Singh , Nathan Chancellor , Miguel Ojeda , Kees Cook , Marco Elver , Arvind Sankar , Randy Dunlap , Sami Tolvanen , Ingo Molnar , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, clang-built-linux@googlegroups.com Subject: Re: [PATCH] compiler-clang: remove version check for BPF Tracing Message-ID: <20201104203339.GA692084@kernel.org> References: <20201104191052.390657-1-ndesaulniers@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201104191052.390657-1-ndesaulniers@google.com> Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Wed, Nov 04, 2020 at 11:10:51AM -0800, Nick Desaulniers wrote: > bpftrace parses the kernel headers and uses Clang under the hood. Remove > the version check when __BPF_TRACING__ is defined (as bpftrace does) so > that this tool can continue to parse kernel headers, even with older > clang sources. > > Cc: > Fixes: commit 1f7a44f63e6c ("compiler-clang: add build check for clang 10.0.1") > Reported-by: Chen Yu > Reported-by: Jarkko Sakkinen > Signed-off-by: Nick Desaulniers > --- Thank you, resolved my issue. Acked-by: Jarkko Sakkinen Tested-by: Jarkko Sakkinen > include/linux/compiler-clang.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/linux/compiler-clang.h b/include/linux/compiler-clang.h > index dd7233c48bf3..98cff1b4b088 100644 > --- a/include/linux/compiler-clang.h > +++ b/include/linux/compiler-clang.h > @@ -8,8 +8,10 @@ > + __clang_patchlevel__) > > #if CLANG_VERSION < 100001 > +#ifndef __BPF_TRACING__ > # error Sorry, your version of Clang is too old - please use 10.0.1 or newer. > #endif > +#endif > > /* Compiler specific definitions for Clang compiler */ > > -- > 2.29.1.341.ge80a0c044ae-goog > > /Jarkko