From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, davem@davemloft.net,
kuba@kernel.org, lorenzo.bianconi@redhat.com,
ilias.apalodimas@linaro.org, brouer@redhat.com
Subject: Re: [PATCH v5 net-nex 0/5] xdp: introduce bulking for page_pool tx return path
Date: Tue, 10 Nov 2020 16:50:52 +0100 [thread overview]
Message-ID: <20201110165052.4476c52b@carbon> (raw)
In-Reply-To: <cover.1605020963.git.lorenzo@kernel.org>
On Tue, 10 Nov 2020 16:37:55 +0100
Lorenzo Bianconi <lorenzo@kernel.org> wrote:
> XDP bulk APIs introduce a defer/flush mechanism to return
> pages belonging to the same xdp_mem_allocator object
> (identified via the mem.id field) in bulk to optimize
> I-cache and D-cache since xdp_return_frame is usually run
> inside the driver NAPI tx completion loop.
> Convert mvneta, mvpp2 and mlx5 drivers to xdp_return_frame_bulk APIs.
Series
Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
> Changes since v4:
> - fix comments
> - introduce xdp_frame_bulk_init utility routine
> - compiler annotations for I-cache code layout
> - move rcu_read_lock outside fast-path
> - mlx5 xdp bulking code optimization
I've done a lot of these changes, and benchmarked them on mlx5, details in[1].
[1] https://github.com/xdp-project/xdp-project/blob/master/areas/mem/xdp_bulk_return01.org
> Changes since v3:
> - align DEV_MAP_BULK_SIZE to XDP_BULK_QUEUE_SIZE
> - refactor page_pool_put_page_bulk to avoid code duplication
>
> Changes since v2:
> - move mvneta changes in a dedicated patch
>
> Changes since v1:
> - improve comments
> - rework xdp_return_frame_bulk routine logic
> - move count and xa fields at the beginning of xdp_frame_bulk struct
> - invert logic in page_pool_put_page_bulk for loop
>
> Lorenzo Bianconi (5):
> net: xdp: introduce bulking for xdp tx return path
> net: page_pool: add bulk support for ptr_ring
> net: mvneta: add xdp tx return bulking support
> net: mvpp2: add xdp tx return bulking support
> net: mlx5: add xdp tx return bulking support
>
> drivers/net/ethernet/marvell/mvneta.c | 10 ++-
> .../net/ethernet/marvell/mvpp2/mvpp2_main.c | 10 ++-
> .../net/ethernet/mellanox/mlx5/core/en/xdp.c | 22 ++++--
> include/net/page_pool.h | 26 +++++++
> include/net/xdp.h | 17 ++++-
> net/core/page_pool.c | 69 ++++++++++++++++---
> net/core/xdp.c | 54 +++++++++++++++
> 7 files changed, 191 insertions(+), 17 deletions(-)
>
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2020-11-10 15:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 15:37 [PATCH v5 net-nex 0/5] xdp: introduce bulking for page_pool tx return path Lorenzo Bianconi
2020-11-10 15:37 ` [PATCH v5 net-nex 1/5] net: xdp: introduce bulking for xdp " Lorenzo Bianconi
2020-11-10 15:37 ` [PATCH v5 net-nex 2/5] net: page_pool: add bulk support for ptr_ring Lorenzo Bianconi
2020-11-11 9:29 ` John Fastabend
2020-11-11 10:43 ` Lorenzo Bianconi
2020-11-11 12:59 ` Jesper Dangaard Brouer
2020-11-10 15:37 ` [PATCH v5 net-nex 3/5] net: mvneta: add xdp tx return bulking support Lorenzo Bianconi
2020-11-10 15:37 ` [PATCH v5 net-nex 4/5] net: mvpp2: " Lorenzo Bianconi
2020-11-10 15:38 ` [PATCH v5 net-nex 5/5] net: mlx5: " Lorenzo Bianconi
2020-11-10 16:19 ` Jesper Dangaard Brouer
2020-11-10 15:50 ` Jesper Dangaard Brouer [this message]
2020-11-10 15:56 ` [PATCH v5 net-nex 0/5] xdp: introduce bulking for page_pool tx return path Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201110165052.4476c52b@carbon \
--to=brouer@redhat.com \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=ilias.apalodimas@linaro.org \
--cc=kuba@kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=lorenzo@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).