From: Andrii Nakryiko <andrii@kernel.org>
To: <bpf@vger.kernel.org>, <netdev@vger.kernel.org>, <ast@fb.com>,
<daniel@iogearbox.net>
Cc: <andrii@kernel.org>, <kernel-team@fb.com>
Subject: [PATCH v2 bpf-next 1/8] bpf: keep module's btf_data_size intact after load
Date: Mon, 30 Nov 2020 19:55:38 -0800 [thread overview]
Message-ID: <20201201035545.3013177-2-andrii@kernel.org> (raw)
In-Reply-To: <20201201035545.3013177-1-andrii@kernel.org>
Having real btf_data_size stored in struct module is benefitial to quickly
determine which kernel modules have associated BTF object and which don't.
There is no harm in keeping this info, as opposed to keeping invalid pointer.
Fixes: 607c543f939d ("bpf: Sanitize BTF data pointer after module is loaded")
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
---
kernel/module.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/module.c b/kernel/module.c
index 18f259d61d14..c3a9e972d3b2 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -3712,7 +3712,6 @@ static noinline int do_init_module(struct module *mod)
#ifdef CONFIG_DEBUG_INFO_BTF_MODULES
/* .BTF is not SHF_ALLOC and will get removed, so sanitize pointer */
mod->btf_data = NULL;
- mod->btf_data_size = 0;
#endif
/*
* We want to free module_init, but be aware that kallsyms may be
--
2.24.1
next prev parent reply other threads:[~2020-12-01 3:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 3:55 [PATCH v2 bpf-next 0/8] Support BTF-powered BPF tracing programs for kernel modules Andrii Nakryiko
2020-12-01 3:55 ` Andrii Nakryiko [this message]
2020-12-01 3:55 ` [PATCH v2 bpf-next 2/8] bpf: remove hard-coded btf_vmlinux assumption from BPF verifier Andrii Nakryiko
2020-12-01 3:55 ` [PATCH v2 bpf-next 3/8] bpf: allow to specify kernel module BTFs when attaching BPF programs Andrii Nakryiko
2020-12-01 3:55 ` [PATCH v2 bpf-next 4/8] libbpf: factor out low-level BPF program loading helper Andrii Nakryiko
2020-12-01 3:55 ` [PATCH v2 bpf-next 5/8] libbpf: support attachment of BPF tracing programs to kernel modules Andrii Nakryiko
2020-12-01 3:55 ` [PATCH v2 bpf-next 6/8] selftests/bpf: add tp_btf CO-RE reloc test for modules Andrii Nakryiko
2020-12-01 3:55 ` [PATCH v2 bpf-next 7/8] selftests/bpf: make bpf_testmod's traceable function global Andrii Nakryiko
2020-12-01 3:55 ` [PATCH v2 bpf-next 8/8] selftests/bpf: add fentry/fexit/fmod_ret selftest for kernel module Andrii Nakryiko
2020-12-01 7:26 ` [PATCH v2 bpf-next 0/8] Support BTF-powered BPF tracing programs for kernel modules Yonghong Song
2020-12-01 21:50 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201201035545.3013177-2-andrii@kernel.org \
--to=andrii@kernel.org \
--cc=ast@fb.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).