From: Brendan Jackman <jackmanb@google.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: bpf@vger.kernel.org, Alexei Starovoitov <ast@kernel.org>,
Yonghong Song <yhs@fb.com>,
Daniel Borkmann <daniel@iogearbox.net>,
KP Singh <kpsingh@chromium.org>,
Florent Revest <revest@chromium.org>,
linux-kernel@vger.kernel.org, Jann Horn <jannh@google.com>
Subject: Re: [PATCH v2 bpf-next 01/13] bpf: x86: Factor out emission of ModR/M for *(reg + off)
Date: Tue, 1 Dec 2020 12:14:37 +0000 [thread overview]
Message-ID: <20201201121437.GB2114905@google.com> (raw)
In-Reply-To: <20201129011552.jbepegeeo2lqv6ke@ast-mbp>
On Sat, Nov 28, 2020 at 05:15:52PM -0800, Alexei Starovoitov wrote:
> On Fri, Nov 27, 2020 at 05:57:26PM +0000, Brendan Jackman wrote:
> > +/* Emit the ModR/M byte for addressing *(r1 + off) and r2 */
> > +static void emit_modrm_dstoff(u8 **pprog, u32 r1, u32 r2, int off)
>
> same concern as in the another patch. If you could avoid intel's puzzling names
> like above it will make reviewing the patch easier.
In this case there is actually a call like
emit_modrm_dstoff(&prog, src_reg, dst_reg)
So calling the function args dst_reg, src_reg would be misleading.
I could call them ptr_reg and val_reg or something?
next prev parent reply other threads:[~2020-12-01 12:15 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-27 17:57 [PATCH v2 bpf-next 00/13] Atomics for eBPF Brendan Jackman
2020-11-27 17:57 ` [PATCH v2 bpf-next 01/13] bpf: x86: Factor out emission of ModR/M for *(reg + off) Brendan Jackman
2020-11-29 1:15 ` Alexei Starovoitov
2020-12-01 12:14 ` Brendan Jackman [this message]
2020-12-02 5:50 ` Alexei Starovoitov
2020-12-02 10:52 ` Brendan Jackman
2020-12-02 17:35 ` Alexei Starovoitov
2020-11-27 17:57 ` [PATCH v2 bpf-next 02/13] bpf: x86: Factor out emission of REX byte Brendan Jackman
2020-11-29 1:14 ` Alexei Starovoitov
2020-12-01 12:12 ` Brendan Jackman
2020-12-02 5:48 ` Alexei Starovoitov
2020-12-02 10:54 ` Brendan Jackman
2020-11-27 17:57 ` [PATCH v2 bpf-next 03/13] bpf: x86: Factor out function to emit NEG Brendan Jackman
2020-11-27 17:57 ` [PATCH v2 bpf-next 04/13] bpf: x86: Factor out a lookup table for some ALU opcodes Brendan Jackman
2020-11-27 17:57 ` [PATCH v2 bpf-next 05/13] bpf: Rename BPF_XADD and prepare to encode other atomics in .imm Brendan Jackman
2020-11-28 3:43 ` Yonghong Song
2020-12-01 12:17 ` Brendan Jackman
2020-11-27 17:57 ` [PATCH v2 bpf-next 06/13] bpf: Move BPF_STX reserved field check into BPF_STX verifier code Brendan Jackman
2020-11-27 17:57 ` [PATCH v2 bpf-next 07/13] bpf: Add BPF_FETCH field / create atomic_fetch_add instruction Brendan Jackman
2020-11-28 4:15 ` Yonghong Song
2020-12-01 12:22 ` Brendan Jackman
2020-11-27 17:57 ` [PATCH v2 bpf-next 08/13] bpf: Add instructions for atomic_[cmp]xchg Brendan Jackman
2020-11-28 5:25 ` Yonghong Song
2020-12-01 12:27 ` Brendan Jackman
2020-11-29 1:27 ` Alexei Starovoitov
2020-12-01 12:32 ` Brendan Jackman
2020-11-27 17:57 ` [PATCH v2 bpf-next 09/13] bpf: Pull out a macro for interpreting atomic ALU operations Brendan Jackman
2020-11-27 17:57 ` [PATCH v2 bpf-next 10/13] bpf: Add instructions for atomic[64]_[fetch_]sub Brendan Jackman
2020-11-27 21:39 ` kernel test robot
2020-11-27 21:39 ` [RFC PATCH] bpf: bpf_atomic_alu_string[] can be static kernel test robot
2020-11-28 5:35 ` [PATCH v2 bpf-next 10/13] bpf: Add instructions for atomic[64]_[fetch_]sub Yonghong Song
2020-11-29 1:34 ` Alexei Starovoitov
2020-11-30 17:18 ` Yonghong Song
2020-12-01 12:38 ` Brendan Jackman
2020-12-02 5:55 ` Alexei Starovoitov
2020-12-02 11:19 ` Brendan Jackman
2020-11-27 17:57 ` [PATCH v2 bpf-next 11/13] bpf: Add bitwise atomic instructions Brendan Jackman
2020-11-28 5:39 ` Yonghong Song
2020-11-29 1:36 ` Alexei Starovoitov
2020-11-30 17:20 ` Yonghong Song
2020-11-27 17:57 ` [PATCH v2 bpf-next 12/13] bpf: Add tests for new BPF atomic operations Brendan Jackman
2020-12-01 3:55 ` Yonghong Song
2020-12-01 12:56 ` Brendan Jackman
2020-12-01 17:24 ` Yonghong Song
2020-12-02 2:22 ` Andrii Nakryiko
2020-12-02 12:26 ` Brendan Jackman
2020-11-27 17:57 ` [PATCH v2 bpf-next 13/13] bpf: Document new atomic instructions Brendan Jackman
2020-11-28 5:53 ` [PATCH v2 bpf-next 00/13] Atomics for eBPF Yonghong Song
2020-11-29 1:40 ` Alexei Starovoitov
2020-11-30 17:22 ` Yonghong Song
2020-12-01 3:48 ` Yonghong Song
2020-12-02 2:00 ` Andrii Nakryiko
2020-12-02 5:05 ` Yonghong Song
2020-12-02 5:53 ` John Fastabend
2020-12-02 5:59 ` Andrii Nakryiko
2020-12-02 6:27 ` John Fastabend
2020-12-02 8:03 ` Yonghong Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201201121437.GB2114905@google.com \
--to=jackmanb@google.com \
--cc=alexei.starovoitov@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jannh@google.com \
--cc=kpsingh@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=revest@chromium.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).