From: Martin KaFai Lau <kafai@fb.com>
To: KP Singh <kpsingh@kernel.org>
Cc: <bpf@vger.kernel.org>, Gilad Reti <gilad.reti@gmail.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>
Subject: Re: [PATCH bpf] bpf: local storage helpers should check nullness of owner ptr passed
Date: Thu, 7 Jan 2021 11:11:07 -0800 [thread overview]
Message-ID: <20210107191107.tygbtfi6i6ma3xkw@kafai-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <20210107173729.2667975-1-kpsingh@kernel.org>
On Thu, Jan 07, 2021 at 05:37:29PM +0000, KP Singh wrote:
> The verifier allows ARG_PTR_TO_BTF_ID helper arguments to be NULL, so
> helper implementations need to check this before dereferencing them.
> This was already fixed for the socket storage helpers but not for task
> and inode.
Acked-by: Martin KaFai Lau <kafai@fb.com>
prev parent reply other threads:[~2021-01-07 19:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-07 17:37 [PATCH bpf] bpf: local storage helpers should check nullness of owner ptr passed KP Singh
2021-01-07 19:07 ` Andrii Nakryiko
2021-01-07 19:15 ` Andrii Nakryiko
2021-01-07 20:25 ` KP Singh
2021-01-11 14:06 ` Daniel Borkmann
2021-01-11 17:19 ` KP Singh
2021-01-07 19:11 ` Martin KaFai Lau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210107191107.tygbtfi6i6ma3xkw@kafai-mbp.dhcp.thefacebook.com \
--to=kafai@fb.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=gilad.reti@gmail.com \
--cc=kpsingh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).