From: Jakub Kicinski <kuba@kernel.org>
To: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Cc: netdev@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
virtualization@lists.linux-foundation.org, bpf@vger.kernel.org,
dust.li@linux.alibaba.com
Subject: Re: [PATCH netdev] virtio-net: support XDP_TX when not more queues
Date: Fri, 15 Jan 2021 17:47:52 -0800 [thread overview]
Message-ID: <20210115174752.3d2e8109@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <81abae33fc8dbec37ef0061ff6f6fd696b484a3e.1610523188.git.xuanzhuo@linux.alibaba.com>
On Wed, 13 Jan 2021 16:08:57 +0800 Xuan Zhuo wrote:
> The number of queues implemented by many virtio backends is limited,
> especially some machines have a large number of CPUs. In this case, it
> is often impossible to allocate a separate queue for XDP_TX.
>
> This patch allows XDP_TX to run by reuse the existing SQ with
> __netif_tx_lock() hold when there are not enough queues.
>
> Signed-off-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
> Reviewed-by: Dust Li <dust.li@linux.alibaba.com>
Since reviews are not coming in let me share some of mine.
nit: please put [PATCH net-next] not [PATCH netdev]
> -static struct send_queue *virtnet_xdp_sq(struct virtnet_info *vi)
> +static struct send_queue *virtnet_get_xdp_sq(struct virtnet_info *vi)
> {
> unsigned int qp;
> + struct netdev_queue *txq;
nit: please order variable declaration lines longest to shortest
> +
> + if (vi->curr_queue_pairs > nr_cpu_ids) {
> + qp = vi->curr_queue_pairs - vi->xdp_queue_pairs + smp_processor_id();
> + } else {
> + qp = smp_processor_id() % vi->curr_queue_pairs;
> + txq = netdev_get_tx_queue(vi->dev, qp);
> + __netif_tx_lock(txq, raw_smp_processor_id());
> + }
>
> - qp = vi->curr_queue_pairs - vi->xdp_queue_pairs + smp_processor_id();
> return &vi->sq[qp];
> }
>
> +static void virtnet_put_xdp_sq(struct virtnet_info *vi)
> +{
> + unsigned int qp;
> + struct netdev_queue *txq;
nit: longest to shortest
> +
> + if (vi->curr_queue_pairs <= nr_cpu_ids) {
> + qp = smp_processor_id() % vi->curr_queue_pairs;
Feels a little wasteful to do the modulo calculation twice per packet.
> + txq = netdev_get_tx_queue(vi->dev, qp);
> + __netif_tx_unlock(txq);
> + }
> +}
> + vi->xdp_enabled = false;
> if (prog) {
> for (i = 0; i < vi->max_queue_pairs; i++) {
> rcu_assign_pointer(vi->rq[i].xdp_prog, prog);
> if (i == 0 && !old_prog)
> virtnet_clear_guest_offloads(vi);
> }
> + vi->xdp_enabled = true;
is xdp_enabled really needed? can't we do the headroom calculation
based on the program pointer being not NULL? Either way xdp_enabled
should not temporarily switch true -> false -> true when program
is swapped.
> }
>
> for (i = 0; i < vi->max_queue_pairs; i++) {
next prev parent reply other threads:[~2021-01-16 1:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 8:08 [PATCH netdev] virtio-net: support XDP_TX when not more queues Xuan Zhuo
2021-01-16 1:47 ` Jakub Kicinski [this message]
2021-02-10 21:40 ` Michael S. Tsirkin
2021-02-11 11:00 ` Jesper Dangaard Brouer
2021-02-18 2:18 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210115174752.3d2e8109@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dust.li@linux.alibaba.com \
--cc=hawk@kernel.org \
--cc=jasowang@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).