From: Jiri Olsa <jolsa@redhat.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>, Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andriin@fb.com>,
dwarves@vger.kernel.org, netdev@vger.kernel.org,
bpf@vger.kernel.org, Yonghong Song <yhs@fb.com>,
Hao Luo <haoluo@google.com>, Martin KaFai Lau <kafai@fb.com>,
Song Liu <songliubraving@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@chromium.org>,
Joe Lawrence <joe.lawrence@redhat.com>,
Mark Wielaard <mjw@redhat.com>,
Yulia Kopkova <ykopkova@redhat.com>
Subject: Re: [PATCH 2/2] bpf_encoder: Translate SHN_XINDEX in symbol's st_shndx values
Date: Fri, 22 Jan 2021 21:24:03 +0100 [thread overview]
Message-ID: <20210122202403.GC35850@krava> (raw)
In-Reply-To: <20210122195228.GB617095@kernel.org>
On Fri, Jan 22, 2021 at 04:52:28PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Fri, Jan 22, 2021 at 05:39:20PM +0100, Jiri Olsa escreveu:
> > For very large ELF objects (with many sections), we could
> > get special value SHN_XINDEX (65535) for symbol's st_shndx.
> >
> > This patch is adding code to detect the optional extended
> > section index table and use it to resolve symbol's section
> > index.
> >
> > Adding elf_symtab__for_each_symbol_index macro that returns
> > symbol's section index and usign it in collect functions.
>
> From a quick look it seems you addressed Andrii's review comments,
> right?
yep, it's described in the cover email
>
> I've merged it locally, but would like to have some detailed set of
> steps on how to test this, so that I can add it to a "Committer testing"
> section in the cset commit log and probably add it to my local set of
> regression tests.
sorry I forgot to mention that:
The test was to run pahole on kernel compiled with:
make KCFLAGS="-ffunction-sections -fdata-sections" -j$(nproc) vmlinux
and ensure FUNC records are generated and match normal
build (without above KCFLAGS)
Also bpf selftest passed.
>
> Who originally reported this? Joe? Also can someone provide a Tested-by:
> in addition to mine when I get this detailed set of steps to test?
oops, it was reported by Yulia Kopkova (just cc-ed)
Joe tested the v2 of the patchset, I'll make a dwarves scratch
build with v3 and let them test it
jirka
next prev parent reply other threads:[~2021-01-22 20:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 16:39 [PATCHv3 0/2] libbpf: Add support to use optional extended section index table Jiri Olsa
2021-01-22 16:39 ` [PATCH 1/2] elf_symtab: Add support for SHN_XINDEX index to elf_section_by_name Jiri Olsa
2021-01-22 19:45 ` Arnaldo Carvalho de Melo
2021-01-22 20:05 ` Andrii Nakryiko
2021-01-22 16:39 ` [PATCH 2/2] bpf_encoder: Translate SHN_XINDEX in symbol's st_shndx values Jiri Olsa
2021-01-22 19:52 ` Arnaldo Carvalho de Melo
2021-01-22 20:24 ` Jiri Olsa [this message]
2021-01-22 20:33 ` Arnaldo Carvalho de Melo
2021-01-25 16:16 ` Joe Lawrence
2021-01-22 20:16 ` Andrii Nakryiko
2021-01-22 20:37 ` Jiri Olsa
2021-01-25 17:37 ` Arnaldo Carvalho de Melo
2021-01-25 17:38 ` Arnaldo Carvalho de Melo
2021-01-24 22:15 [PATCHv4 0/2] libbpf: Add support to use optional extended section index table Jiri Olsa
2021-01-24 22:15 ` [PATCH 2/2] bpf_encoder: Translate SHN_XINDEX in symbol's st_shndx values Jiri Olsa
2021-01-25 23:51 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210122202403.GC35850@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=dwarves@vger.kernel.org \
--cc=haoluo@google.com \
--cc=joe.lawrence@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kafai@fb.com \
--cc=kpsingh@chromium.org \
--cc=mjw@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
--cc=ykopkova@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).