From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B70F4C433DB for ; Thu, 28 Jan 2021 00:24:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 751E661492 for ; Thu, 28 Jan 2021 00:24:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231810AbhA1AYa (ORCPT ); Wed, 27 Jan 2021 19:24:30 -0500 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:18456 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231840AbhA1AVb (ORCPT ); Wed, 27 Jan 2021 19:21:31 -0500 Received: from pps.filterd (m0044010.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 10S0FYeD004764 for ; Wed, 27 Jan 2021 16:20:50 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=facebook; bh=9MXKxqv+SncBnz5OqxIZYK7jmff9BGIDVI3Ly/9d+n0=; b=FNwbL5GpwKsoiBfjo1+KXlfUkUfMaDV7V9HAf4/pZrUNWGasWzx60Z7Gy9H4DFFWctWB 2GEK1biaNcYpR9jzZVxowSJ73FRqLWwQ3gxX3ZQHEDJ91HGx/vwUqMrdU4jupdBLKcuk HluU0FmO5JKcoFoY1RAj6DuXrKqd/sdLOzA= Received: from maileast.thefacebook.com ([163.114.130.16]) by mx0a-00082601.pphosted.com with ESMTP id 36b7vwkqns-7 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 27 Jan 2021 16:20:50 -0800 Received: from intmgw002.06.ash9.facebook.com (2620:10d:c0a8:1b::d) by mail.thefacebook.com (2620:10d:c0a8:82::d) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Wed, 27 Jan 2021 16:20:46 -0800 Received: by devbig006.ftw2.facebook.com (Postfix, from userid 4523) id D729462E0B6C; Wed, 27 Jan 2021 16:20:42 -0800 (PST) From: Song Liu To: , , CC: , , , , , Song Liu , Andrii Nakryiko Subject: [PATCH v3 bpf-next 4/4] bpf: runqslower: use task local storage Date: Wed, 27 Jan 2021 16:19:48 -0800 Message-ID: <20210128001948.1637901-5-songliubraving@fb.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20210128001948.1637901-1-songliubraving@fb.com> References: <20210128001948.1637901-1-songliubraving@fb.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-FB-Internal: Safe Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343,18.0.737 definitions=2021-01-27_10:2021-01-27,2021-01-27 signatures=0 X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 bulkscore=0 suspectscore=0 impostorscore=0 lowpriorityscore=0 mlxscore=0 clxscore=1015 mlxlogscore=999 spamscore=0 priorityscore=1501 malwarescore=0 phishscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2101280000 X-FB-Internal: deliver Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org Replace hashtab with task local storage in runqslower. This improves the performance of these BPF programs. The following table summarizes average runtime of these programs, in nanoseconds: task-local hash-prealloc hash-no-prealloc handle__sched_wakeup 125 340 3124 handle__sched_wakeup_new 2812 1510 2998 handle__sched_switch 151 208 991 Note that, task local storage gives better performance than hashtab for handle__sched_wakeup and handle__sched_switch. On the other hand, for handle__sched_wakeup_new, task local storage is slower than hashtab with prealloc. This is because handle__sched_wakeup_new accesses the data for the first time, so it has to allocate the data for task local storage. Once the initial allocation is done, subsequent accesses, as those in handle__sched_wakeup, are much faster with task local storage. If we disable hashtab prealloc, task local storage is much faster for all 3 functions. Acked-by: Andrii Nakryiko Signed-off-by: Song Liu --- tools/bpf/runqslower/runqslower.bpf.c | 33 +++++++++++++++++---------- 1 file changed, 21 insertions(+), 12 deletions(-) diff --git a/tools/bpf/runqslower/runqslower.bpf.c b/tools/bpf/runqslower= /runqslower.bpf.c index 1f18a409f0443..645530ca7e985 100644 --- a/tools/bpf/runqslower/runqslower.bpf.c +++ b/tools/bpf/runqslower/runqslower.bpf.c @@ -11,9 +11,9 @@ const volatile __u64 min_us =3D 0; const volatile pid_t targ_pid =3D 0; =20 struct { - __uint(type, BPF_MAP_TYPE_HASH); - __uint(max_entries, 10240); - __type(key, u32); + __uint(type, BPF_MAP_TYPE_TASK_STORAGE); + __uint(map_flags, BPF_F_NO_PREALLOC); + __type(key, int); __type(value, u64); } start SEC(".maps"); =20 @@ -25,15 +25,20 @@ struct { =20 /* record enqueue timestamp */ __always_inline -static int trace_enqueue(u32 tgid, u32 pid) +static int trace_enqueue(struct task_struct *t) { - u64 ts; + u32 pid =3D t->pid; + u64 *ptr; =20 if (!pid || (targ_pid && targ_pid !=3D pid)) return 0; =20 - ts =3D bpf_ktime_get_ns(); - bpf_map_update_elem(&start, &pid, &ts, 0); + ptr =3D bpf_task_storage_get(&start, t, 0, + BPF_LOCAL_STORAGE_GET_F_CREATE); + if (!ptr) + return 0; + + *ptr =3D bpf_ktime_get_ns(); return 0; } =20 @@ -43,7 +48,7 @@ int handle__sched_wakeup(u64 *ctx) /* TP_PROTO(struct task_struct *p) */ struct task_struct *p =3D (void *)ctx[0]; =20 - return trace_enqueue(p->tgid, p->pid); + return trace_enqueue(p); } =20 SEC("tp_btf/sched_wakeup_new") @@ -52,7 +57,7 @@ int handle__sched_wakeup_new(u64 *ctx) /* TP_PROTO(struct task_struct *p) */ struct task_struct *p =3D (void *)ctx[0]; =20 - return trace_enqueue(p->tgid, p->pid); + return trace_enqueue(p); } =20 SEC("tp_btf/sched_switch") @@ -70,12 +75,16 @@ int handle__sched_switch(u64 *ctx) =20 /* ivcsw: treat like an enqueue event and store timestamp */ if (prev->state =3D=3D TASK_RUNNING) - trace_enqueue(prev->tgid, prev->pid); + trace_enqueue(prev); =20 pid =3D next->pid; =20 + /* For pid mismatch, save a bpf_task_storage_get */ + if (!pid || (targ_pid && targ_pid !=3D pid)) + return 0; + /* fetch timestamp and calculate delta */ - tsp =3D bpf_map_lookup_elem(&start, &pid); + tsp =3D bpf_task_storage_get(&start, next, 0, 0); if (!tsp) return 0; /* missed enqueue */ =20 @@ -91,7 +100,7 @@ int handle__sched_switch(u64 *ctx) bpf_perf_event_output(ctx, &events, BPF_F_CURRENT_CPU, &event, sizeof(event)); =20 - bpf_map_delete_elem(&start, &pid); + bpf_task_storage_delete(&start, next); return 0; } =20 --=20 2.24.1