From: Giuliano Procida <gprocida@google.com>
To: dwarves@vger.kernel.org
Cc: acme@kernel.org, andrii@kernel.org, ast@kernel.org,
gprocida@google.com, maennich@google.com,
kernel-team@android.com, kernel-team@fb.com, bpf@vger.kernel.org
Subject: [PATCH dwarves v3 1/5] btf_encoder: Funnel ELF error reporting through a macro
Date: Fri, 5 Feb 2021 13:42:17 +0000 [thread overview]
Message-ID: <20210205134221.2953163-2-gprocida@google.com> (raw)
In-Reply-To: <20210205134221.2953163-1-gprocida@google.com>
This adds elf_error which prepends error messages with the function
and appends a readable ELF error status.
Also capitalise ELF consistently in error messages.
Signed-off-by: Giuliano Procida <gprocida@google.com>
---
libbtf.c | 34 +++++++++++++++++++---------------
1 file changed, 19 insertions(+), 15 deletions(-)
diff --git a/libbtf.c b/libbtf.c
index 9f76283..7bc49ba 100644
--- a/libbtf.c
+++ b/libbtf.c
@@ -27,6 +27,16 @@
#include "dwarves.h"
#include "elf_symtab.h"
+/*
+ * This depends on the GNU extension to eliminate the stray comma in the zero
+ * arguments case.
+ *
+ * The difference between elf_errmsg(-1) and elf_errmsg(elf_errno()) is that the
+ * latter clears the current error.
+ */
+#define elf_error(fmt, ...) \
+ fprintf(stderr, "%s: " fmt ": %s.\n", __func__, ##__VA_ARGS__, elf_errmsg(-1))
+
struct btf *base_btf;
uint8_t btf_elf__verbose;
uint8_t btf_elf__force;
@@ -103,15 +113,13 @@ try_as_raw_btf:
goto errout;
if (elf_version(EV_CURRENT) == EV_NONE) {
- fprintf(stderr, "%s: cannot set libelf version.\n",
- __func__);
+ elf_error("cannot set libelf version");
goto errout;
}
btfe->elf = elf_begin(btfe->in_fd, ELF_C_READ_MMAP, NULL);
if (!btfe->elf) {
- fprintf(stderr, "%s: cannot read %s ELF file: %s.\n",
- __func__, filename, elf_errmsg(elf_errno()));
+ elf_error("cannot read %s ELF file", filename);
goto errout;
}
}
@@ -127,7 +135,7 @@ try_as_raw_btf:
goto try_as_raw_btf;
}
if (btf_elf__verbose)
- fprintf(stderr, "%s: cannot get elf header.\n", __func__);
+ elf_error("cannot get ELF header");
goto errout;
}
@@ -141,7 +149,7 @@ try_as_raw_btf:
btf__set_endianness(btfe->btf, BTF_BIG_ENDIAN);
break;
default:
- fprintf(stderr, "%s: unknown elf endianness.\n", __func__);
+ fprintf(stderr, "%s: unknown ELF endianness.\n", __func__);
goto errout;
}
@@ -707,15 +715,13 @@ static int btf_elf__write(const char *filename, struct btf *btf)
}
if (elf_version(EV_CURRENT) == EV_NONE) {
- fprintf(stderr, "Cannot set libelf version: %s.\n",
- elf_errmsg(elf_errno()));
+ elf_error("Cannot set libelf version");
goto out;
}
elf = elf_begin(fd, ELF_C_RDWR, NULL);
if (elf == NULL) {
- fprintf(stderr, "Cannot update ELF file: %s.\n",
- elf_errmsg(elf_errno()));
+ elf_error("Cannot update ELF file");
goto out;
}
@@ -723,8 +729,7 @@ static int btf_elf__write(const char *filename, struct btf *btf)
ehdr = gelf_getehdr(elf, &ehdr_mem);
if (ehdr == NULL) {
- fprintf(stderr, "%s: elf_getehdr failed: %s.\n", __func__,
- elf_errmsg(elf_errno()));
+ elf_error("elf_getehdr failed");
goto out;
}
@@ -736,7 +741,7 @@ static int btf_elf__write(const char *filename, struct btf *btf)
btf__set_endianness(btf, BTF_BIG_ENDIAN);
break;
default:
- fprintf(stderr, "%s: unknown elf endianness.\n", __func__);
+ fprintf(stderr, "%s: unknown ELF endianness.\n", __func__);
goto out;
}
@@ -768,8 +773,7 @@ static int btf_elf__write(const char *filename, struct btf *btf)
elf_update(elf, ELF_C_WRITE) >= 0)
err = 0;
else
- fprintf(stderr, "%s: elf_update failed: %s.\n",
- __func__, elf_errmsg(elf_errno()));
+ elf_error("elf_update failed");
} else {
const char *llvm_objcopy;
char tmp_fn[PATH_MAX];
--
2.30.0.478.g8a0d178c01-goog
next prev parent reply other threads:[~2021-02-05 22:44 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87a83353155506cc02141e6e4108d89aa4e7d284>
2021-02-01 17:25 ` [PATCH dwarves v2 0/4] BTF ELF writing changes Giuliano Procida
2021-02-01 17:25 ` [PATCH dwarves v2 1/4] btf_encoder: Add .BTF section using libelf Giuliano Procida
2021-02-04 4:10 ` Andrii Nakryiko
2021-02-04 18:29 ` Giuliano Procida
2021-02-01 17:25 ` [PATCH dwarves v2 2/4] btf_encoder: Manually lay out updated ELF sections Giuliano Procida
2021-02-04 4:13 ` Andrii Nakryiko
2021-02-04 18:34 ` Giuliano Procida
2021-02-04 23:06 ` Andrii Nakryiko
2021-02-01 17:25 ` [PATCH dwarves v2 3/4] btf_encoder: Add .BTF as a loadable segment Giuliano Procida
2021-02-02 10:54 ` Giuliano Procida
2021-02-01 17:25 ` [PATCH dwarves v2 4/4] btf_encoder: Align .BTF section/segment to 8 bytes Giuliano Procida
2021-02-04 4:10 ` Andrii Nakryiko
2021-02-04 15:11 ` Giuliano Procida
2021-02-04 15:11 ` [PATCH] btf_encoder: Align .BTF section " Giuliano Procida
2021-02-05 13:42 ` [PATCH dwarves v3 0/5] ELF writing changes Giuliano Procida
2021-02-05 13:42 ` Giuliano Procida [this message]
2021-02-08 22:20 ` [PATCH dwarves v3 1/5] btf_encoder: Funnel ELF error reporting through a macro Andrii Nakryiko
2021-02-05 13:42 ` [PATCH dwarves v3 2/5] btf_encoder: Do not use both structs and pointers for the same data Giuliano Procida
2021-02-08 22:23 ` Andrii Nakryiko
2021-02-09 14:52 ` Giuliano Procida
2021-02-05 13:42 ` [PATCH dwarves v3 3/5] btf_encoder: Traverse sections using a for-loop Giuliano Procida
2021-02-08 22:24 ` Andrii Nakryiko
2021-02-09 14:59 ` Giuliano Procida
2021-02-05 13:42 ` [PATCH dwarves v3 4/5] btf_encoder: Add .BTF section using libelf Giuliano Procida
2021-02-08 22:29 ` Andrii Nakryiko
2021-02-09 15:04 ` Giuliano Procida
2021-02-05 13:42 ` [PATCH dwarves v3 5/5] btf_encoder: Align .BTF section to 8 bytes Giuliano Procida
2021-02-08 22:29 ` Andrii Nakryiko
2021-02-09 15:05 ` Giuliano Procida
2021-02-17 11:07 ` [PATCH dwarves v4 0/5] ELF writing changes Giuliano Procida
2021-02-17 11:08 ` [PATCH dwarves v4 1/5] btf_encoder: Funnel ELF error reporting through a macro Giuliano Procida
2021-02-17 11:08 ` [PATCH dwarves v4 2/5] btf_encoder: Do not use both structs and pointers for the same data Giuliano Procida
2021-02-17 11:08 ` [PATCH dwarves v4 3/5] btf_encoder: Traverse sections using a for-loop Giuliano Procida
2021-02-17 11:08 ` [PATCH dwarves v4 4/5] btf_encoder: Add .BTF section using libelf Giuliano Procida
2021-02-17 11:08 ` [PATCH dwarves v4 5/5] btf_encoder: Align .BTF section to 8 bytes Giuliano Procida
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210205134221.2953163-2-gprocida@google.com \
--to=gprocida@google.com \
--cc=acme@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=dwarves@vger.kernel.org \
--cc=kernel-team@android.com \
--cc=kernel-team@fb.com \
--cc=maennich@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).