From: Ciara Loftus <ciara.loftus@intel.com> To: netdev@vger.kernel.org, bpf@vger.kernel.org, magnus.karlsson@intel.com, bjorn@kernel.org, weqaar.a.janjua@intel.com, maciej.fijalkowski@intel.com Cc: Ciara Loftus <ciara.loftus@intel.com> Subject: [PATCH bpf-next v3 0/4] selftests/bpf: xsk improvements and new stats tests Date: Tue, 23 Feb 2021 16:23:00 +0000 Message-ID: <20210223162304.7450-1-ciara.loftus@intel.com> (raw) This series attempts to improve the xsk selftest framework by: 1. making the default output less verbose 2. adding an optional verbose flag to both the test_xsk.sh script and xdpxceiver app. 3. renaming the debug option in the app to to 'dump-pkts' and add a flag to the test_xsk.sh script which enables the flag in the app. 4. changing how tests are launched - now they are launched from the xdpxceiver app instead of the script. Once the improvements are made, a new set of tests are added which test the xsk statistics. The output of the test script now looks like: ./test_xsk.sh PREREQUISITES: [ PASS ] 1..10 ok 1 PASS: SKB NOPOLL ok 2 PASS: SKB POLL ok 3 PASS: SKB NOPOLL Socket Teardown ok 4 PASS: SKB NOPOLL Bi-directional Sockets ok 5 PASS: SKB NOPOLL Stats ok 6 PASS: DRV NOPOLL ok 7 PASS: DRV POLL ok 8 PASS: DRV NOPOLL Socket Teardown ok 9 PASS: DRV NOPOLL Bi-directional Sockets ok 10 PASS: DRV NOPOLL Stats # Totals: pass:10 fail:0 xfail:0 xpass:0 skip:0 error:0 XSK KSELFTESTS: [ PASS ] v2->v3: * Rename dump-pkts to dump_pkts in test_xsk.sh * Add examples of flag usage to test_xsk.sh v1->v2: * Changed '-d' flag in the shell script to '-D' to be consistent with the xdpxceiver app. * Renamed debug mode to 'dump-pkts' which better reflects the behaviour. * Use libpf APIs instead of calls to ss for configuring xdp on the links * Remove mutex init & destroy for each stats test * Added a description for each of the new statistics tests * Distinguish between exiting due to initialisation failure vs test failure This series applies on commit d310ec03a34e92a77302edb804f7d68ee4f01ba0 Ciara Loftus (3): selftests/bpf: expose and rename debug argument selftests/bpf: restructure xsk selftests selftests/bpf: introduce xsk statistics tests Magnus Karlsson (1): selftest/bpf: make xsk tests less verbose tools/testing/selftests/bpf/test_xsk.sh | 135 ++------ tools/testing/selftests/bpf/xdpxceiver.c | 380 +++++++++++++++------ tools/testing/selftests/bpf/xdpxceiver.h | 57 +++- tools/testing/selftests/bpf/xsk_prereqs.sh | 30 +- 4 files changed, 342 insertions(+), 260 deletions(-) -- 2.17.1
next reply index Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-23 16:23 Ciara Loftus [this message] 2021-02-23 16:23 ` [PATCH bpf-next v3 1/4] selftest/bpf: make xsk tests less verbose Ciara Loftus 2021-02-23 16:23 ` [PATCH bpf-next v3 2/4] selftests/bpf: expose and rename debug argument Ciara Loftus 2021-02-23 16:23 ` [PATCH bpf-next v3 3/4] selftests/bpf: restructure xsk selftests Ciara Loftus 2021-02-23 16:23 ` [PATCH bpf-next v3 4/4] selftests/bpf: introduce xsk statistics tests Ciara Loftus 2021-03-02 10:20 ` [PATCH bpf-next v3 0/4] selftests/bpf: xsk improvements and new stats tests Björn Töpel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210223162304.7450-1-ciara.loftus@intel.com \ --to=ciara.loftus@intel.com \ --cc=bjorn@kernel.org \ --cc=bpf@vger.kernel.org \ --cc=maciej.fijalkowski@intel.com \ --cc=magnus.karlsson@intel.com \ --cc=netdev@vger.kernel.org \ --cc=weqaar.a.janjua@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
BPF Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/bpf/0 bpf/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 bpf bpf/ https://lore.kernel.org/bpf \ bpf@vger.kernel.org public-inbox-index bpf Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.bpf AGPL code for this site: git clone https://public-inbox.org/public-inbox.git