From: kernel test robot <lkp@intel.com>
To: Masami Hiramatsu <mhiramat@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>
Cc: Daniel Xu <dxu@dxuuu.xyz>,
linux-kernel@vger.kernel.org,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
kuba@kernel.org
Subject: Re: [PATCH] kprobes: stacktrace: Recover the address changed by kretprobe
Date: Fri, 5 Mar 2021 04:25:37 +0800 [thread overview]
Message-ID: <202103050435.9W2taCWY-lkp@intel.com> (raw)
In-Reply-To: <20210304221947.5a177ce2e1e94314e57c38a4@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 3600 bytes --]
Hi Masami,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.12-rc1 next-20210304]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Masami-Hiramatsu/kprobes-stacktrace-Recover-the-address-changed-by-kretprobe/20210304-212528
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git f69d02e37a85645aa90d18cacfff36dba370f797
config: parisc-allyesconfig (attached as .config)
compiler: hppa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/2204ff150821a6a3c13b4fa10784b5efb3e3adc8
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Masami-Hiramatsu/kprobes-stacktrace-Recover-the-address-changed-by-kretprobe/20210304-212528
git checkout 2204ff150821a6a3c13b4fa10784b5efb3e3adc8
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=parisc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
kernel/kprobes.c:1847:12: warning: no previous prototype for 'kprobe_exceptions_notify' [-Wmissing-prototypes]
1847 | int __weak kprobe_exceptions_notify(struct notifier_block *self,
| ^~~~~~~~~~~~~~~~~~~~~~~~
kernel/kprobes.c: In function 'kretprobe_real_stack_tsk':
>> kernel/kprobes.c:1874:30: error: 'kretprobe_trampoline' undeclared (first use in this function); did you mean 'kretprobe_blackpoint'?
1874 | if (addr != (unsigned long)&kretprobe_trampoline)
| ^~~~~~~~~~~~~~~~~~~~
| kretprobe_blackpoint
kernel/kprobes.c:1874:30: note: each undeclared identifier is reported only once for each function it appears in
kernel/kprobes.c: In function '__kretprobe_trampoline_handler':
kernel/kprobes.c:1904:21: error: 'kretprobe_trampoline' undeclared (first use in this function); did you mean 'kretprobe_blackpoint'?
1904 | (unsigned long)&kretprobe_trampoline, &node);
| ^~~~~~~~~~~~~~~~~~~~
| kretprobe_blackpoint
vim +1874 kernel/kprobes.c
1865
1866 /* This assumes the tsk is current or the task which is not running. */
1867 unsigned long kretprobe_real_stack_tsk(struct task_struct *tsk,
1868 unsigned long addr,
1869 struct llist_node **cur)
1870 {
1871 struct kretprobe_instance *ri = NULL;
1872 struct llist_node *node = *cur;
1873
> 1874 if (addr != (unsigned long)&kretprobe_trampoline)
1875 return addr;
1876
1877 if (!node)
1878 node = tsk->kretprobe_instances.first;
1879 else
1880 node = node->next;
1881
1882 while (node) {
1883 ri = container_of(node, struct kretprobe_instance, llist);
1884 if (ri->ret_addr != (void *)&kretprobe_trampoline) {
1885 *cur = node;
1886 return (unsigned long)ri->ret_addr;
1887 }
1888 node = node->next;
1889 }
1890 return 0;
1891 }
1892
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 68018 bytes --]
next prev parent reply other threads:[~2021-03-04 20:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 1:15 Broken kretprobe stack traces Daniel Xu
2021-03-03 4:48 ` Masami Hiramatsu
2021-03-03 14:26 ` Steven Rostedt
2021-03-03 19:58 ` Daniel Xu
2021-03-03 20:13 ` Daniel Xu
2021-03-03 20:37 ` Steven Rostedt
2021-03-04 2:18 ` Daniel Xu
2021-03-04 19:04 ` Daniel Xu
2021-03-04 13:19 ` Masami Hiramatsu
2021-03-04 15:22 ` [PATCH] kprobes: stacktrace: Recover the address changed by kretprobe kernel test robot
2021-03-04 17:37 ` kernel test robot
2021-03-04 20:25 ` kernel test robot [this message]
2021-03-03 19:57 ` Broken kretprobe stack traces Daniel Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202103050435.9W2taCWY-lkp@intel.com \
--to=lkp@intel.com \
--cc=bpf@vger.kernel.org \
--cc=dxu@dxuuu.xyz \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).