bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH bpf-next] bpf: Remove insn_buf[] declaration in inner block
@ 2021-03-18  2:48 Jianlin Lv
  2021-03-19 22:10 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Jianlin Lv @ 2021-03-18  2:48 UTC (permalink / raw)
  To: bpf
  Cc: ast, daniel, andrii, kafai, songliubraving, yhs, john.fastabend,
	kpsingh, linux-kernel, netdev, Jianlin.Lv, iecedge

Two insn_buf[16] variables are declared in the function, which act on
function scope and block scope respectively.
The statement in the inner blocks is redundant, so remove it.

Signed-off-by: Jianlin Lv <Jianlin.Lv@arm.com>
---
 kernel/bpf/verifier.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
index f9096b049cd6..e26c5170c953 100644
--- a/kernel/bpf/verifier.c
+++ b/kernel/bpf/verifier.c
@@ -11899,7 +11899,6 @@ static int do_misc_fixups(struct bpf_verifier_env *env)
 		    insn->code == (BPF_ALU64 | BPF_SUB | BPF_X)) {
 			const u8 code_add = BPF_ALU64 | BPF_ADD | BPF_X;
 			const u8 code_sub = BPF_ALU64 | BPF_SUB | BPF_X;
-			struct bpf_insn insn_buf[16];
 			struct bpf_insn *patch = &insn_buf[0];
 			bool issrc, isneg;
 			u32 off_reg;
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH bpf-next] bpf: Remove insn_buf[] declaration in inner block
  2021-03-18  2:48 [PATCH bpf-next] bpf: Remove insn_buf[] declaration in inner block Jianlin Lv
@ 2021-03-19 22:10 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-03-19 22:10 UTC (permalink / raw)
  To: Jianlin Lv
  Cc: bpf, ast, daniel, andrii, kafai, songliubraving, yhs,
	john.fastabend, kpsingh, linux-kernel, netdev, iecedge

Hello:

This patch was applied to bpf/bpf-next.git (refs/heads/master):

On Thu, 18 Mar 2021 10:48:51 +0800 you wrote:
> Two insn_buf[16] variables are declared in the function, which act on
> function scope and block scope respectively.
> The statement in the inner blocks is redundant, so remove it.
> 
> Signed-off-by: Jianlin Lv <Jianlin.Lv@arm.com>
> ---
>  kernel/bpf/verifier.c | 1 -
>  1 file changed, 1 deletion(-)

Here is the summary with links:
  - [bpf-next] bpf: Remove insn_buf[] declaration in inner block
    https://git.kernel.org/bpf/bpf-next/c/9ef05281e5d0

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-03-19 22:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-18  2:48 [PATCH bpf-next] bpf: Remove insn_buf[] declaration in inner block Jianlin Lv
2021-03-19 22:10 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).