bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Andrii Nakryiko <andrii@kernel.org>
Cc: bpf@vger.kernel.org, netdev@vger.kernel.org, ast@fb.com,
	daniel@iogearbox.net, kernel-team@fb.com
Subject: Re: [PATCH bpf-next 3/3] selftests/bpf: allow compiling BPF objects without BTF
Date: Fri, 19 Mar 2021 19:21:56 -0700	[thread overview]
Message-ID: <20210320022156.eqtmldxpzxkh45a7@ast-mbp> (raw)
In-Reply-To: <20210319205909.1748642-4-andrii@kernel.org>

On Fri, Mar 19, 2021 at 01:59:09PM -0700, Andrii Nakryiko wrote:
> Add ability to skip BTF generation for some BPF object files. This is done
> through using a convention of .nobtf.c file name suffix.
> 
> Also add third statically linked file to static_linked selftest. This file has
> no BTF, causing resulting object file to have only some of DATASEC BTF types.
> It also is using (from BPF code) global variables. This tests both libbpf's
> static linking logic and bpftool's skeleton generation logic.

I don't like the long term direction of patch 1 and 3.
BTF is mandatory for the most bpf kernel features added in the last couple years.
Making user space do quirks for object files without BTF is not something
we should support or maintain. If there is no BTF the linker and skeleton
generation shouldn't crash, of course, but they should reject such object.

  reply	other threads:[~2021-03-20  2:22 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-19 20:59 [PATCH bpf-next 0/3] Handle no-BTF object files better Andrii Nakryiko
2021-03-19 20:59 ` [PATCH bpf-next 1/3] bpftool: improve skeleton generation for objects without BTF Andrii Nakryiko
2021-03-19 20:59 ` [PATCH bpf-next 2/3] libbpf: skip BTF fixup if object file has no BTF Andrii Nakryiko
2021-03-19 21:25   ` Jiri Olsa
2021-03-19 20:59 ` [PATCH bpf-next 3/3] selftests/bpf: allow compiling BPF objects without BTF Andrii Nakryiko
2021-03-20  2:21   ` Alexei Starovoitov [this message]
2021-03-20 17:00     ` Andrii Nakryiko
2021-03-22  1:07       ` Alexei Starovoitov
2021-03-22 16:56         ` Andrii Nakryiko
2021-03-22 17:54           ` Alexei Starovoitov
2021-03-26 16:44             ` Andrii Nakryiko
2021-03-29  1:16               ` Alexei Starovoitov
2021-03-29  6:09                 ` Andrii Nakryiko
2021-03-29 18:55                   ` Alexei Starovoitov
2021-03-30 18:00                     ` Andrii Nakryiko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210320022156.eqtmldxpzxkh45a7@ast-mbp \
    --to=alexei.starovoitov@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@fb.com \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=kernel-team@fb.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).