* [PATCH bpf-next] bpf: Fix a spelling typo in kernel/bpf/disasm.c
@ 2021-03-25 2:05 Xu Kuohai
2021-03-25 10:14 ` Brendan Jackman
0 siblings, 1 reply; 2+ messages in thread
From: Xu Kuohai @ 2021-03-25 2:05 UTC (permalink / raw)
To: bpf, ast; +Cc: jackmanb
The name string for BPF_XOR is "xor", not "or", fix it.
Signed-off-by: Xu Kuohai <xukuohai@huawei.com>
---
kernel/bpf/disasm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/bpf/disasm.c b/kernel/bpf/disasm.c
index 3acc7e0b6916..faa54d58972c 100644
--- a/kernel/bpf/disasm.c
+++ b/kernel/bpf/disasm.c
@@ -84,7 +84,7 @@ static const char *const bpf_atomic_alu_string[16] = {
[BPF_ADD >> 4] = "add",
[BPF_AND >> 4] = "and",
[BPF_OR >> 4] = "or",
- [BPF_XOR >> 4] = "or",
+ [BPF_XOR >> 4] = "xor",
};
static const char *const bpf_ldst_string[] = {
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH bpf-next] bpf: Fix a spelling typo in kernel/bpf/disasm.c
2021-03-25 2:05 [PATCH bpf-next] bpf: Fix a spelling typo in kernel/bpf/disasm.c Xu Kuohai
@ 2021-03-25 10:14 ` Brendan Jackman
0 siblings, 0 replies; 2+ messages in thread
From: Brendan Jackman @ 2021-03-25 10:14 UTC (permalink / raw)
To: Xu Kuohai; +Cc: bpf, Alexei Starovoitov
[Sorry if you get this duplicated - I forgot to switch off HTML mode
the first time]
Oops, thanks.
On Thu, 25 Mar 2021 at 03:04, Xu Kuohai <xukuohai@huawei.com> wrote:
>
> The name string for BPF_XOR is "xor", not "or", fix it.
>
> Signed-off-by: Xu Kuohai <xukuohai@huawei.com>
Please add:
Fixes: 981f94c3e92146705b ("bpf: Add bitwise atomic instructions")
Except for that:
Acked-by: Brendan Jackman <jackmanb@google.com>
> ---
> kernel/bpf/disasm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/bpf/disasm.c b/kernel/bpf/disasm.c
> index 3acc7e0b6916..faa54d58972c 100644
> --- a/kernel/bpf/disasm.c
> +++ b/kernel/bpf/disasm.c
> @@ -84,7 +84,7 @@ static const char *const bpf_atomic_alu_string[16] = {
> [BPF_ADD >> 4] = "add",
> [BPF_AND >> 4] = "and",
> [BPF_OR >> 4] = "or",
> - [BPF_XOR >> 4] = "or",
> + [BPF_XOR >> 4] = "xor",
> };
>
> static const char *const bpf_ldst_string[] = {
> --
> 2.27.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-25 10:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-25 2:05 [PATCH bpf-next] bpf: Fix a spelling typo in kernel/bpf/disasm.c Xu Kuohai
2021-03-25 10:14 ` Brendan Jackman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).