From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bpf-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,
	USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id B80C3C433B4
	for <bpf@archiver.kernel.org>; Sun, 25 Apr 2021 11:15:51 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 8373360234
	for <bpf@archiver.kernel.org>; Sun, 25 Apr 2021 11:15:51 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S229707AbhDYLQ3 (ORCPT <rfc822;bpf@archiver.kernel.org>);
        Sun, 25 Apr 2021 07:16:29 -0400
Received: from mx2.suse.de ([195.135.220.15]:34234 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S229659AbhDYLQ3 (ORCPT <rfc822;bpf@vger.kernel.org>);
        Sun, 25 Apr 2021 07:16:29 -0400
X-Virus-Scanned: by amavisd-new at test-mx.suse.de
Received: from relay2.suse.de (unknown [195.135.221.27])
        by mx2.suse.de (Postfix) with ESMTP id 4C1D9B1DC;
        Sun, 25 Apr 2021 11:15:48 +0000 (UTC)
Date:   Sun, 25 Apr 2021 13:15:45 +0200
From:   Michal =?iso-8859-1?Q?Such=E1nek?= <msuchanek@suse.de>
To:     Yonghong Song <yhs@fb.com>
Cc:     linux-kernel@vger.kernel.org, Martin KaFai Lau <kafai@fb.com>,
        "David S. Miller" <davem@davemloft.net>,
        Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
        David Ahern <dsahern@kernel.org>,
        Jakub Kicinski <kuba@kernel.org>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Song Liu <songliubraving@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>, netdev@vger.kernel.org,
        bpf@vger.kernel.org
Subject: Re: linux-next failing build due to missing cubictcp_state symbol
Message-ID: <20210425111545.GL15381@kitsune.suse.cz>
References: <20210423130530.GA6564@kitsune.suse.cz>
 <316e86f9-35cc-36b0-1594-00a09631c736@fb.com>
 <20210423175528.GF6564@kitsune.suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20210423175528.GF6564@kitsune.suse.cz>
User-Agent: Mutt/1.11.3 (2019-02-01)
Precedence: bulk
List-ID: <bpf.vger.kernel.org>
X-Mailing-List: bpf@vger.kernel.org

On Fri, Apr 23, 2021 at 07:55:28PM +0200, Michal Suchánek wrote:
> On Fri, Apr 23, 2021 at 07:41:29AM -0700, Yonghong Song wrote:
> > 
> > 
> > On 4/23/21 6:05 AM, Michal Suchánek wrote:
> > > Hello,
> > > 
> > > I see this build error in linux-next (config attached).
> > > 
> > > [ 4939s]   LD      vmlinux
> > > [ 4959s]   BTFIDS  vmlinux
> > > [ 4959s] FAILED unresolved symbol cubictcp_state
> > > [ 4960s] make[1]: ***
> > > [/home/abuild/rpmbuild/BUILD/kernel-vanilla-5.12~rc8.next.20210422/linux-5.12-rc8-next-20210422/Makefile:1277:
> > > vmlinux] Error 255
> > > [ 4960s] make: *** [../Makefile:222: __sub-make] Error 2
> > 
> > Looks like you have DYNAMIC_FTRACE config option enabled already.
> > Could you try a later version of pahole?
> 
> Is this requireent new?
> 
> I have pahole 1.20, and master does build without problems.
> 
> If newer version is needed can a check be added?

With dwarves 1.21 some architectures are fixed and some report other
missing symbol. Definitely an improvenent.

I see some new type support was added so it makes sense if that type is
used the new dwarves are needed.

Thanks

Michal