From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0474DC433B4 for ; Sat, 1 May 2021 10:54:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D473C613EC for ; Sat, 1 May 2021 10:54:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231912AbhEAKyy (ORCPT ); Sat, 1 May 2021 06:54:54 -0400 Received: from mx2.suse.de ([195.135.220.15]:39988 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231893AbhEAKyx (ORCPT ); Sat, 1 May 2021 06:54:53 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id B6469AFDC; Sat, 1 May 2021 10:54:02 +0000 (UTC) Date: Sat, 1 May 2021 12:54:00 +0200 From: Michal =?iso-8859-1?Q?Such=E1nek?= To: Jiri Slaby Cc: Jiri Olsa , Yonghong Song , linux-kernel@vger.kernel.org, Martin KaFai Lau , "David S. Miller" , Hideaki YOSHIFUJI , David Ahern , Jakub Kicinski , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Song Liu , John Fastabend , KP Singh , netdev@vger.kernel.org, bpf@vger.kernel.org, Jiri Olsa , Jesper Dangaard Brouer Subject: Re: linux-next failing build due to missing cubictcp_state symbol Message-ID: <20210501105400.GG6564@kitsune.suse.cz> References: <20210425111545.GL15381@kitsune.suse.cz> <20210426113215.GM15381@kitsune.suse.cz> <20210426121220.GN15381@kitsune.suse.cz> <20210426121401.GO15381@kitsune.suse.cz> <49f84147-bf32-dc59-48e0-f89241cf6264@fb.com> <20210427121237.GK6564@kitsune.suse.cz> <20210430174723.GP15381@kitsune.suse.cz> <3d148516-0472-8f0a-085b-94d68c5cc0d5@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3d148516-0472-8f0a-085b-94d68c5cc0d5@suse.com> User-Agent: Mutt/1.11.3 (2019-02-01) Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Sat, May 01, 2021 at 08:45:50AM +0200, Jiri Slaby wrote: > On 30. 04. 21, 19:47, Michal Suchánek wrote: > > CC another Jiri > > > > On Tue, Apr 27, 2021 at 02:12:37PM +0200, Michal Suchánek wrote: > > > On Mon, Apr 26, 2021 at 09:16:36PM +0200, Jiri Olsa wrote: > > > > On Mon, Apr 26, 2021 at 06:03:19PM +0200, Jiri Olsa wrote: > > > > > On Mon, Apr 26, 2021 at 08:41:49AM -0700, Yonghong Song wrote: > > > > > > > > > > > > > > > > > > On 4/26/21 5:14 AM, Michal Suchánek wrote: > > > > > > > On Mon, Apr 26, 2021 at 02:12:20PM +0200, Michal Suchánek wrote: > > > > > > > > On Mon, Apr 26, 2021 at 01:32:15PM +0200, Michal Suchánek wrote: > > > > > > > > > On Sun, Apr 25, 2021 at 01:15:45PM +0200, Michal Suchánek wrote: > > > > > > > > > > On Fri, Apr 23, 2021 at 07:55:28PM +0200, Michal Suchánek wrote: > > > > > > > > > > > On Fri, Apr 23, 2021 at 07:41:29AM -0700, Yonghong Song wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On 4/23/21 6:05 AM, Michal Suchánek wrote: > > > > > > > > > > > > > Hello, > > > > > > > > > > > > > > > > > > > > > > > > > > I see this build error in linux-next (config attached). > > > > > > > > > > > > > > > > > > > > > > > > > > [ 4939s] LD vmlinux > > > > > > > > > > > > > [ 4959s] BTFIDS vmlinux > > > > > > > > > > > > > [ 4959s] FAILED unresolved symbol cubictcp_state > > > > > > > > > > > > > [ 4960s] make[1]: *** > > > > > > > > > > > > > [/home/abuild/rpmbuild/BUILD/kernel-vanilla-5.12~rc8.next.20210422/linux-5.12-rc8-next-20210422/Makefile:1277: > > > > > > > > > > > > > vmlinux] Error 255 > > > > > > > > > > > > > [ 4960s] make: *** [../Makefile:222: __sub-make] Error 2 > > > > > > > > > > this one was reported by Jesper and was fixed by upgrading pahole > > > > > that contains the new function generation fixes (v1.19) > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Looks like you have DYNAMIC_FTRACE config option enabled already. > > > > > > > > > > > > Could you try a later version of pahole? > > > > > > > > > > > > > > > > > > > > > > Is this requireent new? > > > > > > > > > > > > > > > > > > > > > > I have pahole 1.20, and master does build without problems. > > > > > > > > > > > > > > > > > > > > > > If newer version is needed can a check be added? > > > > > > > > > > > > > > > > > > > > With dwarves 1.21 some architectures are fixed and some report other > > > > > > > > > > missing symbol. Definitely an improvenent. > > > > > > > > > > > > > > > > > > > > I see some new type support was added so it makes sense if that type is > > > > > > > > > > used the new dwarves are needed. > > > > > > > > > > > > > > > > > > Ok, here is the current failure with dwarves 1.21 on 5.12: > > > > > > > > > > > > > > > > > > [ 2548s] LD vmlinux > > > > > > > > > [ 2557s] BTFIDS vmlinux > > > > > > > > > [ 2557s] FAILED unresolved symbol vfs_truncate > > > > > > > > > [ 2558s] make[1]: *** > > > > > > > > > [/home/abuild/rpmbuild/BUILD/kernel-kvmsmall-5.12.0/linux-5.12/Makefile:1213: > > > > > > > > > vmlinux] Error 255 > > > > > > > > > > > > This is PPC64, from attached config: > > > > > > CONFIG_PPC64=y > > > > > > I don't have environment to cross-compile for PPC64. > > > > > > Jiri, could you take a look? Thanks! > > > > > > > > > > looks like vfs_truncate did not get into BTF data, > > > > > I'll try to reproduce > > _None_ of the functions are generated by pahole -J from debuginfo on ppc64. > debuginfo appears to be correct. Neither pahole -J fs/open.o works > correctly. collect_functions in dwarves seems to be defunct on ppc64... > "functions" array is bogus (so find_function -- the bsearch -- fails). I > didn't have more time to continue debugging. This is where I stopped. A workaround is to apply https://lore.kernel.org/linuxppc-dev/20200428112517.1402927-1-npiggin@gmail.com/ and build as ABI v2 Thanks Michal