From: Martin KaFai Lau <kafai@fb.com>
To: Kuniyuki Iwashima <kuniyu@amazon.co.jp>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Benjamin Herrenschmidt <benh@amazon.com>,
Kuniyuki Iwashima <kuni1840@gmail.com>, <bpf@vger.kernel.org>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 bpf-next 08/11] bpf: Support BPF_FUNC_get_socket_cookie() for BPF_PROG_TYPE_SK_REUSEPORT.
Date: Fri, 14 May 2021 18:16:55 -0700 [thread overview]
Message-ID: <20210515011655.q5v7nnbonvo3a7wg@kafai-mbp> (raw)
In-Reply-To: <20210510034433.52818-9-kuniyu@amazon.co.jp>
On Mon, May 10, 2021 at 12:44:30PM +0900, Kuniyuki Iwashima wrote:
> diff --git a/net/core/filter.c b/net/core/filter.c
> index cae56d08a670..3d0f989f5d38 100644
> --- a/net/core/filter.c
> +++ b/net/core/filter.c
> @@ -10135,6 +10135,8 @@ sk_reuseport_func_proto(enum bpf_func_id func_id,
> return &sk_reuseport_load_bytes_proto;
> case BPF_FUNC_skb_load_bytes_relative:
> return &sk_reuseport_load_bytes_relative_proto;
> + case BPF_FUNC_get_socket_cookie:
> + return &bpf_get_socket_ptr_cookie_proto;
> default:
> return bpf_base_func_proto(func_id);
> }
> @@ -10164,6 +10166,10 @@ sk_reuseport_is_valid_access(int off, int size,
> case offsetof(struct sk_reuseport_md, hash):
> return size == size_default;
>
> + case offsetof(struct sk_reuseport_md, sk):
> + info->reg_type = ARG_PTR_TO_SOCKET;
s/ARG_PTR_TO_SOCKET/PTR_TO_SOCKET/
> + return size == sizeof(__u64);
> +
> /* Fields that allow narrowing */
> case bpf_ctx_range(struct sk_reuseport_md, eth_protocol):
> if (size < sizeof_field(struct sk_buff, protocol))
next prev parent reply other threads:[~2021-05-15 1:17 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-10 3:44 [PATCH v5 bpf-next 00/11] Socket migration for SO_REUSEPORT Kuniyuki Iwashima
2021-05-10 3:44 ` [PATCH v5 bpf-next 01/11] net: Introduce net.ipv4.tcp_migrate_req Kuniyuki Iwashima
2021-05-15 0:47 ` Martin KaFai Lau
2021-05-15 4:01 ` Kuniyuki Iwashima
2021-05-10 3:44 ` [PATCH v5 bpf-next 02/11] tcp: Add num_closed_socks to struct sock_reuseport Kuniyuki Iwashima
2021-05-15 0:49 ` Martin KaFai Lau
2021-05-15 4:03 ` Kuniyuki Iwashima
2021-05-10 3:44 ` [PATCH v5 bpf-next 03/11] tcp: Keep TCP_CLOSE sockets in the reuseport group Kuniyuki Iwashima
2021-05-10 3:44 ` [PATCH v5 bpf-next 04/11] tcp: Add reuseport_migrate_sock() to select a new listener Kuniyuki Iwashima
2021-05-10 3:44 ` [PATCH v5 bpf-next 05/11] tcp: Migrate TCP_ESTABLISHED/TCP_SYN_RECV sockets in accept queues Kuniyuki Iwashima
2021-05-15 1:06 ` Martin KaFai Lau
2021-05-15 4:14 ` Kuniyuki Iwashima
2021-05-10 3:44 ` [PATCH v5 bpf-next 06/11] tcp: Migrate TCP_NEW_SYN_RECV requests at retransmitting SYN+ACKs Kuniyuki Iwashima
2021-05-10 3:44 ` [PATCH v5 bpf-next 07/11] tcp: Migrate TCP_NEW_SYN_RECV requests at receiving the final ACK Kuniyuki Iwashima
2021-05-15 1:13 ` Martin KaFai Lau
2021-05-15 4:18 ` Kuniyuki Iwashima
2021-05-10 3:44 ` [PATCH v5 bpf-next 08/11] bpf: Support BPF_FUNC_get_socket_cookie() for BPF_PROG_TYPE_SK_REUSEPORT Kuniyuki Iwashima
2021-05-15 1:16 ` Martin KaFai Lau [this message]
2021-05-15 4:20 ` Kuniyuki Iwashima
2021-05-10 3:44 ` [PATCH v5 bpf-next 09/11] bpf: Support socket migration by eBPF Kuniyuki Iwashima
2021-05-10 3:44 ` [PATCH v5 bpf-next 10/11] libbpf: Set expected_attach_type for BPF_PROG_TYPE_SK_REUSEPORT Kuniyuki Iwashima
2021-05-10 3:44 ` [PATCH v5 bpf-next 11/11] bpf: Test BPF_SK_REUSEPORT_SELECT_OR_MIGRATE Kuniyuki Iwashima
2021-05-15 2:05 ` Martin KaFai Lau
2021-05-15 4:27 ` Kuniyuki Iwashima
2021-05-13 21:27 ` [PATCH v5 bpf-next 00/11] Socket migration for SO_REUSEPORT Andrii Nakryiko
2021-05-13 23:23 ` Kuniyuki Iwashima
2021-05-14 6:26 ` Martin KaFai Lau
2021-05-15 3:48 ` Kuniyuki Iwashima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210515011655.q5v7nnbonvo3a7wg@kafai-mbp \
--to=kafai@fb.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=benh@amazon.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=kuni1840@gmail.com \
--cc=kuniyu@amazon.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).