From: Cong Wang <xiyou.wangcong@gmail.com>
To: netdev@vger.kernel.org
Cc: bpf@vger.kernel.org, Cong Wang <cong.wang@bytedance.com>
Subject: [Patch bpf v3 0/8] sock_map: some bug fixes and improvements
Date: Wed, 26 May 2021 18:11:47 -0700 [thread overview]
Message-ID: <20210527011155.10097-1-xiyou.wangcong@gmail.com> (raw)
From: Cong Wang <cong.wang@bytedance.com>
This patchset contains a few bug fixes and improvements for sock_map.
Patch 1 improves recvmsg() accuracy for UDP, patch 2 improves UDP
non-blocking read() by retrying on EAGAIN. With both of them, the
failure rate of the UDP test case goes down from 10% to 1%.
Patch 3 is memory leak fix I posted, no change since v1. The rest
patches address similar memory leaks or improve error handling,
including one increases sk_drops counter for error cases. Please
check each patch description for more details.
---
v3: add another bug fix as patch 4
update patch 5 accordingly
address John's review on the last patch
fix a few typos in patch descriptions
v2: group all patches together
set max for retries of EAGAIN
Cong Wang (8):
skmsg: improve udp_bpf_recvmsg() accuracy
selftests/bpf: Retry for EAGAIN in udp_redir_to_connected()
udp: fix a memory leak in udp_read_sock()
skmsg: clear skb redirect pointer before dropping it
skmsg: fix a memory leak in sk_psock_verdict_apply()
skmsg: teach sk_psock_verdict_apply() to return errors
skmsg: pass source psock to sk_psock_skb_redirect()
skmsg: increase sk->sk_drops when dropping packets
include/linux/skmsg.h | 2 -
net/core/skmsg.c | 82 +++++++++----------
net/ipv4/tcp_bpf.c | 24 +++++-
net/ipv4/udp.c | 2 +
net/ipv4/udp_bpf.c | 47 +++++++++--
.../selftests/bpf/prog_tests/sockmap_listen.c | 7 +-
6 files changed, 112 insertions(+), 52 deletions(-)
--
2.25.1
next reply other threads:[~2021-05-27 1:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-27 1:11 Cong Wang [this message]
2021-05-27 1:11 ` [Patch bpf v3 1/8] skmsg: improve udp_bpf_recvmsg() accuracy Cong Wang
2021-05-27 1:11 ` [Patch bpf v3 2/8] selftests/bpf: Retry for EAGAIN in udp_redir_to_connected() Cong Wang
2021-05-27 1:11 ` [Patch bpf v3 3/8] udp: fix a memory leak in udp_read_sock() Cong Wang
2021-05-27 1:11 ` [Patch bpf v3 4/8] skmsg: clear skb redirect pointer before dropping it Cong Wang
2021-05-27 1:11 ` [Patch bpf v3 5/8] skmsg: fix a memory leak in sk_psock_verdict_apply() Cong Wang
2021-05-27 1:11 ` [Patch bpf v3 6/8] skmsg: teach sk_psock_verdict_apply() to return errors Cong Wang
2021-05-27 1:11 ` [Patch bpf v3 7/8] skmsg: pass source psock to sk_psock_skb_redirect() Cong Wang
2021-05-27 1:11 ` [Patch bpf v3 8/8] skmsg: increase sk->sk_drops when dropping packets Cong Wang
2021-05-28 5:27 ` John Fastabend
2021-05-29 19:29 ` Cong Wang
2021-06-02 3:39 ` John Fastabend
2021-06-02 3:46 ` [Patch bpf v3 0/8] sock_map: some bug fixes and improvements John Fastabend
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210527011155.10097-1-xiyou.wangcong@gmail.com \
--to=xiyou.wangcong@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=cong.wang@bytedance.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).