From: "Paul E. McKenney" <paulmck@kernel.org>
To: "Toke Høiland-Jørgensen" <toke@redhat.com>
Cc: Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <kafai@fb.com>,
Hangbin Liu <liuhangbin@gmail.com>,
Jesper Dangaard Brouer <brouer@redhat.com>,
Magnus Karlsson <magnus.karlsson@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
bpf@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH bpf-next v3 03/16] xdp: add proper __rcu annotations to redirect map entries
Date: Tue, 22 Jun 2021 16:19:50 -0700 [thread overview]
Message-ID: <20210622231950.GK4397@paulmck-ThinkPad-P17-Gen-1> (raw)
In-Reply-To: <874kdppo45.fsf@toke.dk>
On Tue, Jun 22, 2021 at 11:48:26PM +0200, Toke Høiland-Jørgensen wrote:
> "Paul E. McKenney" <paulmck@kernel.org> writes:
>
> > On Tue, Jun 22, 2021 at 03:55:25PM +0200, Toke Høiland-Jørgensen wrote:
> >> Toke Høiland-Jørgensen <toke@redhat.com> writes:
> >>
> >> >> It would also be great if this scenario in general could be placed
> >> >> under the Documentation/RCU/whatisRCU.rst as an example, so we could
> >> >> refer to the official doc on this, too, if Paul is good with this.
> >> >
> >> > I'll take a look and see if I can find a way to fit it in there...
> >>
> >> OK, I poked around in Documentation/RCU and decided that the most
> >> natural place to put this was in checklist.rst which already talks about
> >> local_bh_disable(), but a bit differently. Fixing that up to correspond
> >> to what we've been discussing in this thread, and adding a mention of
> >> XDP as a usage example, results in the patch below.
> >>
> >> Paul, WDYT?
> >
> > I think that my original paragraph needed to have been updated back
> > when v4.20 came out. And again when RCU Tasks Trace came out. ;-)
> >
> > So I did that updating, then approximated your patch on top of it,
> > as shown below. Does this work for you?
>
> Yup, LGTM, thanks! Shall I just fold that version into the next version
> of my series, or do you want to take it through your tree (I suppose
> it's independent of the rest, so either way is fine by me)?
I currently have the two here in -rcu, most likely for v5.15 (as in
the merge window after the upcoming one):
2b7cb9d95ba4 ("doc: Clarify and expand RCU updaters and corresponding readers")
c6ef58907d22 ("doc: Give XDP as example of non-obvious RCU reader/updater pairing")
I am happy taking it, but if you really would like to add it to your
series, please do take both. ;-)
Thanx, Paul
next prev parent reply other threads:[~2021-06-22 23:19 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 21:27 [PATCH bpf-next v3 00/16] Clean up and document RCU-based object protection for XDP_REDIRECT Toke Høiland-Jørgensen
2021-06-17 21:27 ` [PATCH bpf-next v3 01/16] rcu: Create an unrcu_pointer() to remove __rcu from a pointer Toke Høiland-Jørgensen
2021-06-17 21:27 ` [PATCH bpf-next v3 02/16] bpf: allow RCU-protected lookups to happen from bh context Toke Høiland-Jørgensen
2021-06-17 21:27 ` [PATCH bpf-next v3 03/16] xdp: add proper __rcu annotations to redirect map entries Toke Høiland-Jørgensen
2021-06-18 4:55 ` Martin KaFai Lau
2021-06-18 23:27 ` Daniel Borkmann
2021-06-21 21:39 ` Toke Høiland-Jørgensen
2021-06-21 22:15 ` Daniel Borkmann
2021-06-21 22:35 ` Toke Høiland-Jørgensen
2021-06-22 8:50 ` Daniel Borkmann
2021-06-22 13:55 ` Toke Høiland-Jørgensen
2021-06-22 20:26 ` Paul E. McKenney
2021-06-22 21:48 ` Toke Høiland-Jørgensen
2021-06-22 23:19 ` Paul E. McKenney [this message]
2021-06-23 10:55 ` Toke Høiland-Jørgensen
2021-06-17 21:27 ` [PATCH bpf-next v3 04/16] ena: remove rcu_read_lock() around XDP program invocation Toke Høiland-Jørgensen
2021-06-17 21:27 ` [PATCH bpf-next v3 05/16] bnxt: " Toke Høiland-Jørgensen
2021-06-17 21:27 ` [PATCH bpf-next v3 06/16] thunderx: " Toke Høiland-Jørgensen
2021-06-17 21:27 ` [PATCH bpf-next v3 07/16] freescale: " Toke Høiland-Jørgensen
2021-06-17 21:27 ` [PATCH bpf-next v3 08/16] net: intel: " Toke Høiland-Jørgensen
2021-06-17 21:27 ` [PATCH bpf-next v3 09/16] marvell: " Toke Høiland-Jørgensen
2021-06-17 21:27 ` [PATCH bpf-next v3 10/16] mlx4: " Toke Høiland-Jørgensen
2021-06-17 21:27 ` [PATCH bpf-next v3 11/16] nfp: " Toke Høiland-Jørgensen
2021-06-17 21:27 ` [PATCH bpf-next v3 12/16] qede: " Toke Høiland-Jørgensen
2021-06-17 21:27 ` [PATCH bpf-next v3 13/16] sfc: " Toke Høiland-Jørgensen
2021-06-17 21:27 ` [PATCH bpf-next v3 14/16] netsec: " Toke Høiland-Jørgensen
2021-06-17 21:27 ` [PATCH bpf-next v3 15/16] stmmac: " Toke Høiland-Jørgensen
2021-06-18 9:47 ` Wong Vee Khee
2021-06-17 21:27 ` [PATCH bpf-next v3 16/16] net: ti: " Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210622231950.GK4397@paulmck-ThinkPad-P17-Gen-1 \
--to=paulmck@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=kafai@fb.com \
--cc=kuba@kernel.org \
--cc=liuhangbin@gmail.com \
--cc=magnus.karlsson@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).