From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23D11C11F67 for ; Tue, 29 Jun 2021 17:08:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0160661D72 for ; Tue, 29 Jun 2021 17:08:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232540AbhF2RLV (ORCPT ); Tue, 29 Jun 2021 13:11:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:56404 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232398AbhF2RLV (ORCPT ); Tue, 29 Jun 2021 13:11:21 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 236F361CA2; Tue, 29 Jun 2021 17:08:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1624986533; bh=+dC51rWNo1wDeYPoalM+gQQN7q0mu0SuHEZ2RWtnHzQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ry8PL6pWVxargf19eA97YHT5jTEszXOlOtOKrDK7Ekb7k2Krgiow14jZs1v3Rl4rn Ri55Nzn7c7ucumSSi6ZLqgaLTTOP7ZvTJrkZxt+CyQcxG+kFnLuoS+sg3m9qbraeA8 9qeS6s928pyUDUReY5WziZ1QhvjZbojOLRSVyl+0FjIniRfRsoQ3KWMFgh4Vab5Dyg f49tJlS/HqGYTwnWJPeEWVsgYfOQ0cjs/N9vNGO8c4/UzZVuC/cI5Ac1DUa9fCT6XR 8S5K5+XqI4IrPWxp4w95ReKoiFflr/nJ0UVH5zh8+XG4/O6na92z7H0y0/gv2QJ26U SyZAuVpaR7Svg== Date: Tue, 29 Jun 2021 10:08:52 -0700 From: Jakub Kicinski To: Lorenzo Bianconi Cc: Alexander Duyck , Lorenzo Bianconi , bpf , Netdev , David Miller , Alexei Starovoitov , Daniel Borkmann , shayagr@amazon.com, "Jubran, Samih" , John Fastabend , David Ahern , Jesper Dangaard Brouer , Eelco Chaudron , Jason Wang , Saeed Mahameed , Maciej Fijalkowski , "Karlsson, Magnus" , Tirthendu Subject: Re: [PATCH v9 bpf-next 01/14] net: skbuff: add data_len field to skb_shared_info Message-ID: <20210629100852.56d995a6@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: References: <8ad0d38259a678fb42245368f974f1a5cf47d68d.1623674025.git.lorenzo@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Tue, 29 Jun 2021 14:44:56 +0200 Lorenzo Bianconi wrote: > > On Mon, Jun 14, 2021 at 5:50 AM Lorenzo Bianconi wrote: > > > > > > data_len field will be used for paged frame len for xdp_buff/xdp_frame. > > > This is a preliminary patch to properly support xdp-multibuff > > > > > > Signed-off-by: Lorenzo Bianconi > > > --- > > > include/linux/skbuff.h | 5 ++++- > > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > > > diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h > > > index dbf820a50a39..332ec56c200d 100644 > > > --- a/include/linux/skbuff.h > > > +++ b/include/linux/skbuff.h > > > @@ -522,7 +522,10 @@ struct skb_shared_info { > > > struct sk_buff *frag_list; > > > struct skb_shared_hwtstamps hwtstamps; > > > unsigned int gso_type; > > > - u32 tskey; > > > + union { > > > + u32 tskey; > > > + u32 data_len; > > > + }; > > > > > > > Rather than use the tskey field why not repurpose the gso_size field? > > I would think in the XDP paths that the gso fields would be unused > > since LRO and HW_GRO would be incompatible with XDP anyway. > > ack, I agree. I will fix it in v10. Why is XDP mb incompatible with LRO? I thought that was one of the use cases (mentioned by Willem IIRC).